From: Kevin Hilman <khilman@baylibre.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: meson: add g12a x96 max board
Date: Wed, 19 Dec 2018 15:31:56 -0800 [thread overview]
Message-ID: <7himzpt7o3.fsf@baylibre.com> (raw)
In-Reply-To: <877eg51olo.fsf@dell.be.48ers.dk>
Peter Korsgaard <peter@korsgaard.com> writes:
>>>>>> "Kevin" == Kevin Hilman <khilman@baylibre.com> writes:
>
> > Add the G12a (S905X2) based X96 Max board[1].
> > There is no branding for the manufacturer anywhere on the product, so it
> > took some digging to find the manufacturer. But since there's nothing
> > about the maker on the product I've left it out of the DT name because
> > 1) nobody will no that name and 2) keeps the DT filename shorter.
>
> s/no/know/
Thanks.
> > [1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/
>
> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> > ---
> > Special thanks to Martin Blumenstingl for extra digging for the manufacturer
>
> > .../boot/dts/amlogic/meson-g12a-x96-max.dts | 28 +++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> > b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> > new file mode 100644
> > index 000000000000..fe94765b671e
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> > @@ -0,0 +1,28 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (c) 2018 Amlogic, Inc. All rights reserved.
>
> Amlogic? Shouldn't that be Baylibre?
Yes.
Thanks for the review,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2018-12-19 23:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 0:26 [PATCH 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings Kevin Hilman
2018-12-19 0:26 ` [PATCH 2/2] arm64: dts: meson: add g12a x96 max board Kevin Hilman
2018-12-19 16:13 ` Peter Korsgaard
2018-12-19 23:31 ` Kevin Hilman [this message]
2018-12-22 16:57 ` Martin Blumenstingl
2019-01-08 22:32 ` Martin Blumenstingl
[not found] ` <CACdvmAg3=GmcLOKJ33K6aGks7DRnityd4KiU30qwCb-YWz_EPA@mail.gmail.com>
2019-01-09 22:22 ` Martin Blumenstingl
[not found] ` <CACdvmAhi92uLcBfzoJeqkC94np8t7wg7ivb3dz11cTvAO5D60w@mail.gmail.com>
2019-01-17 19:55 ` Martin Blumenstingl
2018-12-20 5:38 ` [PATCH 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings Chris Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7himzpt7o3.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).