Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/1] ARM: dts: meson8b: another GPU fix
@ 2019-05-12 19:39 Martin Blumenstingl
  2019-05-12 19:39 ` [PATCH 1/1] ARM: dts: meson8b: fix the operating voltage of the Mali GPU Martin Blumenstingl
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Blumenstingl @ 2019-05-12 19:39 UTC (permalink / raw)
  To: khilman, linux-amlogic
  Cc: Martin Blumenstingl, linux-kernel, linux-arm-kernel

Currently I am working on the PWM driver to complete .get_state()
support. This allowed me to read the VDDEE voltage set by u-boot
on my Meson8b boards (EC-100 and Odroid-C1). VDDEE supplies the
Mali GPU.

It turns out that the bootloader configures a VDDEE voltage of 1.10V
instead of 1.15V. 1.15V is actually out-of-range for that regulator
design.

This is meant to be applied on top of my other GPU fixes from [0]
also targetting v5.2 if possible.


[0] https://patchwork.kernel.org/cover/10910101/


Martin Blumenstingl (1):
  ARM: dts: meson8b: fix the operating voltage of the Mali GPU

 arch/arm/boot/dts/meson8b.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.21.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] ARM: dts: meson8b: fix the operating voltage of the Mali GPU
  2019-05-12 19:39 [PATCH 0/1] ARM: dts: meson8b: another GPU fix Martin Blumenstingl
@ 2019-05-12 19:39 ` Martin Blumenstingl
  2019-05-15  0:01   ` Kevin Hilman
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Blumenstingl @ 2019-05-12 19:39 UTC (permalink / raw)
  To: khilman, linux-amlogic
  Cc: Martin Blumenstingl, linux-kernel, linux-arm-kernel

Amlogic's vendor kernel defines an OPP for the GPU on Meson8b boards
with a voltage of 1.15V. It turns out that the vendor kernel relies on
the bootloader to set up the voltage. The bootloader however sets a
fixed voltage of 1.10V.

Amlogic's patched u-boot sources (uboot-2015-01-15-23a3562521) confirm
this:
$ grep -oiE "VDD(EE|AO)_VOLTAGE[ ]+[0-9]+" board/amlogic/configs/m8b_*
  board/amlogic/configs/m8b_m100_v1.h:VDDAO_VOLTAGE            1100
  board/amlogic/configs/m8b_m101_v1.h:VDDAO_VOLTAGE            1100
  board/amlogic/configs/m8b_m102_v1.h:VDDAO_VOLTAGE            1100
  board/amlogic/configs/m8b_m200_v1.h:VDDAO_VOLTAGE            1100
  board/amlogic/configs/m8b_m201_v1.h:VDDEE_VOLTAGE            1100
  board/amlogic/configs/m8b_m201_v1.h:VDDEE_VOLTAGE            1100
  board/amlogic/configs/m8b_m202_v1.h:VDDEE_VOLTAGE            1100

Another hint at this is the VDDEE voltage on the EC-100 and Odroid-C1
boards. The VDDEE regulator supplies the Mali GPU. It's basically a copy
of the VCCK (CPU supply) which means it's limited to 0.86V to 1.14V.

Update the operating voltage of the Mali GPU on Meson8b to 1.10V so it
matches with what the vendor u-boot sets.

Fixes: c3ea80b6138cae ("ARM: dts: meson8b: add the Mali-450 MP2 GPU")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm/boot/dts/meson8b.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index 4b919590dae5..ec67f49116d9 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -163,23 +163,23 @@
 
 		opp-255000000 {
 			opp-hz = /bits/ 64 <255000000>;
-			opp-microvolt = <1150000>;
+			opp-microvolt = <1100000>;
 		};
 		opp-364300000 {
 			opp-hz = /bits/ 64 <364300000>;
-			opp-microvolt = <1150000>;
+			opp-microvolt = <1100000>;
 		};
 		opp-425000000 {
 			opp-hz = /bits/ 64 <425000000>;
-			opp-microvolt = <1150000>;
+			opp-microvolt = <1100000>;
 		};
 		opp-510000000 {
 			opp-hz = /bits/ 64 <510000000>;
-			opp-microvolt = <1150000>;
+			opp-microvolt = <1100000>;
 		};
 		opp-637500000 {
 			opp-hz = /bits/ 64 <637500000>;
-			opp-microvolt = <1150000>;
+			opp-microvolt = <1100000>;
 			turbo-mode;
 		};
 	};
-- 
2.21.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] ARM: dts: meson8b: fix the operating voltage of the Mali GPU
  2019-05-12 19:39 ` [PATCH 1/1] ARM: dts: meson8b: fix the operating voltage of the Mali GPU Martin Blumenstingl
@ 2019-05-15  0:01   ` Kevin Hilman
  0 siblings, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2019-05-15  0:01 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: Martin Blumenstingl, linux-kernel, linux-arm-kernel

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> Amlogic's vendor kernel defines an OPP for the GPU on Meson8b boards
> with a voltage of 1.15V. It turns out that the vendor kernel relies on
> the bootloader to set up the voltage. The bootloader however sets a
> fixed voltage of 1.10V.
>
> Amlogic's patched u-boot sources (uboot-2015-01-15-23a3562521) confirm
> this:
> $ grep -oiE "VDD(EE|AO)_VOLTAGE[ ]+[0-9]+" board/amlogic/configs/m8b_*
>   board/amlogic/configs/m8b_m100_v1.h:VDDAO_VOLTAGE            1100
>   board/amlogic/configs/m8b_m101_v1.h:VDDAO_VOLTAGE            1100
>   board/amlogic/configs/m8b_m102_v1.h:VDDAO_VOLTAGE            1100
>   board/amlogic/configs/m8b_m200_v1.h:VDDAO_VOLTAGE            1100
>   board/amlogic/configs/m8b_m201_v1.h:VDDEE_VOLTAGE            1100
>   board/amlogic/configs/m8b_m201_v1.h:VDDEE_VOLTAGE            1100
>   board/amlogic/configs/m8b_m202_v1.h:VDDEE_VOLTAGE            1100
>
> Another hint at this is the VDDEE voltage on the EC-100 and Odroid-C1
> boards. The VDDEE regulator supplies the Mali GPU. It's basically a copy
> of the VCCK (CPU supply) which means it's limited to 0.86V to 1.14V.
>
> Update the operating voltage of the Mali GPU on Meson8b to 1.10V so it
> matches with what the vendor u-boot sets.
>
> Fixes: c3ea80b6138cae ("ARM: dts: meson8b: add the Mali-450 MP2 GPU")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Queued as a fix for v5.2-rc (branch: v5.2/fixes)

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-12 19:39 [PATCH 0/1] ARM: dts: meson8b: another GPU fix Martin Blumenstingl
2019-05-12 19:39 ` [PATCH 1/1] ARM: dts: meson8b: fix the operating voltage of the Mali GPU Martin Blumenstingl
2019-05-15  0:01   ` Kevin Hilman

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org linux-amlogic@archiver.kernel.org
	public-inbox-index linux-amlogic


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/ public-inbox