From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v2 2/2] reset: meson: add g12a compatible string
Date: Tue, 29 Jan 2019 16:12:10 +0100 [thread overview]
Message-ID: <7hwomno5v9.fsf@baylibre.com> (raw)
In-Reply-To: <20190128181316.30814-3-jbrunet@baylibre.com>
Jerome Brunet <jbrunet@baylibre.com> writes:
> Add a compatible for the new g12a SoC family.
>
> Tested-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/reset/reset-meson.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index 5242e0679df7..a8f6549b3af4 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -134,6 +134,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
> { .compatible = "amlogic,meson8b-reset" },
> { .compatible = "amlogic,meson-gxbb-reset" },
> { .compatible = "amlogic,meson-axg-reset" },
> + { .compatible = "amlogic,meson-g12a-reset" },
> { /* sentinel */ },
Looks like this new compatiable isn't used for anything new in the
driver. Let's not add a new compatible unless it's needed fo rnew
behavior.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-01-29 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 18:13 [PATCH v2 0/2] reset: meson: add g12a SoC support Jerome Brunet
2019-01-28 18:13 ` [PATCH v2 1/2] dt-bindings: reset: meson: add g12a bindings Jerome Brunet
2019-01-28 18:13 ` [PATCH v2 2/2] reset: meson: add g12a compatible string Jerome Brunet
2019-01-29 15:12 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hwomno5v9.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).