archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <>
To: Xingyu Chen <>,
	Wim Van Sebroeck <>,
	Guenter Roeck <>,
	Neil Armstrong <>
Cc: Qianggui Song <>,,
	Jianxin Pan <>,,,,
	Xingyu Chen <>,
	Jerome Brunet <>
Subject: Re: [PATCH] watchdog: meson: Fix the wrong value of left time
Date: Thu, 03 Oct 2019 10:35:20 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Xingyu Chen <> writes:

> The left time value is wrong when we get it by sysfs. The left time value
> should be equal to preset timeout value minus elapsed time value. According
> to the Meson-GXB/GXL datasheets which can be found at [0], the timeout value
> is saved to BIT[0-15] of the WATCHDOG_TCNT, and elapsed time value is saved
> to BIT[16-31] of the WATCHDOG_TCNT.
> [0]:
> Fixes: 683fa50f0e18 ("watchdog: Add Meson GXBB Watchdog Driver")
> Signed-off-by: Xingyu Chen <>

Reviewed-by: Kevin Hilman <>

linux-amlogic mailing list

      parent reply	other threads:[~2019-10-03 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29 10:53 [PATCH] watchdog: meson: Fix the wrong value of left time Xingyu Chen
2019-09-30  8:16 ` Neil Armstrong
2019-09-30 13:12 ` Guenter Roeck
2019-10-03 17:35 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).