Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: afl1 <afl2001@gmail.com>, linux-amlogic@lists.infradead.org
Cc: afl1 <afl2001@gmail.com>
Subject: Re: [PATCH] pinctrl: add tsin pins for meson-gxbb/gxl/gxm
Date: Thu, 13 Jun 2019 12:51:52 -0700
Message-ID: <7hzhml2rhj.fsf@baylibre.com> (raw)
In-Reply-To: <20190613183846.18679-1-afl2001@gmail.com>

Hello,

afl1 <afl2001@gmail.com> writes:

> Sorry for previous two emails. I hoppe this will be correctly formatted.
> This patch adds missing  pins for tsin in meson-gxbb/gxl/gxm  platform.
>
> Author: afl1 <afl2001@gmail.com>
> Date:   Sun Feb 3 11:30:17 2019 +0100
>
>     pinctrl: add tsin pins for meson-gxbb/gxl/gxm

Thanks for wanting to contribute your improvements back to the upstream
kernel.  We really appreciate it.  I have aa few tips/comments for patch
submissions:

It's still not quite the right format for the changelog.  The author and
date are not needed (those come from the email headers).

The changelog will also appear in permanent git history so the "sorry
for the previous two emails" stuff is not relevant for that.  Instead,
just summarize the changes, and epecially answer "why" the changes are
needed.

You're also missing a Signed-off-by.

I highly recommend you read through the "Submitting Patches" guide for
the kernel here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Thanks again for your contributions.  You're not very far off from
having this ready.

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 18:38 afl1
2019-06-13 19:51 ` Kevin Hilman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-06-13 17:50 afl1
2019-06-13 18:02 ` afl1
2019-06-13 19:23 ` Maxime Jourdan
2019-02-03 11:53 Add " afl1
2019-02-03 11:53 ` [PATCH] pinctrl: add " afl1

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hzhml2rhj.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=afl2001@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org linux-amlogic@archiver.kernel.org
	public-inbox-index linux-amlogic


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/ public-inbox