From: Xingyu Chen <xingyu.chen@amlogic.com>
To: Kevin Hilman <khilman@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Hanjie Lin <hanjie.lin@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v2 3/3] reset: add support for the Meson-A1 SoC Reset Controller
Date: Thu, 26 Sep 2019 11:44:25 +0800 [thread overview]
Message-ID: <85eeda38-f04f-71d7-3c45-bc03e8c13953@amlogic.com> (raw)
In-Reply-To: <7hlfucrnlo.fsf@baylibre.com>
Hi, Kevin
Thanks for your reminder
On 2019/9/26 6:57, Kevin Hilman wrote:
> Hi Xingyu,
>
> Xingyu Chen <xingyu.chen@amlogic.com> writes:
>
>> The number of RESET registers and offset of RESET_LEVEL register for
>> Meson-A1 are different from previous SoCs, In order to describe these
>> differences, we introduce the struct meson_reset_param.
>>
>> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Again, order here isn't quite right. Add the reviewed-by tags first,
> and the sender should be the last sign-off.
I will reorder Signed-off and Reviewed in next version
>
> Other than that, driver looks good.
>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com >
> Kevin
>
> .
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-09-26 3:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:34 [PATCH v2 0/3] reset: meson: add Meson-A1 SoC support Xingyu Chen
2019-09-23 8:34 ` [PATCH v2 1/3] arm64: dts: meson: add reset controller for Meson-A1 SoC Xingyu Chen
2019-09-23 8:34 ` [PATCH v2 2/3] dt-bindings: reset: add bindings for the Meson-A1 SoC Reset Controller Xingyu Chen
2019-09-25 22:55 ` Kevin Hilman
2019-09-26 3:40 ` Xingyu Chen
2019-09-23 8:34 ` [PATCH v2 3/3] reset: add support " Xingyu Chen
2019-09-25 22:57 ` Kevin Hilman
2019-09-26 3:44 ` Xingyu Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85eeda38-f04f-71d7-3c45-bc03e8c13953@amlogic.com \
--to=xingyu.chen@amlogic.com \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).