From: Neil Armstrong <narmstrong@baylibre.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steven Price <steven.price@arm.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-amlogic@lists.infradead.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU
Date: Tue, 9 Apr 2019 10:20:39 +0200 [thread overview]
Message-ID: <86843e8b-1dda-f7f3-c2ad-02b7b47743dc@baylibre.com> (raw)
In-Reply-To: <CAL_JsqJj4pae6AuK=HGU5GuZogFKyAbU_y7Ls_CyTcV6qXH_rg@mail.gmail.com>
On 08/04/2019 21:07, Rob Herring wrote:
> On Sun, Apr 7, 2019 at 5:17 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Hi Rob,
>>
>> Le 01/04/2019 13:24, Neil Armstrong a écrit :
>>> On 01/04/2019 12:00, Steven Price wrote:
>>>> On 01/04/2019 09:09, Neil Armstrong wrote:
>>>>> Add the bindings for the Bifrost family of ARM Mali GPUs.
>>>>>
>>>>> The Bifrost GPU architecture is similar to the Midgard family,
>>>>> but with a different Shader Core & Execution Engine structures.
>>>>>
>>>>> Bindings are based on the Midgard family bindings, but the inner
>>>>> architectural changes makes it a separate family needing separate
>>>>> bindings.
>>>>>
>>>>> The Bifrost GPUs are present in a number of recent SoCs, like the
>>>>> Amlogic G12A Family, and many other vendors.
>>>>> The Amlogic vendor specific compatible is added to handle the
>>>>> specific IP integration differences and dependencies.
>>>>>
>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>> ---
>>>>> .../bindings/gpu/arm,mali-bifrost.txt | 92 +++++++++++++++++++
>>>>> 1 file changed, 92 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>>>>
>>>>> Changes since v3:
>>>>> - Added note about discoverable model/revision
>>>>> - Enforced fixed defined irq order
>>>>> - Fixed typo in accommodate
>>>>>
>>>>> Changes since v2:
>>>>> - moved to a single compatible since HW is fully discoverable
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>>>> new file mode 100644
>>>>> index 000000000000..711c9ead17a2
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.txt
>>>>> @@ -0,0 +1,92 @@
>>>>> +ARM Mali Bifrost GPU
>>>>> +====================
>>>>> +
>>>>> +Required properties:
>>>>> +
>>>>> +- compatible :
>>>>> + * Since Mali Bifrost GPU model/revision if fully discoverable by reading
>>>> ^^
>>>> s/if/is/
>>
>> Should I still send a v5 to fixing this typo ? I can fix it while applying it.
>
> No need to resend. I planned to apply it, but if you are going to:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Thanks,
Fixed and applied on drm-misc-next
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-04-09 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 8:09 [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU Neil Armstrong
2019-04-01 10:00 ` Steven Price
2019-04-01 11:24 ` Neil Armstrong
2019-04-07 10:16 ` Neil Armstrong
2019-04-08 19:07 ` Rob Herring
2019-04-09 8:20 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86843e8b-1dda-f7f3-c2ad-02b7b47743dc@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).