From: Loys Ollivier <lollivier@baylibre.com>
To: Johan Hovold <johan@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Loys Ollivier <lollivier@baylibre.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/4] dt-bindings: gnss: add mediatek binding
Date: Mon, 18 Feb 2019 15:08:38 +0100 [thread overview]
Message-ID: <86k1hxur2x.fsf@baylibre.com> (raw)
In-Reply-To: <20190215160457.GO28278@localhost>
On Fri 15 Feb 2019 at 16:04, Johan Hovold <johan@kernel.org> wrote:
> On Wed, Feb 13, 2019 at 04:09:27PM +0100, Loys Ollivier wrote:
>> Add binding for Mediatek-based GNSS receivers.
>>
>> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
>> ---
>> v4:
>> Use standard names for reset-gpios and gnss-fix-gpios
>> s/an/a UART
>>
>> v3:
>> Removed the I2C and SPI interfaces references.
>> Removed the "mediatek,mt3339" compatible line.
>> Added the optional propertied (reset, fix)
>> Added the pin names for the optional properties.
>>
>> v2:
>> Renamed bindings from Globaltop/gtop to Mediatek/mtk.
>> Moved current-speed as an optional propertie.
>> Removed the status line in the example.
>> Added "mediatek,mt3339" compatible.
>>
>> .../devicetree/bindings/gnss/mediatek.txt | 37 ++++++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gnss/mediatek.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gnss/mediatek.txt b/Documentation/devicetree/bindings/gnss/mediatek.txt
>> new file mode 100644
>> index 000000000000..12283d429baa
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gnss/mediatek.txt
>> @@ -0,0 +1,37 @@
>> +Mediatek-based GNSS Receiver DT binding
>> +
>> +Mediatek chipsets are used in GNSS-receiver modules produced by several
>> +vendors and can use a UART interface.
>> +
>> +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic
>> +properties.
>> +
>> +Required properties:
>> +
>> +- compatible : Must be
>> +
>> + "globaltop,pa6h"
>> +
>> +- vcc-supply : Main voltage regulator (pin name: VCC)
>> +
>> +Optional properties:
>> +
>> +- current-speed : Default UART baud rate
>> +- gnss-fix-gpios : GPIO used to determine device position fix state
>> + (pin name: FIX, 3D_FIX)
>> +- reset-gpios : GPIO used to reset the device
>> + (pin name: RESET, NRESET)
>> +- timepulse-gpios : Time pulse GPIO (pin name: PPS1, 1PPS)
>> +- v-bckp-supply : Backup voltage regulator
>> + (pin name: VBAT, VBACKUP)
>
> As we discussed, I changed this to "vbackup-supply" (here and in the
> driver) before applying.
>
> Note that git reported some whitespace errors above too (spaces before
> tabs) that I fixed up. Not sure why checkpatch doesn't complain.
>
Oops, thanks for fixing it. I ran checkpatch again and it did not
complain. Apprently it's not checking for spaces before tabs in "txt"
files.
I'll add a step in my flow to apply the patches I create before sending
them to the list so that won't happen again ;)
> All now applied.
>
Yay ! Thanks !
Loys
> Thanks,
> Johan
--
-L
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-02-18 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 15:09 [PATCH v4 0/4] Add driver for Mediatek-based GNSS receivers Loys Ollivier
2019-02-13 15:09 ` [PATCH v4 1/4] dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." Loys Ollivier
2019-02-13 15:09 ` [PATCH v4 2/4] dt-bindings: gnss: add mediatek binding Loys Ollivier
2019-02-13 20:19 ` Rob Herring
2019-02-15 16:04 ` Johan Hovold
2019-02-18 14:08 ` Loys Ollivier [this message]
2019-02-13 15:09 ` [PATCH v4 3/4] gnss: add mtk receiver type support Loys Ollivier
2019-02-13 15:09 ` [PATCH v4 4/4] gnss: add driver for mediatek receivers Loys Ollivier
2019-02-14 10:00 ` Corentin Labbe
2019-02-14 10:12 ` Johan Hovold
2019-02-15 12:25 ` Loys Ollivier
2019-03-11 11:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k1hxur2x.fsf@baylibre.com \
--to=lollivier@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).