From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C321FC282DA for ; Sat, 2 Feb 2019 03:00:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93AAA20855 for ; Sat, 2 Feb 2019 03:00:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PQ2fKGbA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93AAA20855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DP3C7T+RRklO8zq255e1KxiRKeU/cuPs4gESDH3BMc0=; b=PQ2fKGbAQbkdQcRkMrE3qR/bk ZWzO1EJnKEd2pI2qBUYTUnhQXjligVfuQJhP0sfffcSSY1qIBbi8frkQKXghw6bRWekKVy3ih/ou/ pCKJabWEyxXyasAuqvLArlsfuPSkrcXSf4nNSee09giBm5YJZx+YlcK+30sugCLGMgyjxyxU84yuc Ss7ROK3nk+y0NUyOo/Io1zisz5iIyK+Cv4k0QvB3PItBZbMOa0AyZ5lHozQN5RA17XU/h3HqB7CS7 iYCleZ45rl1Q7fWAn+RJfxKrdTE2ULQCr4Q2BdjdVYUYtFoGtX8LwyTe97OVXvq+oNHZJZ8fUZ/L0 Ms6uSkJ9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gplXg-0005cw-0h; Sat, 02 Feb 2019 03:00:28 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gplXd-0005cX-MP; Sat, 02 Feb 2019 03:00:27 +0000 Received: from [10.28.18.236] (10.28.18.236) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Sat, 2 Feb 2019 11:01:10 +0800 Subject: Re: [PATCH 1/3] mtd: rawnand: meson: Fix a limit test in meson_nfc_select_chip() To: Dan Carpenter References: <20190201082922.GC8459@kadam> From: Liang Yang Message-ID: <8e85966c-bb40-6063-18c9-451735ad1ab3@amlogic.com> Date: Sat, 2 Feb 2019 11:01:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190201082922.GC8459@kadam> Content-Language: en-US X-Originating-IP: [10.28.18.236] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190201_190025_730600_30B50444 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , kernel-janitors@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Kevin Hilman , Miquel Raynal , linux-amlogic@lists.infradead.org, Brian Norris , David Woodhouse Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Dan, On 2019/2/1 16:29, Dan Carpenter wrote: > This test is off by one because the > should be >= and it's also testing > against the wrong limit. The MAX_CE_NUM is the maximum size that > meson_chip->sels[] is allowed to be but meson_chip->nsels is the actual > size. > > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller ") > Signed-off-by: Dan Carpenter > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index e858d58d97b0..94c90be7e1e0 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -225,7 +225,7 @@ static void meson_nfc_select_chip(struct nand_chip *nand, int chip) > struct meson_nfc *nfc = nand_get_controller_data(nand); > int ret, value; > > - if (chip < 0 || WARN_ON_ONCE(chip > MAX_CE_NUM)) > + if (chip < 0 || WARN_ON_ONCE(chip >= meson_chip->nsels)) > return; > Thank you. Acked-by: Liang Yang > nfc->param.chip_select = meson_chip->sels[chip] ? NAND_CE1 : NAND_CE0; > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic