From: Neil Armstrong <narmstrong@baylibre.com>
To: robh+dt@kernel.org
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [RFC 5/9] dt-bindings: arm: amlogic: amlogic, meson-gx-ao-secure: convert to yaml
Date: Fri, 2 Aug 2019 16:37:25 +0200 [thread overview]
Message-ID: <90dbcb33-74a2-68de-eb1a-ce84040298b8@baylibre.com> (raw)
In-Reply-To: <20190801135644.12843-6-narmstrong@baylibre.com>
Hi Rob,
Thanks for reviews.
On 01/08/2019 15:56, Neil Armstrong wrote:
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../amlogic/amlogic,meson-gx-ao-secure.txt | 28 -------------
> .../amlogic/amlogic,meson-gx-ao-secure.yaml | 42 +++++++++++++++++++
> 2 files changed, 42 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt
> create mode 100644 Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt
> deleted file mode 100644
> index c67d9f48fb91..000000000000
> --- a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Amlogic Meson Firmware registers Interface
> -------------------------------------------
> -
> -The Meson SoCs have a register bank with status and data shared with the
> -secure firmware.
> -
> -Required properties:
> - - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-ao-secure", "syscon"
I have a hard time find how to define "syscon" here, if I put syscon in the compatible
it gets matched on other bindings and I get lot of warnings.
How should I model it ?
Thanks,
Neil
> -
> -Properties should indentify components of this register interface :
> -
> -Meson GX SoC Information
> -------------------------
> -A firmware register encodes the SoC type, package and revision information on
> -the Meson GX SoCs.
> -If present, the following property should be added :
> -
> -Optional properties:
> - - amlogic,has-chip-id: If present, the interface gives the current SoC version.
> -
> -Example
> --------
> -
> -ao-secure@140 {
> - compatible = "amlogic,meson-gx-ao-secure", "syscon";
> - reg = <0x0 0x140 0x0 0x140>;
> - amlogic,has-chip-id;
> -};
> diff --git a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
> new file mode 100644
> index 000000000000..cf79287498f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2019 BayLibre, SAS
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/arm/amlogic/amlogic,meson-gx-ao-secure.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Amlogic Meson Firmware registers Interface
> +
> +maintainers:
> + - Neil Armstrong <narmstrong@baylibre.com>
> +
> +description: |
> + The Meson SoCs have a register bank with status and data shared with the
> + secure firmware.
> +
> +properties:
> + compatible:
> + enum:
> + - amlogic,meson-gx-ao-secure
> +
> + reg:
> + maxItems: 1
> +
> + amlogic,has-chip-id:
> + description: |
> + A firmware register encodes the SoC type, package and revision
> + information on the Meson GX SoCs. If present, the interface gives
> + the current SoC version.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + ao-secure@140 {
> + compatible = "amlogic,meson-gx-ao-secure", "syscon";
> + reg = <0x140 0x140>;
> + amlogic,has-chip-id;
> + };
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-08-02 14:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 13:56 [RFC 0/9] dt-bindings: first tentative of conversion to yaml format Neil Armstrong
2019-08-01 13:56 ` [RFC 1/9] dt-bindings: mailbox: meson-mhu: convert to yaml Neil Armstrong
2019-08-01 13:56 ` [RFC 2/9] dt-bindings: rng: amlogic,meson-rng: " Neil Armstrong
2019-08-01 13:56 ` [RFC 3/9] dt-bindings: spi: meson: " Neil Armstrong
2019-08-01 14:42 ` Rob Herring
2019-08-01 13:56 ` [RFC 4/9] dt-bindings: reset: amlogic,meson-reset: " Neil Armstrong
2019-08-01 13:56 ` [RFC 5/9] dt-bindings: arm: amlogic: amlogic, meson-gx-ao-secure: " Neil Armstrong
2019-08-02 14:37 ` Neil Armstrong [this message]
2019-08-02 15:32 ` Rob Herring
2019-08-01 13:56 ` [RFC 6/9] dt-bindings: phy: meson-g12a-usb2-phy: " Neil Armstrong
2019-08-01 15:07 ` Rob Herring
2019-08-01 13:56 ` [RFC 7/9] dt-bindings: phy: meson-g12a-usb3-pcie-phy: " Neil Armstrong
2019-08-01 15:08 ` Rob Herring
2019-08-01 13:56 ` [RFC 8/9] dt-bindings: serial: meson-uart: " Neil Armstrong
2019-08-01 14:08 ` Greg KH
2019-08-01 15:15 ` Rob Herring
2019-08-01 13:56 ` [RFC 9/9] dt-bindings: watchdog: meson-gxbb-wdt: " Neil Armstrong
2019-08-01 15:20 ` [RFC 0/9] dt-bindings: first tentative of conversion to yaml format Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90dbcb33-74a2-68de-eb1a-ce84040298b8@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).