From: <Claudiu.Beznea@microchip.com>
To: <linus.walleij@linaro.org>
Cc: tmaimon77@gmail.com, nsekhar@ti.com, guoren@kernel.org,
linux-stm32@st-md-mailman.stormreply.com, heiko@sntech.de,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, khilman@baylibre.com,
Ludovic.Desroches@microchip.com, linux-imx@nxp.com,
u.kleine-koenig@pengutronix.de,
uclinux-h8-devel@lists.sourceforge.jp, marc.zyngier@arm.com,
s.hauer@pengutronix.de, linux-unisoc@lists.infradead.org,
khalasa@piap.pl, tglx@linutronix.de, sbranden@broadcom.com,
linux-kernel@vger.kernel.org, ralf@linux-mips.org,
paul.burton@mips.com, kernel@pengutronix.de,
mark.rutland@arm.com, alexandre.belloni@bootlin.com,
jhogan@kernel.org, palmer@sifive.com, eric@anholt.net,
thierry.reding@gmail.com, manivannan.sadhasivam@linaro.org,
ysato@users.sourceforge.jp, zhang.lyra@gmail.com,
daniel.lezcano@linaro.org, jonathanh@nvidia.com,
bgolaszewski@baylibre.com, kgene@kernel.org,
alexandre.torgue@st.com, linux-arm-msm@vger.kernel.org,
sudeep.holla@arm.com, f.fainelli@gmail.com,
john.stultz@linaro.org, linux-rpi-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, baohua@kernel.org,
kaloz@openwrt.org, sboyd@kernel.org, patrice.chotard@st.com,
wahrenst@gmx.net, mcoquelin.stm32@gmail.com,
narmstrong@baylibre.com, linux-tegra@vger.kernel.org,
festevam@gmail.com, lorenzo.pieralisi@arm.com,
benjaminfair@google.com, shc_work@mail.ru, krzk@kernel.org,
yuenn@google.com, wens@csie.org,
bcm-kernel-feedback-list@broadcom.com, orsonzhai@gmail.com,
linux-snps-arc@lists.infradead.org, rjui@broadcom.com,
vz@mleia.com, john@phrozen.org, tali.perry1@gmail.com,
avifishman70@gmail.com, venture@google.com, lftan@altera.com,
linux-oxnas@groups.io, shawnguo@kernel.org, afaerber@suse.de,
baruch@tkos.co.il, maxime.ripard@bootlin.com,
liviu.dudau@arm.com, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, openbmc@lists.ozlabs.org,
linux@armlinux.org.uk, agross@kernel.org,
slemieux.tyco@gmail.com, devicetree@vger.kernel.org,
aou@eecs.berkeley.edu, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org, ssantosh@kernel.org,
matthias.bgg@gmail.com, monstr@monstr.eu, baolin.wang@linaro.org,
vgupta@synopsys.com, Nicolas.Ferre@microchip.com,
linux@prisktech.co.nz, nios2-dev@lists.rocketboards.org
Subject: Re: [PATCH 7/7] clocksource/drivers/integrator-ap: parse the chosen node
Date: Wed, 11 Sep 2019 07:14:11 +0000 [thread overview]
Message-ID: <9c46343e-504e-fbd9-45aa-a67416109e36@microchip.com> (raw)
In-Reply-To: <CACRpkdYsCFUNAtarTQmaA2a3-HZjiVjxQ-Wr-7wJp9xrtQRKCg@mail.gmail.com>
On 11.09.2019 02:48, Linus Walleij wrote:
> External E-Mail
>
>
> On Tue, Sep 10, 2019 at 2:50 PM Claudiu Beznea
> <claudiu.beznea@microchip.com> wrote:
>> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>>
>> The driver currently uses aliases to know whether the timer is the
>> clocksource or the clockevent.
>
> OK maybe that wasn't the most elegant solution.
>
>> Add the /chosen/linux,clocksource and
>> /chosen/linux,clockevent parsing while keeping backward compatibility.
>
> This is not how I would solve this today.
>
> I would simply remove/comment out the IRQ from the timer
> that cannot be used for clockevent from the device tree
> (apparently it doesn't work anyway), and make the code only
> pick a timer with a valid interrupt assigned as clock event,
> while a timer without interrupt can be used for clock source.
This could also be used but it will not be compatible with old device
trees. There are different ideas implemented in timer drivers with regards
to this issue. Some of them are registering 1st timer to work as
clocksource/clockevent and the 2nd one to work as clockevent/clocksource.
Some are using different compatibles, one for clocksource, one for
clockevent although these compatible seems to be for the same hardware type
(I can point drivers/clocksource/timer-sprd.c).
The idea with this series was, at it has been proposed in [1] to have one
single mechanism for this kind of situations.
Thank you,
Claudiu Beznea
[1]
https://lore.kernel.org/lkml/2f831f1b-c87d-48bd-cf02-2ebb334b964c@linaro.org/
>
> This has the upside of not needing any special aliases or
> chosen things.
>
> Yours,
> Linus Walleij
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-09-11 7:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 13:47 [PATCH 0/7] add support for clocksource/clockevent DT selection Claudiu Beznea
2019-09-10 13:47 ` [PATCH 1/7] clocksource/drivers/c-sky: request timer_of_init only for probing CPU Claudiu Beznea
2019-09-10 13:47 ` [PATCH 2/7] clocksource: change timer registration macros Claudiu Beznea
2019-09-10 14:49 ` Marc Zyngier
2019-09-10 14:57 ` Claudiu.Beznea
2019-09-10 13:47 ` [PATCH 3/7] clocksource/timer_of: use BIT() macro Claudiu Beznea
2019-09-10 13:47 ` [PATCH 4/7] dt-bindings: chosen: Add clocksource and clockevent selection Claudiu Beznea
2019-09-10 14:32 ` Sudeep Holla
2019-09-10 14:51 ` Claudiu.Beznea
2019-09-10 15:08 ` Sudeep Holla
2019-09-10 15:10 ` Alexandre Belloni
2019-09-11 0:03 ` Linus Walleij
2019-09-11 7:18 ` Claudiu.Beznea
2019-09-12 14:18 ` Linus Walleij
2019-09-30 14:32 ` Rob Herring
2019-10-02 13:32 ` Claudiu.Beznea
2019-09-11 7:34 ` Neil Armstrong
2019-09-11 9:14 ` Alexandre Belloni
2019-09-10 13:47 ` [PATCH 5/7] clocksource/drivers/timer-of: add support support for timer's functionalities Claudiu Beznea
2019-09-10 13:47 ` [PATCH 6/7] drivers/clocksource/timer-of: keep declaration on one line Claudiu Beznea
2019-09-10 13:47 ` [PATCH 7/7] clocksource/drivers/integrator-ap: parse the chosen node Claudiu Beznea
2019-09-10 23:48 ` Linus Walleij
2019-09-11 7:14 ` Claudiu.Beznea [this message]
2019-09-10 16:05 ` [PATCH 0/7] add support for clocksource/clockevent DT selection John Stultz
2019-09-11 6:52 ` Claudiu.Beznea
2019-09-11 16:06 ` John Stultz
2019-09-25 17:19 ` Daniel Lezcano
2019-09-26 8:42 ` Claudiu.Beznea
2019-10-02 13:35 ` Claudiu.Beznea
2019-10-03 10:43 ` Claudiu.Beznea
2019-10-13 18:16 ` Daniel Lezcano
2019-10-15 9:23 ` Claudiu.Beznea
2019-10-18 20:24 ` Daniel Lezcano
2019-10-21 8:58 ` Claudiu.Beznea
2019-10-21 14:17 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c46343e-504e-fbd9-45aa-a67416109e36@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=afaerber@suse.de \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=aou@eecs.berkeley.edu \
--cc=avifishman70@gmail.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjaminfair@google.com \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=jhogan@kernel.org \
--cc=john.stultz@linaro.org \
--cc=john@phrozen.org \
--cc=jonathanh@nvidia.com \
--cc=kaloz@openwrt.org \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=khalasa@piap.pl \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=lftan@altera.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-oxnas@groups.io \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-unisoc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@prisktech.co.nz \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=monstr@monstr.eu \
--cc=narmstrong@baylibre.com \
--cc=nios2-dev@lists.rocketboards.org \
--cc=nsekhar@ti.com \
--cc=openbmc@lists.ozlabs.org \
--cc=orsonzhai@gmail.com \
--cc=palmer@sifive.com \
--cc=patrice.chotard@st.com \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
--cc=slemieux.tyco@gmail.com \
--cc=ssantosh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tali.perry1@gmail.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=venture@google.com \
--cc=vgupta@synopsys.com \
--cc=vz@mleia.com \
--cc=wahrenst@gmx.net \
--cc=wens@csie.org \
--cc=ysato@users.sourceforge.jp \
--cc=yuenn@google.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).