From: Neil Armstrong <narmstrong@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson: g12a: add audio devices resets
Date: Fri, 27 Sep 2019 11:08:54 +0200 [thread overview]
Message-ID: <9ff3a6f8-13c2-856f-f37b-dd96cb45faad@baylibre.com> (raw)
In-Reply-To: <20190925093358.15476-1-jbrunet@baylibre.com>
On 25/09/2019 11:33, Jerome Brunet wrote:
> Provide the reset lines coming from the audio clock controller to
> the audio devices of the g12 family
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12.dtsi | 28 +++++++++++++++++-----
> 1 file changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12.dtsi
> index 0d9df29994f3..3cf74fc96434 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12.dtsi
> @@ -103,7 +103,9 @@
> sound-name-prefix = "TODDR_A";
> interrupts = <GIC_SPI 148 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_A>;
> - resets = <&arb AXG_ARB_TODDR_A>;
> + resets = <&arb AXG_ARB_TODDR_A>,
> + <&clkc_audio AUD_RESET_TODDR_A>;
> + reset-names = "arb", "rst";
> status = "disabled";
> };
>
> @@ -115,7 +117,9 @@
> sound-name-prefix = "TODDR_B";
> interrupts = <GIC_SPI 149 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_B>;
> - resets = <&arb AXG_ARB_TODDR_B>;
> + resets = <&arb AXG_ARB_TODDR_B>,
> + <&clkc_audio AUD_RESET_TODDR_B>;
> + reset-names = "arb", "rst";
> status = "disabled";
> };
>
> @@ -127,7 +131,9 @@
> sound-name-prefix = "TODDR_C";
> interrupts = <GIC_SPI 150 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_C>;
> - resets = <&arb AXG_ARB_TODDR_C>;
> + resets = <&arb AXG_ARB_TODDR_C>,
> + <&clkc_audio AUD_RESET_TODDR_C>;
> + reset-names = "arb", "rst";
> status = "disabled";
> };
>
> @@ -139,7 +145,9 @@
> sound-name-prefix = "FRDDR_A";
> interrupts = <GIC_SPI 152 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_A>;
> - resets = <&arb AXG_ARB_FRDDR_A>;
> + resets = <&arb AXG_ARB_FRDDR_A>,
> + <&clkc_audio AUD_RESET_FRDDR_A>;
> + reset-names = "arb", "rst";
> status = "disabled";
> };
>
> @@ -151,7 +159,9 @@
> sound-name-prefix = "FRDDR_B";
> interrupts = <GIC_SPI 153 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_B>;
> - resets = <&arb AXG_ARB_FRDDR_B>;
> + resets = <&arb AXG_ARB_FRDDR_B>,
> + <&clkc_audio AUD_RESET_FRDDR_B>;
> + reset-names = "arb", "rst";
> status = "disabled";
> };
>
> @@ -163,7 +173,9 @@
> sound-name-prefix = "FRDDR_C";
> interrupts = <GIC_SPI 154 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_C>;
> - resets = <&arb AXG_ARB_FRDDR_C>;
> + resets = <&arb AXG_ARB_FRDDR_C>,
> + <&clkc_audio AUD_RESET_FRDDR_C>;
> + reset-names = "arb", "rst";
> status = "disabled";
> };
>
> @@ -249,6 +261,7 @@
> clocks = <&clkc_audio AUD_CLKID_SPDIFIN>,
> <&clkc_audio AUD_CLKID_SPDIFIN_CLK>;
> clock-names = "pclk", "refclk";
> + resets = <&clkc_audio AUD_RESET_SPDIFIN>;
> status = "disabled";
> };
>
> @@ -261,6 +274,7 @@
> clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>,
> <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>;
> clock-names = "pclk", "mclk";
> + resets = <&clkc_audio AUD_RESET_SPDIFOUT>;
> status = "disabled";
> };
>
> @@ -318,6 +332,7 @@
> clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>,
> <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>;
> clock-names = "pclk", "mclk";
> + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>;
> status = "disabled";
> };
>
> @@ -326,6 +341,7 @@
> reg = <0x0 0x744 0x0 0x4>;
> #sound-dai-cells = <1>;
> sound-name-prefix = "TOHDMITX";
> + resets = <&clkc_audio AUD_RESET_TOHDMITX>;
> status = "disabled";
> };
> };
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-09-27 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 9:33 [PATCH] arm64: dts: meson: g12a: add audio devices resets Jerome Brunet
2019-09-27 9:08 ` Neil Armstrong [this message]
2019-10-03 17:46 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ff3a6f8-13c2-856f-f37b-dd96cb45faad@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).