From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B5C1C33C99 for ; Tue, 7 Jan 2020 10:22:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CB33207E0 for ; Tue, 7 Jan 2020 10:22:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WwJB25M9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VtGCkan5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CB33207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bMtZwLghpq9ClkIzhWkR89kktmI91VyegO3bvRkM9xI=; b=WwJB25M9TH6s02 /Kqc68T1H/QeCDvDMxDkkfyWRDq7y71YBiZNCL/rJWB6W9sUWNkcixLtvKzgnavXz9jn2sYNDRl18 JkE3O2gkPM0eaZOKZD8FlTKgfJwCrErFxSScWpFrvdWxlJQCPb8XfzgQH2KJHu1QjRYzFpVlFAWCg rM94USfiPj5et69lVzyI4p1lrXUZi8gQApfyfTTKcaPQxIVQOEYCAkTgwJ7Ppx1aNF9h8+Hn3p+Dl 0Gqz0IGrMVQKSiJWJ/106q1IavR8oVJgYpSK2emucmW61JQm9exHKei2FeyZQUUdzbQQAlNBJ4CwV gFxvszkJ4rYHkgajs9+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iom05-0006iA-AE; Tue, 07 Jan 2020 10:22:13 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iolzt-0006XM-RS for linux-amlogic@lists.infradead.org; Tue, 07 Jan 2020 10:22:03 +0000 Received: by mail-lj1-x242.google.com with SMTP id w1so32167725ljh.5 for ; Tue, 07 Jan 2020 02:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=feoOXtnj/48eID5q4+nHQx+NhKQCedVmAZE1CGkwypE=; b=VtGCkan5np3byUChW4aFxnm5yaN4zsovrbrrNL2pV3TXPJ8ug9aSzneEr0kuM1Tj0P edzvWeTniw0GUWQofo54Pp1v4q8dV8I68CAwW2CuiGggie2uyBCFnBJNFXABB/wFknWN aHv6ds9bHX7S8mm+0nC+ZNjKMsuF0rQ+cVM+sSOHXBaIob0AVlMAA6GpBALgkvTJfIbP jJ285SLdjWpvbeYjQ4VK8HZgyKPdySbY5rr5DSjF4q8dsImHeDow2p8j7M6s6Hs0VnAe tmf4/r7N14nCP0rjiRyD6k3uq9pQJBEracEo9Mz1Q/jiJXL0gQbJtosbb02O2M+Zk3rP K2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=feoOXtnj/48eID5q4+nHQx+NhKQCedVmAZE1CGkwypE=; b=m4NO1vhvbYe/8q5prPpnV8xLt1El89q+vGY8Stey4CxOa6UkcaTx+VudaA2ZCptne/ diSPvfuuXpsRMb8wX6CG4CTVP43KUN8tbtb1nZAKAE06AxE7o37SkMDQsskj42tsnh0n vi6EKhuzP0ZYI00Au1KO9zAhzaOV9Lcu9iobHaJ8d2trPel9zT9COCDeN/HDM498LxzP 8AAcuQA2XNK5JgJZuh6+Dzk5s1sLULqC7oi40rSCqii3QPuR4pjmlMBCpx5YcZ0MTlj0 kmF1aPHUUD3K9lRvTDI6ymCwreU7Aci1Wt+v5EK+giPF1243p7EOpOSu2DTCxBK0koVi btZQ== X-Gm-Message-State: APjAAAX5UU9Mow603hw611ZCu8VbDXj0+4kvmI3GIZQZhONld2mPydCt 9qe5CjKe79ushfgc7UeUgJXJvpV0zqs3ZwCCGe3n1g== X-Google-Smtp-Source: APXvYqxXuZipIZnMlieWvK5RQa1ocYuWDkqnEH6fOTVKgMsnd3pBbW5G5g/YQfew1w9JZF43RyZBTUs4rRB/hKpVxec= X-Received: by 2002:a05:651c:1049:: with SMTP id x9mr61861878ljm.233.1578392519784; Tue, 07 Jan 2020 02:21:59 -0800 (PST) MIME-Version: 1.0 References: <20191226023734.9631-1-qianggui.song@amlogic.com> In-Reply-To: <20191226023734.9631-1-qianggui.song@amlogic.com> From: Linus Walleij Date: Tue, 7 Jan 2020 11:21:48 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: meson: Fix wrong shift value when get drive-strength To: Qianggui Song X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200107_022201_886040_7777B37D X-CRM114-Status: UNSURE ( 6.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jianxin Pan , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Guillaume La Roque , Linux ARM , "open list:ARM/Amlogic Meson..." , Xingyu Chen , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, Dec 26, 2019 at 3:37 AM Qianggui Song wrote: > In meson_pinconf_get_drive_strength, variable bit is calculated by > meson_calc_reg_and_bit, this value is the offset from the first pin of a > certain bank to current pin, while Meson SoCs use two bits for each pin > to depict drive-strength. So a left shift by 1 should be done or node > pinconf-pins shows wrong message. > > Fixes: 6ea3e3bbef37 ("pinctrl: meson: add support of drive-strength-microamp") > > Signed-off-by: Qianggui Song Patch applied. Yours, Linus Walleij _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic