From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Mohammad Rasim <mohammad.rasim96@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro
Date: Tue, 3 Dec 2019 21:58:15 +0100 [thread overview]
Message-ID: <CAFBinCA+yCKwj4qc_b-EOhkVDpvnOn-tDUE3TcGtC1r5_jOxGg@mail.gmail.com> (raw)
In-Reply-To: <20191202080203.js5fciajlf7qkgvw@manjaro.localdomain>
On Mon, Dec 2, 2019 at 9:02 AM Mohammad Rasim
<mohammad.rasim96@gmail.com> wrote:
>
> On 19/12/01 11:21PM, Martin Blumenstingl wrote:
> > [...]
> > > + leds {
> > > + compatible = "gpio-leds";
> > > + status {
> > > + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
> > > + default-state = "off";
> > > + color = <LED_COLOR_ID_RED>;
> > > + function = LED_FUNCTION_STATUS;
> > why is LED_FUNCTION_STATUS not enclosed in <> like color above?
> >
> Well, the examples in the documentation enclose the color and don't
> enclose function
> https://github.com/torvalds/linux/blob/596cf45cbf6e4fa7bcb0df33e373a7d062b644b5/Documentation/devicetree/bindings/leds/common.txt#L140
sorry for the noise, only now I realize that the LED_FUNCTION_*s are
string definitions and not numeric values
in this case all is fine
I learnt something new today ;)
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-03 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 19:53 [PATCH v4 0/3] add support for videostrong KII Pro Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Videostrong Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings Mohammad Rasim
2019-12-01 22:20 ` Martin Blumenstingl
2019-11-30 19:53 ` [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
2019-12-01 22:21 ` Martin Blumenstingl
2019-12-02 8:02 ` Mohammad Rasim
2019-12-03 20:58 ` Martin Blumenstingl [this message]
2019-12-09 22:31 ` [PATCH v4 0/3] add support for videostrong " Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCA+yCKwj4qc_b-EOhkVDpvnOn-tDUE3TcGtC1r5_jOxGg@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mohammad.rasim96@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).