From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCB5C04AAC for ; Mon, 20 May 2019 17:37:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97ABE214AE for ; Mon, 20 May 2019 17:37:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I9wO2qzJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="u8zchJDs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97ABE214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q2QyPZ7yAOrx/bxZi1w6VGgXGNiky9+W75jmsEa+MeI=; b=I9wO2qzJEEoCcS vpIdBbQ+lSy+BSc0knWqr6oxKepNIXUHa8n3x3bFuH1mCj81uY+CuWBuRzn9xsQpvR6iX09c7cxl+ /C0/z6xumi/EPSJ8DmeGNTdWO4ZGlVljbZpcsSfIH3yNO0GCnJ+jb3YAupNgsw1s9ZHS68wBJv/DJ 0DP0ocv9h6juBjDXYaWvOPlmQv5MFRUvlpge97I6nZrv/CBL4u48kgAajAuQkWZjZPGjuctAYBBdZ V11dbrGsDrYYkefamtQ0bgl4SWkmSzPvPfvPrkHaI7w4LK1qhp++FWpc7TxwFr99wcEjlcTMXrqtB EnC6n2z+I6gEwjW+vSbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSmER-000893-AE; Mon, 20 May 2019 17:37:51 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSmEN-00085G-Iz for linux-amlogic@lists.infradead.org; Mon, 20 May 2019 17:37:49 +0000 Received: by mail-oi1-x243.google.com with SMTP id 203so10608169oid.13 for ; Mon, 20 May 2019 10:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Byof9QMyRlXAVRlao9zpR9wxkvesAP37VT+Jt615gkI=; b=u8zchJDskvrP7jFMiyYauwOOdtCHZzj1r5rVC2jUd9LSRQmQgxFenyHft5HTH3rb6n SEL3IbDUY+55egOzikEtDiXQh8VSv5oqAc8C3afREBl1l9hm74ezxh06oVgW9/zLxxyX u+mEJkxVGg2mSDUlxDKIy4FFCf1MMzbZ+XHQKOEEidFY4vLhlApfA6nmwgXbhDq67bA2 4VlLxGLhOHtix0qPAWOUUjlZw77Me5UptKeNYyG2oWIZsMjwoUrpMP9jZarnPRaQjHSV v1l5Bh7Xy0jh83KaWyYU1MYukc4WmB+wLYB71akSMNTYpNqbJy9xapAm5bEGIh0bn/m8 0+ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Byof9QMyRlXAVRlao9zpR9wxkvesAP37VT+Jt615gkI=; b=gdObZUhMGJOG7UP6QmK53Bshe7XCk4KlAH6Qt3pCKPPdEblyGIYtw1lHR5w2UCTn9b 07AFR9kaY8NI1hLfyTcHWa8NAaEYyS1QefY+kh+qzKOta307E6MKDMeyQxexzhz+AuXo OZ7CTSVctIQ5gxezh0SIB7hsbyW40gLsSubdq9HThK6ry4Fj03dAyh9jJJF/pahwUEpn IhPfTdGwneSqjtq/TsyjKZX5/I+u/+BRJrUAPQcz796Bo9Tjf+YqEzsVsPsNHEN7C8k0 7NofWHcZYbzB9NhUYk8sobr08StlmjRBDiR0RDCrnCLZUU3vVM32oBTHz4FdajclDyCC lYIg== X-Gm-Message-State: APjAAAVNco3sl9UmljemveGiGFYqyKuADHuJuSkgopU7CDB+uV62yTfK azn0HE7pxD8w/O3xhZpir5fV+9BhzwwvTd1fTjx+3kmikSc= X-Google-Smtp-Source: APXvYqw/zO6zSTi7ReX5SAMdwUjkDfPLA+p+nLQgWrhqenyVH+hGrdhdWvJSJQ3ReYvIxP+VsOEJm+jxqFCcXuLP1q8= X-Received: by 2002:aca:4341:: with SMTP id q62mr257982oia.140.1558373866454; Mon, 20 May 2019 10:37:46 -0700 (PDT) MIME-Version: 1.0 References: <20190520131401.11804-1-jbrunet@baylibre.com> <20190520131401.11804-4-jbrunet@baylibre.com> In-Reply-To: <20190520131401.11804-4-jbrunet@baylibre.com> From: Martin Blumenstingl Date: Mon, 20 May 2019 19:37:35 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] arm64: dts: meson: g12a: add mdio multiplexer To: Jerome Brunet X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_103747_710271_3984F536 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , f.fainelli@gmail.com, devicetree@vger.kernel.org, Kevin Hilman , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, hkallweit1@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Jerome, On Mon, May 20, 2019 at 3:14 PM Jerome Brunet wrote: > > Add the g12a mdio multiplexer which allows to connect to either > an external phy through the SoC pins or the internal 10/100 phy > > Signed-off-by: Jerome Brunet Acked-by: Martin Blumenstingl > --- > arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 32 +++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > index def02ebf6501..90da7cc81681 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > @@ -1698,6 +1698,38 @@ > assigned-clock-rates = <100000000>; > #phy-cells = <1>; > }; > + > + eth_phy: mdio-multiplexer@4c000 { > + compatible = "amlogic,g12a-mdio-mux"; > + reg = <0x0 0x4c000 0x0 0xa4>; > + clocks = <&clkc CLKID_ETH_PHY>, > + <&xtal>, > + <&clkc CLKID_MPLL_50M>; > + clock-names = "pclk", "clkin0", "clkin1"; > + mdio-parent-bus = <&mdio0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ext_mdio: mdio@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + int_mdio: mdio@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + internal_ephy: ethernet_phy@8 { > + compatible = "ethernet-phy-id0180.3301", > + "ethernet-phy-ieee802.3-c22"; Based on your comment on v1 of this patch [0] the Ethernet PHY ID is defined by this "mdio-multiplexer" (write arbitrary value to a register then that's the PHY ID which will show up on the bus) I'm fine with explicitly listing the ID which the PHY driver binds to because I don't know a better way. +Cc Andrew, Florian and Heiner because I think they should be aware of such cases (it seems like a special case to me). Martin [0] https://patchwork.kernel.org/patch/10939255/ _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic