Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>, jbrunet@baylibre.com
Cc: khilman@baylibre.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 08/14] arm64: dts: meson-gxl: fix internal phy compatible
Date: Tue, 20 Aug 2019 22:38:13 +0200
Message-ID: <CAFBinCAyhfk1wq0ejXazTWQ=eNqDROauB_Kbc80+ekPQ7oB9Ww@mail.gmail.com> (raw)
In-Reply-To: <20190814142918.11636-9-narmstrong@baylibre.com>

adding Jerome

On Wed, Aug 14, 2019 at 4:31 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> This fixes the following DT schemas check errors:
> meson-gxl-s805x-libretech-ac.dt.yaml: ethernet-phy@8: compatible: ['ethernet-phy-id0181.4400', 'ethernet-phy-ieee802.3-c22'] is not valid under any of the given schemas
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index ee1ecdbcc958..43eb158bee24 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -709,7 +709,7 @@
>                         #size-cells = <0>;
>
>                         internal_phy: ethernet-phy@8 {
> -                               compatible = "ethernet-phy-id0181.4400", "ethernet-phy-ieee802.3-c22";
> +                               compatible = "ethernet-phy-id0181.4400";
on G12A there was a specific reason (iirc it was because the PHY ID
can be any arbitrary value programmed into some register) why we added
it with a compatible string
Jerome, do we have the same situation on GXL/GXM as well?

if not I prefer to drop the compatible string because it's probably
from a time where the PHY dt-bindings stated "add the PHY ID
compatible string if you know it" while the actual suggestion was
"only add it if reading the ID doesn't work for some reason"


Martin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply index

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 14:29 [PATCH 00/14] arm64: dts: meson: fixes following YAML bindings schemas conversion Neil Armstrong
2019-08-14 14:29 ` [PATCH 01/14] arm64: dts: meson: fix ethernet mac reg format Neil Armstrong
2019-08-20 20:21   ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 02/14] arm64: dts: meson-gx: drop the vpu dmc memory cell Neil Armstrong
2019-08-20 20:28   ` Martin Blumenstingl
2019-08-21 14:04     ` Neil Armstrong
2019-08-14 14:29 ` [PATCH 03/14] arm64: dts: meson-gx: fix reset controller compatible Neil Armstrong
2019-08-20 20:21   ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 04/14] arm64: dts: meson-gx: fix spifc compatible Neil Armstrong
2019-08-20 20:29   ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 05/14] arm64: dts: meson-gx: fix watchdog compatible Neil Armstrong
2019-08-20 20:22   ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 06/14] arm64: dts: meson-gx: fix mhu compatible Neil Armstrong
2019-08-14 14:29 ` [PATCH 07/14] arm64: dts: meson-gx: fix periphs bus node name Neil Armstrong
2019-08-20 20:25   ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 08/14] arm64: dts: meson-gxl: fix internal phy compatible Neil Armstrong
2019-08-20 20:38   ` Martin Blumenstingl [this message]
2019-08-21 14:07     ` Neil Armstrong
2019-08-14 14:29 ` [PATCH 09/14] arm64: dts: meson-axg: fix MHU compatible Neil Armstrong
2019-08-14 14:29 ` [PATCH 10/14] arm64: dts: meson-g12a: fix reset controller compatible Neil Armstrong
2019-08-20 20:42   ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 11/14] arm64: dts: meson-g12a-x96-max: fix compatible Neil Armstrong
2019-08-20 20:32   ` Martin Blumenstingl
2019-08-21 14:08     ` Neil Armstrong
2019-08-21 21:14       ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 12/14] arm64: dts: meson-gxbb-nanopi-k2: add missing model Neil Armstrong
2019-08-20 20:25   ` Martin Blumenstingl
2019-08-21 14:08     ` Neil Armstrong
2019-08-14 14:29 ` [PATCH 13/14] arm64: dts: meson-gxbb-p201: fix snps, reset-delays-us format Neil Armstrong
2019-08-20 20:23   ` Martin Blumenstingl
2019-08-14 14:29 ` [PATCH 14/14] arm64: dts: meson: fix boards regulators states format Neil Armstrong
2019-08-20 20:35   ` Martin Blumenstingl

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFBinCAyhfk1wq0ejXazTWQ=eNqDROauB_Kbc80+ekPQ7oB9Ww@mail.gmail.com' \
    --to=martin.blumenstingl@googlemail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org linux-amlogic@archiver.kernel.org
	public-inbox-index linux-amlogic


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/ public-inbox