From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839D9C47254 for ; Sat, 2 May 2020 20:12:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4089F206F1 for ; Sat, 2 May 2020 20:12:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gYszG/Ao"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="TEVaPpy1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4089F206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sjYJ5KVO2fezqjNxgUnHkELz1tYVBje5uzWcJ0uPOM4=; b=gYszG/AoNLFuUb 2Xi369ammeJ3gSy/nqqmncbFGynupr3mXa6YZSCETd8MNRLH1YNm1CRj700B/tVKVqZQxILXLOtkm gN1XYvEX0NAB+RO04enU0VNOZCWrcA9BIDFZGHNULUhVWOmhBpEHopdvKk4ycOFZ6cdPx04EILXTL mN4mWqySOFEEr7Paf7YvKoK3ebWDvz15OwIqbFac36MCKdv3JUZ/1URe+0p8s2ff4p0sfznCwO37S hwBMvNWUpAy0Tj/RdLRI83btfV3JENoEt9HgCYRC5U1FsFsphpLXKNKhInWXA9l/VgJ41tyPpgPUW TaFawadhqaA2kxp+e6eA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUyVA-0005mj-Bt; Sat, 02 May 2020 20:12:44 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUyV7-0005mI-Fg; Sat, 02 May 2020 20:12:42 +0000 Received: by mail-ed1-x543.google.com with SMTP id k22so10085369eds.6; Sat, 02 May 2020 13:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/LOaseKaG6V+rtNH18IaezwNbYZkddvKgyfOMm5QWjI=; b=TEVaPpy1e7qttjqHb7EHvlJ0Ss4UlvzqXCkMyp2wsJLM8xz3r1B7OQ5fsX18h/A3oZ ss1Udz2SOx1vCLY3Kk1weN5gx1NnYxPBXNm/kicNSHd1CSy+E1SRrDz2keHAxd6kxIYN 0Bf3Wnu7dLQr+XYikSzg7E7Efewa7h42Fa46VZH8OnPiRhVDh4IywVyg39HS6WOSDXIc cYsnZmqfCyduA27QMlZUy/mfS82PCAcVd6TSzui7ADkTjzZED5I+iX3yQyhOXaDKZskw mx35fFNHFqjtBBMweGf/XvSOjVmQ9lkuzInD7dhJbacKIlBVS7J4IGcwN01c4B6D6PoW rjGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/LOaseKaG6V+rtNH18IaezwNbYZkddvKgyfOMm5QWjI=; b=uSbVnNwwmRUn7mUAZ5zOp9unkUoPalObxrty+jfaadhDSNX/0RYe43DmjLNdzffSkY 63rqtJ0sQtP9Z9F2ZdO5RHne2MFXTrJ1tsO6dZyFbWY5KlR9Z+95gqXlPs+IkPq5iPJr Fv3EpXyx4gBHWh1om8hK8ot4aXS5p2MLSDE7srQJC8b7mM1JzSkAGcjs3ONso85Qk6PX dnL3eJ/27Dzq7jwcTNeYINmIhxV/Zn+QurU7mchbt1tapIP23wZWX/7xB9fkIQNZMGmY dd6Qz9CtNMWVosYLThTgrQfft3tGVf6/zUu3rFPuuzpkPOjKBSgLefVQW9Z2eTl9GSfi DpbQ== X-Gm-Message-State: AGi0Pubk6iAqDkoarqUIm9tktIO6+5CEFYTt9iVOWutIAIg7xb4tjLJ6 Rm74UiD0k6qgD6iAne5kMhXPMEyBpdUe0rzaaNEh/enW X-Google-Smtp-Source: APiQypLoKRoFB4j0P4SGI0u4W4wuHNiG2SBz6fnVNr0YCZ0RdM/Wen8nUr0q9Je35JiOhoMGcTXTHKtOfibtJ9m9X0w= X-Received: by 2002:a50:f61c:: with SMTP id c28mr8272542edn.365.1588450358825; Sat, 02 May 2020 13:12:38 -0700 (PDT) MIME-Version: 1.0 References: <20200425203941.3188000-1-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Sat, 2 May 2020 22:12:28 +0200 Message-ID: Subject: Re: [PATCH] drm/meson: viu: fix setting the OSD burst length in VIU_OSD1_FIFO_CTRL_STAT To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200502_131241_546631_BCE65D66 X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jmasson@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Neil, On Tue, Apr 28, 2020 at 10:38 AM Neil Armstrong wrote: [...] > > @@ -444,9 +437,9 @@ void meson_viu_init(struct meson_drm *priv) > > VIU_OSD_FIFO_LIMITS(2); /* fifo_lim: 2*16=32 */ > > > > if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) > > - reg |= meson_viu_osd_burst_length_reg(32); > > + reg |= VIU_OSD_BURST_LENGTH_32; > > else > > - reg |= meson_viu_osd_burst_length_reg(64); > > + reg |= VIU_OSD_BURST_LENGTH_64; > > > > writel_relaxed(reg, priv->io_base + _REG(VIU_OSD1_FIFO_CTRL_STAT)); > > writel_relaxed(reg, priv->io_base + _REG(VIU_OSD2_FIFO_CTRL_STAT)); > > > > Thanks, > Will run some tests ! Does this fix/improve anything for you? On the 32-bit SoCs kmscube is not smooth (neither on the CVBS nor on the HDMI output) with a burst length of 24 (which was the old "accidentally used" value). Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic