linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
@ 2019-09-05 11:48 Otto Meier
  2019-09-07 14:57 ` Martin Blumenstingl
  0 siblings, 1 reply; 6+ messages in thread
From: Otto Meier @ 2019-09-05 11:48 UTC (permalink / raw)
  To: linux-amlogic

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

Hi i tried to use uart_C of the the odroid-c2.

I enabled it int the dts file. During boot it crashed when the
the sdcard slot is addressd.

After long search in the net i found this:

https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856


After changing the pin definitios accordingly erverything works.

Uart_c is functioning and sdcard ist working.

Patch attached

Bye Otto






[-- Attachment #2: uart_c_pins.diff --]
[-- Type: text/x-patch, Size: 1811 bytes --]

Hi i tried to use uart_C of the the odroid-c2.

I enabled it int the dts file. During boot it crashed when the
the sdcard slot is addressd.

After long search in the net i found this:

https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856


After changing the pin definitios accordingly erverything works.

Uart_c is functioning and sdcard ist working.



--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c        2019-08-26 18:24:45.450089334 +0200
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c        2019-09-05 13:07:38.518637214 +0200
@@ -192,8 +192,8 @@ static const unsigned int uart_rts_b_pin
 
 static const unsigned int uart_tx_c_pins[]     = { GPIOY_13 };
 static const unsigned int uart_rx_c_pins[]     = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[]    = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[]    = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[]    = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[]    = { GPIOY_12 };
 
 static const unsigned int i2c_sck_a_pins[]     = { GPIODV_25 };
 static const unsigned int i2c_sda_a_pins[]     = { GPIODV_24 };
@@ -439,10 +439,10 @@ static struct meson_pmx_group meson_gxbb
        GROUP(pwm_f_x,          3,      18),
 
        /* Bank Y */
-       GROUP(uart_cts_c,       1,      19),
-       GROUP(uart_rts_c,       1,      18),
-       GROUP(uart_tx_c,        1,      17),
-       GROUP(uart_rx_c,        1,      16),
+       GROUP(uart_cts_c,       1,      17),
+       GROUP(uart_rts_c,       1,      16),
+       GROUP(uart_tx_c,        1,      19),
+       GROUP(uart_rx_c,        1,      18),
        GROUP(pwm_a_y,          1,      21),
        GROUP(pwm_f_y,          1,      20),
        GROUP(i2s_out_ch23_y,   1,      5),

signed off Otto Meier gf435@gmx.net


[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
  2019-09-05 11:48 [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c Otto Meier
@ 2019-09-07 14:57 ` Martin Blumenstingl
  0 siblings, 0 replies; 6+ messages in thread
From: Martin Blumenstingl @ 2019-09-07 14:57 UTC (permalink / raw)
  To: Otto Meier; +Cc: linux-amlogic

Hi Otto,

On Thu, Sep 5, 2019 at 1:49 PM Otto Meier <gf435@gmx.net> wrote:
>
> Hi i tried to use uart_C of the the odroid-c2.
>
> I enabled it int the dts file. During boot it crashed when the
> the sdcard slot is addressd.
>
> After long search in the net i found this:
>
> https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
thank you for doing research on this...

>
> After changing the pin definitios accordingly erverything works.
>
> Uart_c is functioning and sdcard ist working.
>
> Patch attached
...as well as going the extra mile (writing a patch and submitting it)

your patch is looking good to me apart from some small formal issues:
- some typos in the commit message (int -> in, addressd -> addressed,
definitios -> definitions, ist -> is)
- please add the following line above your Signed-off-by line (to get
your fix also into -stable kernels): Fixes: 6db0f3a8a04e46 ("pinctrl:
amlogic: gxbb: add more UART pins")
- your "Signed-off-by" has to be in a specific format
- patches must be sent inline (not as attachment)
- the pinctrl maintainers are not Cc'ed (so they won't notice this patch)

here's a simplified version of the patch submission flow that I use:
- (change the code)
- git commit --signoff (give a good description why you are changing
things, include a Fixes line if appropriate)
- git format-patch HEAD~1
- run ./scripts/checkpatch.pl 0001-*.patch (fix all checkpatch errors,
"git commit --amend" the changes, then run git format-patch again)
- find the email recipients with: ./scripts/get_maintainer.pl 0001-*.patch
- run: git send-email 0001-*.patch --to=<maintainer or mailing list
email> --to=<another maintainer mailing list or email> --cc=<more
mailing lists...>

feel free to ask if you have any questions


I'm looking forward to an updated  patch!
Martin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
  2019-09-12  9:21 ` Linus Walleij
  2019-09-12 10:02   ` Neil Armstrong
@ 2019-09-14 17:25   ` Martin Blumenstingl
  1 sibling, 0 replies; 6+ messages in thread
From: Martin Blumenstingl @ 2019-09-14 17:25 UTC (permalink / raw)
  To: Linus Walleij
  Cc: open list:ARM/Amlogic Meson...,
	open list:GPIO SUBSYSTEM, Kevin Hilman, Otto Meier

Hi Linus,

On Thu, Sep 12, 2019 at 11:21 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Sep 10, 2019 at 5:01 PM Otto Meier <gf435@gmx.net> wrote:
>
> > Hi i tried to use the uart_C of the the odroid-c2.
> >
> > I enabled it in the dts file. During boot it crashed when the
> > the sdcard slot is addressed.
> >
> > After long search in the net i found this:
> >
> > https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
> >
> > After changing the pin definitions accordingly erverything works.
> > Uart_c is functioning and sdcard ist working.
> >
> >
> > Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
> > Signed-off-by: Otto Meiergf435@gmx.net
>
> Looks like a simple fix to me, Martin could you take a look?
this looks fine to me based on the description on the Odroid forums so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>


Martin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
  2019-09-12  9:21 ` Linus Walleij
@ 2019-09-12 10:02   ` Neil Armstrong
  2019-09-14 17:25   ` Martin Blumenstingl
  1 sibling, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-09-12 10:02 UTC (permalink / raw)
  To: Linus Walleij, Otto Meier
  Cc: Martin Blumenstingl, open list:ARM/Amlogic Meson...,
	open list:GPIO SUBSYSTEM, Kevin Hilman

Hi Linus,

On 12/09/2019 11:21, Linus Walleij wrote:
> On Tue, Sep 10, 2019 at 5:01 PM Otto Meier <gf435@gmx.net> wrote:
> 
>> Hi i tried to use the uart_C of the the odroid-c2.
>>
>> I enabled it in the dts file. During boot it crashed when the
>> the sdcard slot is addressed.
>>
>> After long search in the net i found this:
>>
>> https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
>>
>> After changing the pin definitions accordingly erverything works.
>> Uart_c is functioning and sdcard ist working.
>>
>>
>> Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
>> Signed-off-by: Otto Meiergf435@gmx.net
> 
> Looks like a simple fix to me, Martin could you take a look?

Martin asked Otto to resend with a proper formatting, but seem he forgot to
CC linux-amlogic this time.

If the original mail is https://www.spinics.net/lists/linux-gpio/msg42278.html
It's Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

It was already reported in June 2018, but without a valid name for sign-off.

Neil

> 
> Yours,
> Linus Walleij
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
  2019-09-10 16:01 Otto Meier
@ 2019-09-12  9:21 ` Linus Walleij
  2019-09-12 10:02   ` Neil Armstrong
  2019-09-14 17:25   ` Martin Blumenstingl
  0 siblings, 2 replies; 6+ messages in thread
From: Linus Walleij @ 2019-09-12  9:21 UTC (permalink / raw)
  To: Otto Meier
  Cc: Martin Blumenstingl, open list:ARM/Amlogic Meson...,
	Kevin Hilman, open list:GPIO SUBSYSTEM

On Tue, Sep 10, 2019 at 5:01 PM Otto Meier <gf435@gmx.net> wrote:

> Hi i tried to use the uart_C of the the odroid-c2.
>
> I enabled it in the dts file. During boot it crashed when the
> the sdcard slot is addressed.
>
> After long search in the net i found this:
>
> https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
>
> After changing the pin definitions accordingly erverything works.
> Uart_c is functioning and sdcard ist working.
>
>
> Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
> Signed-off-by: Otto Meiergf435@gmx.net

Looks like a simple fix to me, Martin could you take a look?

Yours,
Linus Walleij

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
@ 2019-09-10 16:01 Otto Meier
  2019-09-12  9:21 ` Linus Walleij
  0 siblings, 1 reply; 6+ messages in thread
From: Otto Meier @ 2019-09-10 16:01 UTC (permalink / raw)
  To: linux-amlogic; +Cc: martin.blumenstingl, linux-gpio, linus.walleij, khilman

Hi i tried to use the uart_C of the the odroid-c2.

I enabled it in the dts file. During boot it crashed when the
the sdcard slot is addressed.

After long search in the net i found this:

https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856

After changing the pin definitions accordingly erverything works.
Uart_c is functioning and sdcard ist working.


Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
Signed-off-by: Otto Meiergf435@gmx.net
---


--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2019-08-26 
18:24:45.450089334 +0200
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2019-09-05 
13:07:38.518637214 +0200
@@ -192,8 +192,8 @@  static const unsigned int uart_rts_b_pin
  
  static const unsigned int uart_tx_c_pins[]     = { GPIOY_13 };
  static const unsigned int uart_rx_c_pins[]     = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
  
  static const unsigned int i2c_sck_a_pins[]     = { GPIODV_25 };
  static const unsigned int i2c_sda_a_pins[]     = { GPIODV_24 };
@@ -439,10 +439,10 @@  static struct meson_pmx_group meson_gxbb
         GROUP(pwm_f_x,          3,      18),
  
         /* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
         GROUP(pwm_a_y,          1,      21),
         GROUP(pwm_f_y,          1,      20),
         GROUP(i2s_out_ch23_y,   1,      5),






_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-09-14 17:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 11:48 [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c Otto Meier
2019-09-07 14:57 ` Martin Blumenstingl
2019-09-10 16:01 Otto Meier
2019-09-12  9:21 ` Linus Walleij
2019-09-12 10:02   ` Neil Armstrong
2019-09-14 17:25   ` Martin Blumenstingl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).