* [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer
[not found] <20191008123341.1551-1-ben.dooks@codethink.co.uk>
@ 2019-10-08 12:33 ` Ben Dooks
2019-10-08 17:26 ` Martin Blumenstingl
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2019-10-08 12:33 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Kevin Hilman, Ben Dooks, linux-amlogic
Fix the second argument of of_get_cpu_node which is a pointer
being passed a plain 0 by using NULL instead. Fixes the following
warning:
arch/arm/mach-meson/platsmp.c:40:55: warning: Using plain integer as NULL pointer
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
CC: Kevin Hilman <khilman@baylibre.com>
CC: linux-amlogic@lists.infradead.org
---
arch/arm/mach-meson/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-meson/platsmp.c b/arch/arm/mach-meson/platsmp.c
index 4b8ad728bb42..f992c436d3ed 100644
--- a/arch/arm/mach-meson/platsmp.c
+++ b/arch/arm/mach-meson/platsmp.c
@@ -37,7 +37,7 @@ static struct regmap *pmu;
static struct reset_control *meson_smp_get_core_reset(int cpu)
{
- struct device_node *np = of_get_cpu_node(cpu, 0);
+ struct device_node *np = of_get_cpu_node(cpu, NULL);
return of_reset_control_get_exclusive(np, NULL);
}
--
2.23.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer
2019-10-08 12:33 ` [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer Ben Dooks
@ 2019-10-08 17:26 ` Martin Blumenstingl
0 siblings, 0 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2019-10-08 17:26 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-arm-kernel, linux-kernel, linux-amlogic, Kevin Hilman
Hi Ben,
thank you for this fix!
On Tue, Oct 8, 2019 at 2:33 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> Fix the second argument of of_get_cpu_node which is a pointer
> being passed a plain 0 by using NULL instead. Fixes the following
> warning:
>
> arch/arm/mach-meson/platsmp.c:40:55: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer
[not found] <20191008123453.1651-1-ben.dooks@codethink.co.uk>
@ 2019-10-08 12:34 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2019-10-08 12:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-kernel, Kevin Hilman, Ben Dooks, linux-amlogic
Fix the second argument of of_get_cpu_node which is a pointer
being passed a plain 0 by using NULL instead. Fixes the following
warning:
arch/arm/mach-meson/platsmp.c:40:55: warning: Using plain integer as NULL pointer
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
CC: Kevin Hilman <khilman@baylibre.com>
CC: linux-amlogic@lists.infradead.org
---
arch/arm/mach-meson/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-meson/platsmp.c b/arch/arm/mach-meson/platsmp.c
index 4b8ad728bb42..f992c436d3ed 100644
--- a/arch/arm/mach-meson/platsmp.c
+++ b/arch/arm/mach-meson/platsmp.c
@@ -37,7 +37,7 @@ static struct regmap *pmu;
static struct reset_control *meson_smp_get_core_reset(int cpu)
{
- struct device_node *np = of_get_cpu_node(cpu, 0);
+ struct device_node *np = of_get_cpu_node(cpu, NULL);
return of_reset_control_get_exclusive(np, NULL);
}
--
2.23.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-08 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191008123341.1551-1-ben.dooks@codethink.co.uk>
2019-10-08 12:33 ` [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer Ben Dooks
2019-10-08 17:26 ` Martin Blumenstingl
[not found] <20191008123453.1651-1-ben.dooks@codethink.co.uk>
2019-10-08 12:34 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).