From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D0CC169C4 for ; Wed, 6 Feb 2019 11:29:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 224D620823 for ; Wed, 6 Feb 2019 11:29:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EL2wrldn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="JKvmMgI+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 224D620823 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SD2o7h9x3gOEeYkxYQTiyadBQIugx8lNiqPc4YDsk3E=; b=EL2wrldnr/l6CF jArSfWDVQ2KjG1joIA80bHjlaBmaklcel6sepiZoRQV0wkX0Vz/EkriAuKWCP7WmUIMeDSCxj6DoD whymp77WA54vayDVotfGdXXv3T4dS4d5js4ButwUlF5RfQvo2zZ/0q77OyQ6JegkwgFTIMnoBllFR 5pnS09aFCAD4Clni1/j09qslEZiGezyW5RBowpGm66I91321/AhfIDwbvFM6mA27KciNgcGqmI0c+ 7Ve17BLhM3iRmrf4U7KzmIx/IAtu4yPHwM7o7PrsXXxjqQMi6giVLSjZYCsrVXbWbEAPtjdqxgpoB FuLzdy3+xmqFNA6+AdmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grLNx-0004i0-Ag; Wed, 06 Feb 2019 11:28:57 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1grLNl-0004XE-1x; Wed, 06 Feb 2019 11:28:46 +0000 Received: by mail-ot1-x344.google.com with SMTP id 32so11181022ota.12; Wed, 06 Feb 2019 03:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q6uxksyd4B7vRqtlr+5W33DQQzfWzcoKK5+Un05MXvs=; b=JKvmMgI+O1towSFvmv+w7YwuBdOXO83XUBp6QYktR92TUzh8aIowl6PndOc+O5C4j8 7X6ycgstGT/8U3ovsoEee9vcNkHpj7FIl1m1mydaP9USlGjBXSb3dX4B1fsS+wOYah1a fGOBlcxau8uFofrQhWjqovEAcKpR/9Rn3ACNmwIux9Ntnqt0VjoJ0p6gENEyO5GB65d/ rO55pqUdPubYOr3+XH6EhOGgV5IakJ5JGI1xfQpddy7ldNEEP6IK2jmtwygN85rNBr46 +P0aX0oWOe+3Tawz2xGAiJUpZahJ763qLccUXcWMmVJNj6hwI0XOOkpq/BJb4t/MGzbj hgMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q6uxksyd4B7vRqtlr+5W33DQQzfWzcoKK5+Un05MXvs=; b=EhhKxY5kFsJaMUoRb+2+be1Joj2NB7rDaW9zApNI7iXoOytBYPFdoRvUpnXsmWDOj8 mlE/LDPjHrk16RilxNdMp6dBW5FQTn8OfMbkeNDoshtEPWl5KELQZiystDXqO1zQux0w TObsnN24FsnoWvRnBxzGVV+MdX6T2fdrR5I6SKy78S/ZdpRS5YdR2IaMbk1oFPeJp6t2 FvH3HsN/jhd3RsP682+nFvWXjkncOFXneiahQnSWlmm3Zyps6k6yLAZlFtXYx/5Swci9 Y8S4n3DpNXiRvx2fhPH8zEx5lb+OoS/MXQdqsWLY2TcHwt9/7ojWGKVRcNbt4E+O10/M Ds+g== X-Gm-Message-State: AHQUAuYnzX6dl4B8QJ9tlrGxv0i32hpjVqmSLEF4NrgQWbtlvPz4Q0Ap p2iTyoRFh5l/Iem8XdrpOrmp2yDlNc15cL/UibQ= X-Google-Smtp-Source: AHgI3IZnKAjfMiHnkbT1AerxK1Z3q8GXLb3dcvennBaAEK4TzTIhYlxFXLgzTkIO0igglWD4KIBL9R61Ep+UKiYnEgI= X-Received: by 2002:a9d:715d:: with SMTP id y29mr5428844otj.148.1549452522210; Wed, 06 Feb 2019 03:28:42 -0800 (PST) MIME-Version: 1.0 References: <20190123151209.2080-1-linux.amoon@gmail.com> <20190123151209.2080-3-linux.amoon@gmail.com> In-Reply-To: From: Martin Blumenstingl Date: Wed, 6 Feb 2019 12:28:31 +0100 Message-ID: Subject: Re: [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy To: Anand Moon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190206_032845_119173_D79290FC X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Neil Armstrong , Kevin Hilman , Kishon Vijay Abraham I , Rob Herring , linux-amlogic@lists.infradead.org, linux-arm-kernel , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Anand, On Tue, Feb 5, 2019 at 8:53 PM Anand Moon wrote: [...] > > my interpretationfor the Amlogic SoCs is: > > - vusb_a and vusb_d are generated internally, not sure if there's an > > external fixed regulator > > - there is no phy-supply (the PHY itself is powered by clock-gating > > using the CLKID_USB clock) > > - usb0 VBUS is controlled by GPIOAO_5 > > > > But as per the device tree binding > > [0] https://elixir.bootlin.com/linux/v5.0-rc5/source/Documentation/devicetree/bindings/phy/meson8b-usb2-phy.txt > [1] https://elixir.bootlin.com/linux/v5.0-rc5/source/Documentation/devicetree/bindings/phy/phy-bindings.txt > > its uses phy-supply to enable power to usb phy which seem to be correct option. phy-bindings.txt states that "phy-supply" is a "Phandle to a regulator that provides power to the PHY". I have written the example in meson8b-usb2-phy.txt and I think it's wrong (back when I wrote it I didn't know about the "vbus-supply" property on the controller and I didn't know about the VBUS constraints). I believe that the phy-supply property is intended for PHYs which need an external power supply (for example because they are not embedded into a SoC or if the SoC has separate voltage inputs for the PHY). I'm not aware of any PHY supply voltage on the Amlogic SoCs (I believe this is done internally within the SoC). instead they use clock gating to power down the PHY. as far as I understand the VBUS signal it depends on the USB mode: - host provides VBUS - peripheral devices are powered using this voltage - with OTG VBUS needs to be turned on or off depending on the current mode (host or peripheral) with the "phy-supply" property there's no way to manage the regulator depending on the USB mode (host or peripheral), it will always be "on". Regards Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic