From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09BD4C32771 for ; Sat, 18 Jan 2020 22:06:42 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D22EB246A5 for ; Sat, 18 Jan 2020 22:06:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p/yfZf2f"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="rrWBZd43" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D22EB246A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3fvC/YIyBKEOJ7hAFpweILceHZ7M8XQT2JKp0rJzbQk=; b=p/yfZf2fapDZoU 13LTrsTTECtMhQdaJfcLam21OihZyoS8WmoNvyHFwzeZaJFKCMqQ/FzXKRZT3u/xqXkxqwbVjzZLY ogombv+jdXqIbXNhJVjrAz3SHkcWa5NU+b76PxNEL1PHbbDqcORBSDkJZPsU8/85tY0CgbfT7N1ba A1BE7RVJo7q3A2HBZyD50prz6IeXXmRjAJ3U7RKt3qC8SRayoEabdAURSHxm1oglSicHLWr9aLEQ/ 1e/toDV0S1ebWSujWel09CY0fX5vXPgWNjV6z3DaVDanN2DoKNuZJXVp8npzSgMmOvBYFWu4zAOsQ 2+vfwSNBjub2Gz06rEsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iswE7-0006B0-SK; Sat, 18 Jan 2020 22:05:55 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iswE5-0006AZ-QL; Sat, 18 Jan 2020 22:05:55 +0000 Received: by mail-ed1-x543.google.com with SMTP id t17so25890318eds.6; Sat, 18 Jan 2020 14:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IZo36abDKqjdvzc5GwhroDqR39xgOE1dZtSOdvhsHaY=; b=rrWBZd43dKN2kOfO+ejr5Z7+dyqYVVj50e+wGMqTbZBEstOVS6YXQyRUpr0Y+7R5h9 FjlQICJh7caGHGRWzQpSCOqXZUnhH6y2uHCnal9eJNho/+TEdrP9BNWZWERYWrrlJVq2 BEDYyjW6IgnNOM1Qov5RBgUBP6gAByvEzSGyUMV9Yg3aXnxU4WKsfMdB3ZeiHsuNCTfU ikTwlAJcNycKOPvnbJ7sIKy3vHNuReSSHgSASLXzfJRbNPt/zeDkqDkWEgO35WzvZsYL vTzVHHy44Ism6FVpp8/k7o81pySIKU2xH2qxB+KrRC8I8j8+cO8bROIyf7qokKdW9ViY vDHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IZo36abDKqjdvzc5GwhroDqR39xgOE1dZtSOdvhsHaY=; b=hKsvESV8v7wOeAL5BW8X8MykfaWKvXbpGgaVsVHIhaqIV/EUvH2MBZIjoPfqPW1y+u UmkEJU421oT17XmwrXZQl3AAImwLBA7RKf5lOeASV2xTT3LzYoqmPvwISGrEUOmKCCy2 rb4LEaMpH4M3SrgSWdZMEZ8UDH2bwgwKvGpAR5bW4iyTnv6neLMpDdYgRCA59uSoQpaX qiekSgZEuL2ybHVWT+2g3BYkroMD12Y+OjSIeuau4sbC5YZxUe8QcZL0soaMNe9gLa4i ScAjEgeNWumRKstl8O615qYFaY0uuU5gKSZOdMTiEGFKi+Z4vKYnKnbMjqBYmaSM+pKn hgXQ== X-Gm-Message-State: APjAAAX1IG/IR1knozFF2pEHqfIgY4SPN630mbPnEde4TctqaWxnice8 nBm8KoCOTB44pz3mASQ/ife18zTgV4ngetk8+Kc= X-Google-Smtp-Source: APXvYqyNH1kS9f9T6kQko9VTwsuHR9OgAGx0Ogkz4TN5x/HgDfDbqpYogNZD1zO4DAwEf3ZVTRNcAK5Ra6gnLeWPTDs= X-Received: by 2002:a17:906:90c3:: with SMTP id v3mr14156897ejw.30.1579385151960; Sat, 18 Jan 2020 14:05:51 -0800 (PST) MIME-Version: 1.0 References: <1579220504-110067-1-git-send-email-hanjie.lin@amlogic.com> <1579220504-110067-6-git-send-email-hanjie.lin@amlogic.com> In-Reply-To: <1579220504-110067-6-git-send-email-hanjie.lin@amlogic.com> From: Martin Blumenstingl Date: Sat, 18 Jan 2020 23:05:41 +0100 Message-ID: Subject: Re: [PATCH v6 5/6] arm64: dts: meson: a1: Enable USB2 PHY To: Hanjie Lin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200118_140553_879099_66856862 X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Felipe Balbi , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Hanjie, On Fri, Jan 17, 2020 at 1:22 AM Hanjie Lin wrote: > > Enable USB2 PHY for Meson A1 SoC. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) personally I would squash this with patch 6/6 because it's only useful together with patch 6/6 on the other hand: it's not worth sending a v7 just for this > @@ -100,6 +101,18 @@ > #power-domain-cells = <1>; > status = "okay"; > }; > + > + usb2_phy1: phy@40000 { > + status = "okay"; we typically use one of the following patterns: - status = "disabled" in SoC.dts - status = "okay" in board.dts whenever the peripheral should be used (example: I2C, USB, ...) OR - no status property if the peripheral is mandatory on all boards (for example: clock controller, ...) so for consistency with other Amlogic .dts I would either drop the status property or set it to disabled (and enable it in meson-a1-ad401.dts) same applies to patch 6/6 Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic