From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 6/7] mmc: meson-gx: remove Rx phase tuning
Date: Sat, 27 Apr 2019 22:09:14 +0200 [thread overview]
Message-ID: <CAFBinCDJZ2B_1_DdTRN+P9ter7kOgUHegMT-7pVODwKp7mkTKw@mail.gmail.com> (raw)
In-Reply-To: <20190423090235.17244-7-jbrunet@baylibre.com>
On Tue, Apr 23, 2019 at 11:03 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> This remove all the code related to phase settings. Using the Rx phase
> for tuning has not been reliable. We had several issues over the past
> months, on both v2 and v3 mmc chips After discussing the issue matter
> with Amlogic, They suggested to set a phase shift of 180 between Core and
> Tx and use signal resampling for the tuning.
>
> Since we won't be playing with the phase anymore, let's remove all the
> clock code related to it and set the appropriate value on init.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
[Khadas VIM now shows the HS200 eMMC]
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
BEFORE (no patches from this series applied):
# dmesg | grep mmc1
(no output)
AFTER (all 7 patches from this series applied):
# dmesg | grep mmc1
[ 2.945155] mmc1: new HS200 MMC card at address 0001
[ 2.957737] mmcblk1: mmc1:0001 AWPD3R 14.6 GiB
[ 2.966278] mmcblk1boot0: mmc1:0001 AWPD3R partition 1 4.00 MiB
[ 2.976114] mmcblk1boot1: mmc1:0001 AWPD3R partition 2 4.00 MiB
[ 2.986354] mmcblk1rpmb: mmc1:0001 AWPD3R partition 3 4.00 MiB,
chardev (241:0)
Regards
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-27 20:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 9:02 [PATCH v2 0/7] mmc: meson-gx: clean up and tuning update Jerome Brunet
2019-04-23 9:02 ` [PATCH v2 1/7] mmc: meson-gx: remove open coded read with timeout Jerome Brunet
2019-04-23 9:02 ` [PATCH v2 2/7] mmc: meson-gx: ack only raised irq Jerome Brunet
2019-04-27 19:53 ` Martin Blumenstingl
2019-04-23 9:02 ` [PATCH v2 3/7] mmc: meson-gx: correct irq flag Jerome Brunet
2019-04-27 19:56 ` Martin Blumenstingl
2019-04-23 9:02 ` [PATCH v2 4/7] mmc: meson-gx: disable HS400 Jerome Brunet
2019-04-27 20:02 ` Martin Blumenstingl
2019-04-29 8:29 ` Jerome Brunet
2019-04-29 18:31 ` Martin Blumenstingl
2019-04-29 18:50 ` Jerome Brunet
2019-04-30 20:02 ` Martin Blumenstingl
2019-04-30 20:28 ` Jerome Brunet
2019-04-23 9:02 ` [PATCH v2 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes Jerome Brunet
2019-04-27 20:03 ` Martin Blumenstingl
2019-04-23 9:02 ` [PATCH v2 6/7] mmc: meson-gx: remove Rx phase tuning Jerome Brunet
2019-04-27 20:09 ` Martin Blumenstingl [this message]
2019-04-23 9:02 ` [PATCH v2 7/7] mmc: meson-gx: add signal resampling tuning Jerome Brunet
2019-04-27 20:09 ` Martin Blumenstingl
2019-04-29 10:44 ` [PATCH v2 0/7] mmc: meson-gx: clean up and tuning update Ulf Hansson
2019-04-29 18:40 ` Martin Blumenstingl
2019-04-29 19:12 ` Kevin Hilman
2019-04-30 20:03 ` Martin Blumenstingl
2019-05-03 13:28 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCDJZ2B_1_DdTRN+P9ter7kOgUHegMT-7pVODwKp7mkTKw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).