From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A68C33C9E for ; Tue, 14 Jan 2020 20:11:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9109E24658 for ; Tue, 14 Jan 2020 20:11:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nj6USlEz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="U5UrGcnG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9109E24658 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8CoVgTOro08P0edKpmzOQ7Z9EHNYb0KvXhoYWl3Mbjg=; b=nj6USlEzEaAm+w ra9zoQ+vSVfRUGUiTL7ZPFgtvFwPZ5cyCMraHvq1510TwwQkgSuZnSyuLoTVoYGiqTrbJPyCs6OqA Ncp/MZch8/biHN1sL9rfCACkccmdhdKA6AvaRgdT+2A/JaJEhY3PzcB4LKaU5Dl193N9lADVti+lf R9oZi+RuHvFFhT3eOWRcrDzRqEBHp9X1RLop1s0PAqZY4WAB7U2ZhDNmb2R6CJ4p301yXDTIiUk5a M0KTWFPj6zjJER/z76tY/WylLru/AtB71KJV2pwlgJ8h8Q6NyyHb9jRgf/Sthg32xOKzEYpsTSS1u ZKG3d4ieQe/qqosYh89w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irSWi-0004u6-Ce; Tue, 14 Jan 2020 20:11:00 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1irSWc-0004sx-HW; Tue, 14 Jan 2020 20:10:58 +0000 Received: by mail-ed1-x541.google.com with SMTP id f8so13155645edv.2; Tue, 14 Jan 2020 12:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9+kTGzipxG+2AUMOBSHrjhkVXKsRlWSVlekuyPDJ2KQ=; b=U5UrGcnGMLeF8EkEKnq4SXQA0bZn1K6H76br30DCk6nDl7shLs9apRuVn7paVhhr+J gMmnCx0Xyy4SbGAld5Dxx7hKCe3zVde+4D7GGrJUNuk6ou71aa4b0Jg6ZSopSLHmCYgh z3ijcao7IeziK6LYdDKe/yJZ59wU1ezjYiR/PZxH3iZ5M9ycOIaoBShnoDIrQDV7pp61 rd5dofOqfUPsA5L0octRXnxmNVHNyuVUTKmF7HlpEGu3XMsHHloitIl9d7b1cvbccjHH AEK6BgTvDmyC2dFB+JvqthCztEkGsWsfUUbUsltQkgU7F6PzRxC7X2a/kK64COrwmRvd QEkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9+kTGzipxG+2AUMOBSHrjhkVXKsRlWSVlekuyPDJ2KQ=; b=nofCexmzfrvwFO4h2szC+WAJvevgS0+1fGo8Zc+N6BxZeTS7GAwhtLiVfUPAHIlfVI bmfPo4N/AZgBP+1CqVrSLwdEElps4sWRvINP2aJzkCZwc9ib9XrlxXM69OAh8Fru1wmN krd0y001nwrzBYx4uDfrTxFNNs9Dua4Macc8AFa21q5+SIsUXHBMW9zFy8DZFQxTX7wy o5FVMHmyEpSMivQuBmeLc8xJGp4rqHjP6CiB4V2aKpsO+q1/sJWprq6MYoMcIX1uuFi+ WgWr50M2shrUEC9mqfg2tP69dZelTyK9z3I12z0dJl13LVvFabr2Iih0Kz1OlQjKS+hX PAPA== X-Gm-Message-State: APjAAAX/LoDlUskihaVtYQ+Dl/AwCq17a6wFBzshwyiQCgKngMoX0wTP +MD/GfPu8fQOVC/GkMDLjdytaLTAF08oQT4vgZs= X-Google-Smtp-Source: APXvYqzsf7bCKRilpxan541+ugL4dAfOo0X8vA6AEhA9CtpMo2K4raWrA9d3K0IGQqHU1WDe0EVbnk1ga80LFRHazUc= X-Received: by 2002:a17:906:f245:: with SMTP id gy5mr23583417ejb.225.1579032653189; Tue, 14 Jan 2020 12:10:53 -0800 (PST) MIME-Version: 1.0 References: <1578634957-54826-1-git-send-email-hanjie.lin@amlogic.com> <1578634957-54826-3-git-send-email-hanjie.lin@amlogic.com> <52566105-cbee-01d6-9110-f9954eabe22f@amlogic.com> In-Reply-To: <52566105-cbee-01d6-9110-f9954eabe22f@amlogic.com> From: Martin Blumenstingl Date: Tue, 14 Jan 2020 21:10:41 +0100 Message-ID: Subject: Re: [PATCH v5 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings To: Hanjie Lin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200114_121054_587290_939BB143 X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Hanjie, On Mon, Jan 13, 2020 at 2:23 AM Hanjie Lin wrote: > > > > On 2020/1/12 4:50, Martin Blumenstingl wrote: > > Hi Hanjie, > > > > On Fri, Jan 10, 2020 at 6:43 AM Hanjie Lin wrote: > > [...] > >> @@ -37,6 +43,11 @@ properties: > >> > >> clocks: > >> minItems: 1 > >> + maxItems: 4 > > the driver parses one clock for G12A/G12B/SM1 and three clocks for A1 > > if there is a fourth clock: do we need to manage it in the driver? > > (note: dt-bindings always represent the hardware, so if there's a > > fourth clock which the driver doesn't need then it's perfectly valid > > to describe it here. a comment which clock this is helps in the > > code-review process) > > > > Hi Martin, > > Sorry for this confusing, I moved xtal_usb_phy clock from glue driver to phy, > but I missed this binding modification. > So actually A1 do only need these three clocks and no fourth clock exist, clock > and clock-names maxItems should be three here for A1. I see, thank you for clarifying this! [...] > Do you mean something like this: > > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - amlogic,meson-g12a-usb-ctrl > + > + then: > + properties: > + clocks: > + minItems: 1 > + > + - if: > + properties: > + compatible: > + enum: > + - amlogic,meson-a1-usb-ctrl > + > + then: > + properties: > + clocks: > + items: > + minItems: 3 > + clock-names: > + items: > + - const: usb_ctrl > + - const: usb_bus > + - const: xtal_usb_ctrl > + required: > + - clock-names this looks good to me (but keep in mind that I'm no expert on these yaml schemas) I wonder if we are allowed to shorten this by having one clocks property with minItems: 1 and maxItems: 3 (like you have in the original patch) and then only have a amlogic,meson-a1-usb-ctrl-specific "clock-names" property (and make that mandatory for A1 SoCs) Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic