From: Amit Kucheria <amit.kucheria@linaro.org>
To: Guillaume La Roque <glaroque@baylibre.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
linux-amlogic@lists.infradead.org,
Zhang Rui <rui.zhang@intel.com>,
lakml <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 4/7] arm64: dts: meson: g12: Add minimal thermal zone
Date: Mon, 30 Sep 2019 15:14:07 +0530 [thread overview]
Message-ID: <CAHLCerOuY1cLrkN9_f1O+Uqm9fyE18+98yU6xryojcznuPMZow@mail.gmail.com> (raw)
In-Reply-To: <20190927184352.28759-5-glaroque@baylibre.com>
On Sat, Sep 28, 2019 at 12:14 AM Guillaume La Roque
<glaroque@baylibre.com> wrote:
>
> Add minimal thermal zone for two temperature sensor
> One is located close to the DDR and the other one is
> located close to the PLLs (between the CPU and GPU)
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> .../boot/dts/amlogic/meson-g12-common.dtsi | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 0660d9ef6a86..f98171949fcb 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -12,6 +12,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/reset/amlogic,meson-axg-audio-arb.h>
> #include <dt-bindings/reset/amlogic,meson-g12a-reset.h>
> +#include <dt-bindings/thermal/thermal.h>
>
> / {
> interrupt-parent = <&gic>;
> @@ -94,6 +95,50 @@
> #size-cells = <2>;
> ranges;
>
> + thermal-zones {
> + cpu_thermal: cpu-thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <100>;
> + thermal-sensors = <&cpu_temp>;
> +
> + trips {
> + cpu_passive: cpu-passive {
> + temperature = <85000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "passive";
> + };
> +
> + cpu_hot: cpu-hot {
> + temperature = <95000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "hot";
critical instead of hot? What is the SoC's critical shutdown temperature?
Typically, you would use 'hot' at the beginning of at up trend e.g. at
75000, 'passive' to start throttling and 'critical' for shutdown
temperature.
> + };
> +
> + };
> + };
> +
> + ddr_thermal: ddr-thermal {
> + polling-delay = <1000>;
> + polling-delay-passive = <100>;
> + thermal-sensors = <&ddr_temp>;
> +
> + trips {
> + ddr_passive: ddr-passive {
> + temperature = <85000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "passive";
> + };
> + };
> +
> + cooling-maps {
> + map {
> + trip = <&ddr_passive>;
> + cooling-device = <&mali THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> + };
> +
> ethmac: ethernet@ff3f0000 {
> compatible = "amlogic,meson-axg-dwmac",
> "snps,dwmac-3.70a",
> @@ -2412,6 +2457,7 @@
> assigned-clock-rates = <0>, /* Do Nothing */
> <800000000>,
> <0>; /* Do Nothing */
> + #cooling-cells = <2>;
> };
> };
>
> --
> 2.17.1
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-09-30 9:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 18:43 [PATCH v6 0/7] Add support of New Amlogic temperature sensor for G12 SoCs Guillaume La Roque
2019-09-27 18:43 ` [PATCH v6 1/7] dt-bindings: thermal: Add DT bindings documentation for Amlogic Thermal Guillaume La Roque
2019-09-30 9:34 ` Amit Kucheria
2019-09-30 9:35 ` Amit Kucheria
2019-09-27 18:43 ` [PATCH v6 2/7] thermal: amlogic: Add thermal driver to support G12 SoCs Guillaume La Roque
2019-09-30 9:37 ` Amit Kucheria
2019-09-27 18:43 ` [PATCH v6 3/7] arm64: dts: amlogic: g12: add temperature sensor Guillaume La Roque
2019-09-30 8:19 ` Neil Armstrong
2019-09-30 9:39 ` Amit Kucheria
2019-09-27 18:43 ` [PATCH v6 4/7] arm64: dts: meson: g12: Add minimal thermal zone Guillaume La Roque
2019-09-30 8:19 ` Neil Armstrong
2019-09-30 9:44 ` Amit Kucheria [this message]
2019-09-27 18:43 ` [PATCH v6 5/7] arm64: dts: amlogic: g12a: add cooling properties Guillaume La Roque
2019-09-30 8:19 ` Neil Armstrong
2019-09-27 18:43 ` [PATCH v6 6/7] arm64: dts: amlogic: g12b: " Guillaume La Roque
2019-09-30 8:19 ` Neil Armstrong
2019-09-27 18:43 ` [PATCH v6 7/7] MAINTAINERS: add entry for Amlogic Thermal driver Guillaume La Roque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerOuY1cLrkN9_f1O+Uqm9fyE18+98yU6xryojcznuPMZow@mail.gmail.com \
--to=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=glaroque@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).