From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0C4C04AAC for ; Mon, 20 May 2019 19:22:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A129204EC for ; Mon, 20 May 2019 19:22:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HwR2ZGlg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A129204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wanadoo.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RyMme2bm4JB/KhvoHnjJ2hzv9q5AGqN7d3BD748xTug=; b=HwR2ZGlgE3yNYq Qi74iYI1fZL7GQD/bQYKTuS60D7nJvihH4hBN1AUEzRQZJN5Cu9rjeHHbyuau2bD7nRGarEiyNevx swix0Z+4gSvQWBq70YHhoz5CjAy4w+NNPwziW8i+cNRdxZIQs4Z2T45kjIt9zfgAS+TJP8LmJVmiO rV5kfle68NypuGj9CNF+fBXLwKqGPAul7iH3sn3wF91/sE4mRtU7fzxuaAWeCK9yukdHU6HaK/fDh gEIGEtxK+DhxAYkSSuUkwryKycrIjePiX2CLKvfZ/HeCPXaUnFsW8oPDXe//WppHftFT1qJrsaPZW VSd9z8NtES4kqcrmwXTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSnrN-0002Av-2C; Mon, 20 May 2019 19:22:09 +0000 Received: from smtp13.smtpout.orange.fr ([80.12.242.135] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSnrF-00023z-6w for linux-amlogic@lists.infradead.org; Mon, 20 May 2019 19:22:03 +0000 Received: from mail-qt1-f171.google.com ([209.85.160.171]) by mwinf5d70 with ME id EjMv2000F3iAcaR03jMw2d; Mon, 20 May 2019 21:21:56 +0200 X-ME-Helo: mail-qt1-f171.google.com X-ME-Auth: bWF4aS5qb3VyZGFuQHdhbmFkb28uZnI= X-ME-Date: Mon, 20 May 2019 21:21:56 +0200 X-ME-IP: 209.85.160.171 Received: by mail-qt1-f171.google.com with SMTP id a39so17705724qtk.2; Mon, 20 May 2019 12:21:56 -0700 (PDT) X-Gm-Message-State: APjAAAW0aBQhuWK71XqEuhv+YpNS4rHv3r9tPv/JKmzlF+1l/PDeALL6 HBs2mn894GFKLXENJjPtwpV6xQEdPCkDxEZ6khA= X-Google-Smtp-Source: APXvYqwWx9jKotKEBSYAh/ox+pJ7V+Mptux6Q++uPZ/syBhzl2tV/VKpkDxPtgnqjvrayCPxYj5WzDuOzvpzYmMWHCQ= X-Received: by 2002:a0c:d941:: with SMTP id t1mr61382342qvj.204.1558380115291; Mon, 20 May 2019 12:21:55 -0700 (PDT) MIME-Version: 1.0 References: <20190413171532.25967-1-martin.blumenstingl@googlemail.com> In-Reply-To: From: Maxime Jourdan Date: Mon, 20 May 2019 21:21:43 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] 32-bit Meson: add the canvas module To: Martin Blumenstingl X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_122201_530909_832E9262 X-CRM114-Status: GOOD ( 31.36 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mjourdan@baylibre.com, Kevin Hilman , Linux Kernel Mailing List , Maxime Jourdan , linux-amlogic , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hey Martin, so sorry for forgetting about this. On Thu, Apr 18, 2019 at 9:50 PM Martin Blumenstingl wrote: > > Hi Maxime, > > On Sat, Apr 13, 2019 at 8:54 PM Maxime Jourdan wrote: > > > > Hi Martin, > > On Sat, Apr 13, 2019 at 7:15 PM Martin Blumenstingl > > wrote: > > > > > > This adds the canvas module on Meson8, Meson8b and Meson8m2. The canvas > > > IP is used by the video decoder hardware as well as the VPU (video > > > output) hardware. > > > > > > Neither the VPU nor the video decoder driver support the 32-bit SoCs > > > yet. However, we can still add the canvas module to have it available > > > once these drivers gain support for the older SoCs. > > > > > > I have tested this on my Meson8m2 board by hacking the VPU driver to > > > not re-initialize the VPU (and to use the configuration set by u-boot). > > > With that hack I could get some image out of the CVBS connector. No > > > changes to the canvas driver were required. > > > > > > Due to lack of hardware I could not test Meson8, but I'm following (as > > > always) what the Amlogic 3.10 vendor kernel uses. > > > Meson8b is also not tested because u-boot of my EC-100 doesn't have > > > video output enabled (so I couldn't use the same hack I used on my > > > Meson8m2 board). > > > > > > This series meant to be applied on top of "Meson8b: add support for the > > > RTC on EC-100 and Odroid-C1" from [0] > > > > > > > > > > The series looks good to me, however I wonder if we should maybe add a > > new compatible ? > > > > The canvas IP before the GX* generation does not handle what Amlogic > > calls "endianness", the field that allows doing some byte-switching to > > get proper NV12/NV21. So the following defines are unusable: > > > > #define MESON_CANVAS_ENDIAN_SWAP16 0x1 > > #define MESON_CANVAS_ENDIAN_SWAP32 0x3 > > #define MESON_CANVAS_ENDIAN_SWAP64 0x7 > > #define MESON_CANVAS_ENDIAN_SWAP128 0xf > I didn't know about this - thank you for pointing this out. > > your suggestions to add new compatible strings is a good idea for that case. > Amlogic uses different defines for Meson8 and Meson8m2 in their vendor > kernel and they keep Meson8b different. > I will add three new compatibles, one for each SoC (Meson8, Meson8b, > Meson8m2) just to be on the safe side if we discover differences in > the canvas IP on these SoCs. > > what do you think? > Sure thing. Keep an eye out for any hints regarding the amount of canvases as well, I *think* I remember some old SoCs having only 192 but I haven't been able to find it again. > > It wouldn't change much functionally, but we could have e.g a warning > > if a m8 canvas user tries to set endianness even though it does > > nothing. > this is a good idea, that will make it easier to spot why something > doesn't work. > we can also return -EINVAL, like you already do for the case where the > canvas ID is already used. > Yes, returning an error is a good idea. Maxime > > Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic