From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F732C0650F for ; Mon, 5 Aug 2019 22:10:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C9942147A for ; Mon, 5 Aug 2019 22:10:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AuO+FhrZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UdlsxMT9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C9942147A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iphuqexHevXec4JD3ENLJpFg+4HMvMFlzDWlyV6RCQ8=; b=AuO+FhrZGCByCA e8HPgEcjHVO294E58l9HTXh4aTanvFB8B/c7y5BXW/sZ9KQ+CxR8KHTP/HfX9WRBPtYP3IyxGH4ej wH8wFGCuZOxjg/pVBcQC2PyeHeGKI1n8cIHulxrRfPZBIIZBz+gyxJARoz4gFaqBfSOyCK3Xaofje 5VxX2V6WFpIwdlhfq4E5wsT2yyJemV4/KLaG1pXxTnOokU9Mj27LpP79MBPzgoMKuKtQiaKjz2nOi YWvQo7QlM8VRAC5yQjjmkjz1HBucZFUtmLx2xrd1IisN/8XCuWt75+STmo6/6yd4ZtkWUbDyGICuD KIMEnvB5V7CgRPrGxZ+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hulB0-0003ar-RA; Mon, 05 Aug 2019 22:09:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hulAy-0003aT-6V; Mon, 05 Aug 2019 22:09:57 +0000 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A32D52147A; Mon, 5 Aug 2019 22:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565042995; bh=NAJ16jvh/qchypdVowjtbzNr9+9foVnE+vd1uUZQC7g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UdlsxMT9wxnPg84czTc53XMAznVmd7n8JRcYPxB0Fu7FGgY6Vf9s/Dqc+UR+3IfO7 LPXWB3QDqCrtcNwuUxU7BaE/2hGz/E0e0XBJLo7Q5km8dkVP/ybkS82B3bEJoI21rs XBRKjIh4YtimZeQp5Or12nvID6o1ifjlu7V5KIpU= Received: by mail-qt1-f169.google.com with SMTP id a15so82549465qtn.7; Mon, 05 Aug 2019 15:09:55 -0700 (PDT) X-Gm-Message-State: APjAAAX95EYgxJRef0y4cf/4D72pgBFvaJfoNK5+wlQKBdD0h085Lohv ftMUCX/pyuTD4C9qkqryWtt3Aujb+P1K7bOzIw== X-Google-Smtp-Source: APXvYqzN7Oaow/mdIokjxZIROhfoq29oWOHhIQUUHynApmz52dA7L6a16lTZR93u1Os4RUyoD7Omw1XiDFtlZBNZ4Fw= X-Received: by 2002:a0c:acef:: with SMTP id n44mr215262qvc.39.1565042994893; Mon, 05 Aug 2019 15:09:54 -0700 (PDT) MIME-Version: 1.0 References: <20190805122558.5130-1-narmstrong@baylibre.com> In-Reply-To: <20190805122558.5130-1-narmstrong@baylibre.com> From: Rob Herring Date: Mon, 5 Aug 2019 16:09:43 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: net: meson-dwmac: convert to yaml To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_150956_265263_BDFE0C8F X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Martin Blumenstingl , netdev , "linux-kernel@vger.kernel.org" , linux-amlogic@lists.infradead.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Aug 5, 2019 at 6:26 AM Neil Armstrong wrote: > > Now that we have the DT validation in place, let's convert the device tree > bindings for the Synopsys DWMAC Glue for Amlogic SoCs over to a YAML schemas. > > Signed-off-by: Neil Armstrong > --- > Rob, > > I keep getting : > .../devicetree/bindings/net/amlogic,meson-dwmac.example.dt.yaml: ethernet@c9410000: reg: [[3376480256, 65536], [3364046144, 8]] is too long Because snps,dwmac.yaml has: reg: maxItems: 1 The schemas are applied separately and all have to be valid. You'll need to change snps,dwmac.yaml to: reg: minItems: 1 maxItems: 2 The schema error messages leave something to be desired. I wish the error messages said which schema is throwing the error. > for the example DT > > and for the board DT : > ../amlogic/meson-gxl-s905x-libretech-cc.dt.yaml: ethernet@c9410000: reg: [[0, 3376480256, 0, 65536, 0, 3364046144, 0, 4]] is too short > ../amlogic/meson-gxl-s905x-nexbox-a95x.dt.yaml: soc: ethernet@c9410000:reg:0: [0, 3376480256, 0, 65536, 0, 3364046144, 0, 4] is too long > > and I don't know how to get rid of it. The first issue is the same as the above. The 2nd issue is the use of <> in dts files becomes stricter with the schema. Each entry in an array needs to be bracketed: reg = <0x0 0xc9410000 0x0 0x10000>, <0x0 0xc8834540 0x0 0x4>; Rob _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic