Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC

From: Anand Moon <linux.amoon@gmail.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC
Date: Thu, 30 Jul 2020 23:34:16 +0530	[thread overview]
Message-ID: <CANAwSgR2awx2SnwvVrkjnzBDaSU4rP4as2663+hD+wUddkHSqg@mail.gmail.com> (raw)
In-Reply-To: <1jbljx85vh.fsf@starbuckisacylon.baylibre.com>

Hi Jerome,

On Thu, 30 Jul 2020 at 19:25, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Thu 30 Jul 2020 at 15:46, Anand Moon <linux.amoon@gmail.com> wrote:
>
> > Hi Jerome
> >
> > On Thu, 30 Jul 2020 at 17:44, Jerome Brunet <jbrunet@baylibre.com> wrote:
> >>
> >>
> >> On Thu 30 Jul 2020 at 13:57, Jerome Brunet <jbrunet@baylibre.com> wrote:
> >>
> >> > On Thu 30 Jul 2020 at 12:02, Anand Moon <linux.amoon@gmail.com> wrote:
> >> >
> >> >> These patch fix the Ethernet issue on Odroid C2 & Odroid N2
> >> >> Some time Ethernet interface come up but no DHCP request
> >> >> is forwaded to the Router, this happens quite offern on
> >> >> my side. Adding Reset controller to ethernet node FIx the
> >> >> inilization issue.
> >> >>
> >> >
> >> > I'm seeing this on other device as well. Strange that it pops up only
> >> > now. Change tested on S905x, seems to help.
> >>
> >> Strike that one - still seeing random DHCP issue on boot with this
> >> applied
> >>
> >> >
> >> >> -Anand
> >> >>
> >> >> Anand Moon (3):
> >> >>   arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
> >> >>   arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
> >> >>   arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
> >> >
> >> > None of the patches apply, please rebase on kevin's dt64 branch.
> >> >
> >> > With that, you can add
> >> >
> >> > Tested-by: Jerome Brunet <jbrunet@baylibre.com>
> >>
> > So I have to drop the Tested-by  ?
>
> Yes
>
> >
> >> So still worth rebasing and applying on I suppose but I don't think it
> >> solves the problem as described in this cover letter.
> >>
> >
> > I have a mac address mapped to the ip address on my router,
> > So I am just testing with the latest u-boot-2000.07 on my boards.
> > Usually the ethernet comes up with no packet getting forwarded,
> > Even ping to the device is not working, which is what I observed at
> > my end many times.
>
> This is not the use case descibed in the cover letter. Please clarify if
> you resubmit.
>

This was some observation at my end. If these changes don't fix the issue.
I will drop my observation and just send the missing reset controller
for ethernet

-Anand

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic