From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A5CC26641 for ; Sun, 20 Jan 2019 18:45:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6ECF20861 for ; Sun, 20 Jan 2019 18:45:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dXTelWQY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l13ZQsCz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6ECF20861 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Dj894tj8HXh4vLkIKhoy3iyU4TNs9o61xav4gHuAOw=; b=dXTelWQYlqrRZF 2ct5XGPiyoFeJ+0yne6STr1LSaHA7drc2wSbQuy2FSjQeEZPQEBTt2h6UrcfwuDKnPf08lyFs0gWj Sb1EWd6xqpndPI4t6ZGARCeR0fiYkeFU2ucC6rFCEuj0qqTSZTLqfsk2s+eIdt3BcnVrvDhdqKcpN iLT8z9chnDEngxwmJ/EouvPqcezpdkwF4kgEsTkMivXzx5m+cEoZDk/X4hjmxKLceW5dWeHArlIzb EoS8gcHAwJwU05Ir0JkDFqmU4mUnKwtz9qSDfp+/z2YiuOYA4aFyShmZ1cqB6DZnkmtEZUZ4PZjQP 7xMFtImfI2Insz2RDaVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1glI6J-0006OL-4F; Sun, 20 Jan 2019 18:45:43 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glI64-0006EL-1l; Sun, 20 Jan 2019 18:45:32 +0000 Received: by mail-ot1-x332.google.com with SMTP id 81so18805674otj.2; Sun, 20 Jan 2019 10:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qSUeS8oJwQjTnGeOUAKOWFJv18+u1IPIuRY1G9vzS1w=; b=l13ZQsCzea9wSvIZHYQLeqbm72BTVgs1K2SY9AnhUeDkz6fBNJOTnpjMnx0dHnmNwU NQxa5bPW+fE28t/+tGCtsmokub0xsXnxXKjAc9/HMFW9UW1fq1fH1BtY97eqHAaU+7BF Qif3kNQ1h7zvZu1OIMK50NYnC3dYj6cHBS+YE5wsJzt2vpkbCUJ+CNz6zEK7sm8KaIWv oW02IGbD/nV0TkhLDDs89nw0nbDWK2mCUy8u0JHxDh0adfG69JnxpSt2k9SSIkNA0d6W hfOZa8AF+6oJrfQimXMWb1Lnsnxo+DZHV/OwOW2XqRN12z/R3syWoxt9FXoAqcLq2oGK yjpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qSUeS8oJwQjTnGeOUAKOWFJv18+u1IPIuRY1G9vzS1w=; b=ZGF8BGlvLTw7X6WmhJM4PozKODZKyU316MZOYcOgfqf/1vi2MgKAJab8weeb0mv3H2 ATIXQZXkxLUYaEehG+eddZu7UZ8cXM4XJM0SOHvzvy9FapfClR/+ckrRXzj6yCr91cAH kqr627qibKlIBMPQHyQWHsiAxB/5RuXtlhgvv2wKJBsV6iJS+V/ZHFm5pSTvkGz/6ZyD oSc147oHtvCbiFSk4SjUWKso0rjVlHXdrgFROuggDGXtk3WWVs7cvQVEGwG4r9nFBA4b a+7Qkrqw9bMg6BO1mHezsviqlG7uJsBg/BZdS2EmcZXxCVmzbBi0ZHXSxB+KEhyXhX0p 5O2A== X-Gm-Message-State: AJcUukcZcmq3hAruKsPonCgMHnwDHFP9p5413H2r+9TQBHZiEAOoiMWF 1iUPMVrT5uGbQpMMysDOBSwsNRyqfQtXxLa3kHM= X-Google-Smtp-Source: ALg8bN5VVJQ5IoTk2HbOCwA1xPFl/1sDUL4/oJ7ISCh96jkCScPfADdj3ken4zq1ifaGzTirMh4hZJfF1j3yjhP64to= X-Received: by 2002:a9d:42c:: with SMTP id 41mr18349078otc.41.1548009926889; Sun, 20 Jan 2019 10:45:26 -0800 (PST) MIME-Version: 1.0 References: <20190113153022.5040-1-linux.amoon@gmail.com> <7hy37j9ebi.fsf@baylibre.com> In-Reply-To: <7hy37j9ebi.fsf@baylibre.com> From: Anand Moon Date: Mon, 21 Jan 2019 00:15:15 +0530 Message-ID: Subject: Re: [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning To: Kevin Hilman X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190120_104528_090929_40BC294B X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Neil Armstrong , Martin Blumenstingl , Linux Kernel , Rob Herring , linux-amlogic@lists.infradead.org, linux-arm-kernel , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Kevin / Martin, On Fri, 18 Jan 2019 at 02:44, Kevin Hilman wrote: > > Hi Anand, > > Anand Moon writes: > > > Override the dr_mode from "host" to "peripheral" for dwc2 > > usb_phy0->usb0 initilization of OTG Micro-B type. > > Changes fix the below warning for phy poweron failed --> -22 > > > > Changes fix the initialization of c9000000.usb phy > > > > [ 1.203900] phy phy-c0000000.phy.0: USB ID detect failed! > > [ 1.208048] phy phy-c0000000.phy.0: phy poweron failed --> -22 > > [ 1.213877] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8 > > [ 1.222953] Modules linked in: > > [ 1.225976] CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.0.0-rc1-xc2ml #3 > > [ 1.232872] Hardware name: Hardkernel ODROID-C2 (DT) > > [ 1.237794] Workqueue: events deferred_probe_work_func > > [ 1.242878] pstate: 80000005 (Nzcv daif -PAN -UAO) > > [ 1.247623] pc : _regulator_put.part.11+0xf0/0xf8 > > [ 1.252280] lr : regulator_put+0x34/0x48 > > [ 1.256159] sp : ffff00001176bb00 > > [ 1.259437] x29: ffff00001176bb00 x28: 0000000000000000 > > [ 1.264698] x27: ffff80007f31beb8 x26: ffff000010eeb7e0 > > [ 1.269959] x25: 0000000000000000 x24: 0000000000000009 > > [ 1.275220] x23: ffff00001176bbc8 x22: ffff80007ed9d500 > > [ 1.280482] x21: ffff0000111bd6c8 x20: ffff80007ed9d700 > > [ 1.285743] x19: ffff80007ed9d700 x18: 000000000000006f > > [ 1.291004] x17: 0000000000000000 x16: 0000000000000000 > > [ 1.296265] x15: 0000000000000400 x14: 0000000000000400 > > [ 1.301527] x13: ff00000000000000 x12: ffffffffffffffff > > [ 1.306788] x11: 0000000000000038 x10: 0000000000000040 > > [ 1.312049] x9 : ffff0000111d58b0 x8 : ffff0000111d58a8 > > [ 1.317310] x7 : ffff80007ed9db00 x6 : ffff80007ec21b00 > > [ 1.322571] x5 : ffff80007f400248 x4 : ffff80007fba9b00 > > [ 1.327833] x3 : ffff0000112d9eb8 x2 : ffff80007ec21b00 > > [ 1.333094] x1 : 0000000000000000 x0 : 0000000000000001 > > [ 1.338356] Call trace: > > [ 1.340773] _regulator_put.part.11+0xf0/0xf8 > > [ 1.345085] regulator_put+0x34/0x48 > > [ 1.348621] regulator_bulk_free+0x30/0x50 > > [ 1.352675] devm_regulator_bulk_release+0x18/0x20 > > [ 1.357421] release_nodes+0x1b0/0x220 > > [ 1.361127] devres_release_all+0x34/0x50 > > [ 1.365094] really_probe+0xec/0x290 > > [ 1.368630] driver_probe_device+0x54/0xe8 > > [ 1.372684] __device_attach_driver+0xb8/0xe8 > > [ 1.376997] bus_for_each_drv+0x78/0xc8 > > [ 1.380792] __device_attach+0xd4/0x130 > > [ 1.384587] device_initial_probe+0x10/0x18 > > [ 1.388727] bus_probe_device+0x90/0x98 > > [ 1.392522] deferred_probe_work_func+0x6c/0xa0 > > [ 1.397010] process_one_work+0x1e0/0x318 > > [ 1.400975] worker_thread+0x228/0x428 > > [ 1.404684] kthread+0x124/0x128 > > [ 1.407876] ret_from_fork+0x10/0x18 > > [ 1.411410] ---[ end trace de5fd1b262c1f56a ]--- > > [ 1.416055] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8 > > [ 1.425123] Modules linked in: > > [ 1.428144] CPU: 1 PID: 44 Comm: kworker/1:1 Tainted: GW 5.0.0-rc1-xc2ml #3 > > [ 1.436422] Hardware name: Hardkernel ODROID-C2 (DT) > > [ 1.441340] Workqueue: events deferred_probe_work_func > > > > Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes) > > Minor nit: the shortlog should be in double quotes. > > I fixed it up manually, so nothing you need to do, but just for future > reference. > > This was found by some automated checking recently added to the > linux-next tree. > > Kevin > Thanks: I will follow the protocol next time. As pointed my Martin on Odroid C1+ my patch do not fix complete issue. [0] https://patchwork.kernel.org/patch/10761371/ [1] https://patchwork.kernel.org/patch/10761375/ Both of my patch seem to be wrong and if possible please so drop them from linux-next and your fix tagged. I will try to find proper fix proper to the issue. Quick phy driver and dts changes enable *Bus 01.Port 1* and *Bus 02.Port 1* [alarm@archl-c2m ~]$ lsusb -t /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M |__ Port 1: Dev 5, If 0, Class=Mass Storage, Driver=usb-storage, 480M |__ Port 2: Dev 3, If 0, Class=Video, Driver=uvcvideo, 480M |__ Port 2: Dev 3, If 1, Class=Video, Driver=uvcvideo, 480M |__ Port 2: Dev 3, If 2, Class=Audio, Driver=, 480M |__ Port 2: Dev 3, If 3, Class=Audio, Driver=, 480M |__ Port 3: Dev 4, If 0, Class=Vendor Specific Class, Driver=, 480M /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M Need to fix the vbus setting for both the bus ports, which I am looking into. Best Regards -Anand _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic