From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F151DC4338F for ; Fri, 13 Aug 2021 19:38:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7F1D61038 for ; Fri, 13 Aug 2021 19:38:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A7F1D61038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IHdWwA1Y+9goeQxRhrVQKm+KfTbsdqT+TWH8n2bHdyg=; b=mTdNwhIfLFq0i2 Reh9OaQfFM6uzYm/6ugJwNB8ykg87ymyJc9LbY2dZNXmDr57EpEztxUEIFySaM4YW20DnmRIVh1/6 wNMKPqqLb7WMO+MRhTU1z4aBcb/qrOzsxMf/HPpkxUICVAnbj/qN2kabhUatIRwO7+YWqAfiZSUMG DlfLPU5Kd96S8icrKedGwLy49sggiawFmGU0JJcX/klQEEbevES9opNWTzGyf4rrPPFC4Itr5vO5F QWkSGolpKZbLhV4SOg6NKxuP034ZyTdiR7tcP6B74C1QD8VZWYpp5Ewobzbrbyub5PD6pdOa1BR2y lAHZ2dyVmE3bT1/yHpkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEd0L-00DUXl-Nu; Fri, 13 Aug 2021 19:38:09 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEd06-00DUQe-69; Fri, 13 Aug 2021 19:37:58 +0000 Received: by mail-ej1-x62e.google.com with SMTP id hs10so20288510ejc.0; Fri, 13 Aug 2021 12:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HOexqmWKRM3IjPdhhxIgoa6z/c3dqxUyUXL0t6jHr2k=; b=mu+lRZY8XVbAUyaFHX7V7WTY4Wb56SszmMWradGud5YJ7iyPeq1q9lkaERCVe+0HY2 xVs3PfulG5c4qbkwWB4wLG/2a88mFTYZAbUWSEhOvKLEr5Kb3iiv0jXFRKwNOh74S+EC HSS8H3vRqxmZbolrxCPE+6iLoLF7W9KPsyoG3jKYtnoqRvEbg42XqGOQGZFAkxfbQGST /5A8zApjpQbmGRqiRe5668ZrxQlyvAqtPDJvVVNlu+uKIUpYTSt/Q/479o7RAR6rFAg3 sV9mfyJ8iUXc7AzLs1KGXNZ0WZ5UHirEMfmse4d9jiry7lR6nSzJZBJH5bZvYmNNthEh 70+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HOexqmWKRM3IjPdhhxIgoa6z/c3dqxUyUXL0t6jHr2k=; b=ScRukvZJUKHgZqLDD9xDPNmvhhWB5Vm8H6sXtfSNoxHcIt3jUbWnOp2qaF6ZuY0I0S oNZm+X6KkmJ1oQFVWz9LML3VtS5jBmhuOVqinnstoXeC7PDvh72L2CbNmP45FRNjD4Pr Mhk0vJ7t5wjtZYsa7UwJN+P0ZYOAqDeDMW2hMEMIJ9akx2VaLKFtjzDiGnKvEgmpc8E5 YwotxUQ4qyS9nZtwSIkI7YmGTEtZllMPrStIdpcw1Kbke75OuxeFCFlSN0B3rtwkuTq1 89drfr+DKqFYjSTvb/Eu8s25OOJ9h6zkGArO8TBBLAn+iuerXB28/4UNmJt/irGuZhOj qQaQ== X-Gm-Message-State: AOAM533fFLKKqCEg8usxQYzqJ6otUk9bk+E9yCtizZfTpcJjyh6tL6D4 lB0UN94HjVC6Y46vIpiskvzPUFnRB3SWtXN6x9U= X-Google-Smtp-Source: ABdhPJzo21B8s2gllwmkb26smEseF4nn9KMOpTZclBGisjc+pLGtFjEFegAWFUtyZGrm231/pEtt6UX8eiW6VVT2fVA= X-Received: by 2002:a17:907:1c92:: with SMTP id nb18mr4163817ejc.191.1628883351488; Fri, 13 Aug 2021 12:35:51 -0700 (PDT) MIME-Version: 1.0 References: <20210716103651.1455-1-linux.amoon@gmail.com> <20210716103651.1455-2-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Sat, 14 Aug 2021 01:05:40 +0530 Message-ID: Subject: Re: [PATCHv2 1/4] ARM: dts: meson8b: odroidc1: Add usb phy power node To: Martin Blumenstingl Cc: linux-phy@lists.infradead.org, linux-arm-kernel , linux-amlogic@lists.infradead.org, Linux Kernel , Matt Corallo , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , devicetree X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_123754_281483_37E24799 X-CRM114-Status: GOOD ( 38.74 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Martin, On Thu, 5 Aug 2021 at 23:48, Anand Moon wrote: > > Hi Martin, > > On Thu, 5 Aug 2021 at 03:28, Martin Blumenstingl > wrote: > > > > On Sun, Jul 18, 2021 at 9:09 PM Martin Blumenstingl > > wrote: > > > > > > Hi Anand, > > > > > > On Sun, Jul 18, 2021 at 4:01 PM Martin Blumenstingl > > > wrote: > > > [...] > > > > > From the schematics [1] > > > > > https://dn.odroid.com/S805/Schematics/odroid-c1+_rev0.4_20160226.pdf > > > > > > > > > > You could find references to PWREN <--- GPIOAO.BIT5 > > > > > The second reference is USB HOST Power Switch > > > > > The third reference is USB HOST POWER. > > > > > > > > > > Hope I am clean in my thought process now. > > > > Can you please point out the page numbers for me? > > > > > > > > What I am seeing on page 1 is: > > > > GPIOAO_5 (called GPIOAO.BIT5) is connected as an INPUT to the USB_OTG > > > > PWREN signal (that's the green box with the label "USB_OTG.SchDoc" > > > > above it). > > > I unfortunately missed your question on IRC on this topic: > > > xdarklight: just want to understand the confusion on PWREN, > > > either is INPUT / OTPUT to usb hub am I correct > > > My understanding of the INPUT/OUTPUT direction in the Odroid-C1 > > > schematics (which you linked) above is that the arrow direction shows > > > whether it's an input or output. > > > For example (all on page one): > > > - HDMI_HPD is an input to the Meson8b SoC, arrow direction is: HDMI => S805 > > > - IR_IN is an input to the Meson8b SoC, arrow direction is: S805 <= > > > GPIOAO.BIT7 IR_IN > > > - PWM is an output, arrow direction is: S805 => PWM.C VCCK_PWM > > > - 3.3V/1.8V switch for the SD card is an output, arrow direction is: > > > S805 => GPIOAO.BIT3 TF_3V3N_1V8_EN > > > > > > That tells me: the arrow direction shows which connections are inputs > > > or outputs. > > > Some pins can be input and output at the same time (HDMI_CEC). But > > > let's keep it simple for now any only look at inputs/output. > > > > > > Based on this information I am looking at the arrow direction for > > > USB_OTG: GPIOAO.BIT5 PWREN <= S805 > > > So this confirms that GPIOAO_5 is an output to the SoC. > > > Please note though that this part is not linked with any USB host > > > connector, it's only linked to the USB OTG path. > > > > > > For the next part the S805 SoC is not involved: > > > USB1 USB_HOST_PWR_SW PWREN <= PWREN USB_HUB_GL852G > > > USB2 USB_HOST_PWR_SW PWREN <= PWREN USB_HUB_GL852G > > > This tells me that the PWREN signal for the two USB_HOST_PWR_SW (USB > > > host power switches / current limiters) is driven by the GL852G USB > > > hub. > > Hardkernel team responded on the Odroid forums to the request from Anand: > > "Power-Enable signal to the USB load switch ICs is connected to the > > USB hub controller. > > It is not connected the CPU GPIO." > > > > The regulator from Anand's patch is therefore connected to the micro USB port. > > This means that the patch needs updating in case Anand wants to have > > it included. > > > > Yes, I will send a corrected version of the patches soon. I have a small query regarding GPIO polarity As per the datasheet of *MP62551DGT-LF-Z* [0] https://www.mouser.in/datasheet/2/277/MP62550-1384050.pdf USB power enables EN signal need to be Active High. PIN Fucntion > Enable input. Active Low: (MP62550), Active High: (MP62551). So the correct option in dts + /* + * signal name from schematics: PWREN - GPIOAO.BIT5 + */ + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; + enable-active-high; which gives me the below output. $ sudo cat /sys/kernel/debug/gpio | grep USB gpio-1953 (USB_HUB_RST_N |usb-hub-reset ) out hi gpio-1954 (USB_OTG_PWREN |regulator-usb-pwr-en) out hi Please clear this small query so that I can send the update patch. Thanks -Anand > > > > > Best regards, > > Martin > > > > > > [0] https://forum.odroid.com/viewtopic.php?p=332217#p332217 > > Thanks > -Anand _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic