From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27969C282D7 for ; Wed, 30 Jan 2019 09:27:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE42B21874 for ; Wed, 30 Jan 2019 09:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fPwZW52r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE42B21874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3MWKXv4V9U2uGrAeBiN31LoATvG89AO1F8DXEQHWyWE=; b=fPwZW52rw4LHS1Xr71/xtepup 0i++CntxYUxW26pbeLyWSAejkF7JRunt4654evrTDqR3uC11cDN/3rDN1gDwNK1Jl3YhNjz9jtyR7 cHQ4HDlrKSPOJFN+uKG3YdTPcjOEvb5PcdZgtwaUAt+T7JLLQO+qSzLsVDm9DnQWghA/Iaya5T9hk H5k/QPtrl2ffF987+PDScRZjdOTVBiMEi7YsU9VOZgXm2Rc/jJXPL0JG9IhCYVeD2woDfv4bbaYgD XyT91yft1DNpxrdv4e0ghfpp5DrGGmIc9f6JNppn5hxP8HaMMFOigukJnRPKZhTcGbu7cxSIgpbaB ltRFjVQ4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gom9E-0004mB-Fk; Wed, 30 Jan 2019 09:27:08 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gom8T-00040a-1X; Wed, 30 Jan 2019 09:26:26 +0000 Received: from [10.28.18.236] (10.28.18.236) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Wed, 30 Jan 2019 17:27:10 +0800 Subject: Re: [PATCH][next] mtd: rawnand: meson:: make several functions static To: Colin King , Boris Brezillon , Miquel Raynal , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Kevin Hilman , , , References: <20190129124429.19829-1-colin.king@canonical.com> From: Liang Yang Message-ID: Date: Wed, 30 Jan 2019 17:27:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190129124429.19829-1-colin.king@canonical.com> Content-Language: en-US X-Originating-IP: [10.28.18.236] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190130_012621_581208_121A3AF2 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Colin, On 2019/1/29 20:44, Colin King wrote: > From: Colin Ian King > > There are several functions that are local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings. > > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/raw/meson_nand.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index b9c543d1054c..9557bd94dcd2 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page) > return meson_nfc_read_page_hwecc(nand, NULL, 1, page); > } > > -bool meson_nfc_is_buffer_dma_safe(const void *buffer) > +static bool meson_nfc_is_buffer_dma_safe(const void *buffer) > { > if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer))) > return true; > return false; > } > > -void * > +static void * > meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr) > { > if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR)) > @@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr) > return kzalloc(instr->ctx.data.len, GFP_KERNEL); > } > > -void > +static void > meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr, > void *buf) > { > @@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr, > kfree(buf); > } > > -void * > +static void * > meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr) > { > if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR)) > @@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr) > instr->ctx.data.len, GFP_KERNEL); > } > > -void > +static void > meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr, > const void *buf) > { > Looks good to me: Acked-by: Liang Yang _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic