From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646B7C4727C for ; Tue, 29 Sep 2020 13:42:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA1CD207C4 for ; Tue, 29 Sep 2020 13:42:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fdRzcdgo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA1CD207C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bEvPwomIgMgzYtZ8UeeR2P7TySPGtFNc+VMqL7AoJZY=; b=fdRzcdgoX60e/TbanmG9XVU6z f3Q/AgxyVnOJUwURuNBMTrYRy7lZ6r0hjyCrSbd0DUnmU11LepsOTBvV3rgnhomnT8dwkp0R9J7gE GUBeJp5bEPHAFpHuY+jr01VQ+Yt807aD1XejkJKztaLyagCG/EdEqtk0lWD6EolFIS+lfMPjJWKaG ENstws+t95uvHRmxkqqr2HAD+Mfu4gopwhWi0SIz3IPKNj5q4b1fLCHirzEDT8XlnGXdG8GriF/ZB CwzlyTdPlZgliRESaQFpTPlp+7iyFBk7wD+/akijvaUNIsl7O2+7ZnEaYw7tKlTyRwzHV69b5cMPT xU7Y+id2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNFu1-0004PR-Ag; Tue, 29 Sep 2020 13:42:45 +0000 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNFtx-0004O3-Vo; Tue, 29 Sep 2020 13:42:43 +0000 X-IronPort-AV: E=Sophos;i="5.77,318,1596492000"; d="scan'208";a="470076349" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 15:42:38 +0200 Date: Tue, 29 Sep 2020 15:42:32 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Joe Perches Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements In-Reply-To: <5f0d2b20f5088281363bb4a35c5652a2c087f159.camel@perches.com> Message-ID: References: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr> <20200929124108.GY4282@kadam> <5f0d2b20f5088281363bb4a35c5652a2c087f159.camel@perches.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_094242_330808_BD5D8D37 X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org, Shuah Khan , linux-stm32@st-md-mailman.stormreply.com, Jerome Brunet , "Rafael J. Wysocki" , Ard Biesheuvel , ACPI Devel Maling List , Dan Carpenter , David Lechner , Martin Blumenstingl , linux-clk@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@tron.linbit.com, linux-amlogic@lists.infradead.org, openipmi-developer@lists.sourceforge.net, Linux ARM , =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= , linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Julia Lawall , Thomas Gleixner , Linux Crypto Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, 29 Sep 2020, Joe Perches wrote: > On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: > > On Tue, 29 Sep 2020, Dan Carpenter wrote: > > > The times where commas are used deliberately to replace curly braces are > > > just evil. Either way the code is cleaner with semi-colons. > > > > I also found exaamples like the following to be particularly unforunate: > > > > fprintf(stderr, > > "page_nr %lu wrong count %Lu %Lu\n", > > page_nr, count, > > count_verify[page_nr]), exit(1); > > > > The exit is very hard to see, unless you know to look for it. > > I sent that patch last month. > https://patchwork.kernel.org/patch/11734877/ > > It's still not applied. OK, thanks. I'll not send those then :) julia _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic