From: "Andreas Färber" <afaerber@suse.de>
To: Mohammad Rasim <mohammad.rasim96@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>,
linux-bluetooth@vger.kernel.org,
Johan Hedberg <johan.hedberg@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth
Date: Sat, 16 Nov 2019 10:43:41 +0100 [thread overview]
Message-ID: <b22e57eb-978f-9ec8-9ca6-06c0f5e7b9f6@suse.de> (raw)
In-Reply-To: <20191115165026.19376-2-mohammad.rasim96@gmail.com>
Am 15.11.19 um 17:50 schrieb Mohammad Rasim:
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
Lacking a commit description. Please add a sentence.
> ---
> drivers/bluetooth/btbcm.c | 1 +
> drivers/bluetooth/hci_bcm.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 2d2e6d862068..22464bf8cda3 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -339,6 +339,7 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
> { 0x220e, "BCM20702A1" }, /* 001.002.014 */
> { 0x4217, "BCM4329B1" }, /* 002.002.023 */
> { 0x6106, "BCM4359C0" }, /* 003.001.006 */
> + { 0x4106, "BCM4335A0" }, /* 002.001.006 */
> { }
> };
Beyond this patch: There appears to be no order in this table at all?
Not alphabetically, not numerically, not by comment.
>
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index 7646636f2d18..7b4bb5dbea1d 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1422,6 +1422,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
> { .compatible = "brcm,bcm4345c5" },
> { .compatible = "brcm,bcm4330-bt" },
> { .compatible = "brcm,bcm43438-bt" },
> + { .compatible = "brcm,bcm4335A0" },
You can't use compatible strings without defining the binding first. Why
do you need it? If you do, use lowercase names.
> { },
> };
> MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-11-16 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 16:50 [RFC PATCH 0/2] add support for videostrong KII Pro Mohammad Rasim
2019-11-15 16:50 ` [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
2019-11-16 9:43 ` Andreas Färber [this message]
2019-11-18 17:35 ` Mohammad Rasim
2019-11-15 16:50 ` [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box Mohammad Rasim
2019-11-16 9:53 ` Andreas Färber
2019-11-16 10:28 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b22e57eb-978f-9ec8-9ca6-06c0f5e7b9f6@suse.de \
--to=afaerber@suse.de \
--cc=johan.hedberg@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mohammad.rasim96@gmail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).