From: Aymeric <mulx@aplu.fr>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: meson8b: add ethernet fifo sizes
Date: Sun, 4 Aug 2019 21:38:09 +0200 [thread overview]
Message-ID: <b5ad180d-af13-cc37-87da-1aa72f10f518@aplu.fr> (raw)
In-Reply-To: <CAFBinCBefuCvTL0E_zf=EQDLyTjE5sQD-TkHNj2vQ2UOCsmtkA@mail.gmail.com>
Le 23/07/2019 à 21:56, Martin Blumenstingl a écrit :
> On Thu, Jul 18, 2019 at 11:36 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>> If unspecified in DT, the fifo sizes are not automatically detected by
>> the dwmac1000 dma driver and the reported fifo sizes default to 0.
>> Because of this, flow control will be turned off on the device.
>>
>> Add the fifo sizes provided by the datasheet in the SoC in DT so
>> flow control may be enabled if necessary.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> I wonder if this "fixes" some of the performance issues on Odroid-C1
> testing this is now on my TODO-list for the weekend
Good! and maybe that will fix the stability issue I'm seeing when using
the board with a 1 gigabit link! (cf
http://lists.infradead.org/pipermail/linux-amlogic/2019-June/012341.html)
I'll try that asap on my board too :)
Thanks.
--
Aymeric
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-08-04 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 9:36 [PATCH] ARM: dts: meson8b: add ethernet fifo sizes Jerome Brunet
2019-07-23 19:56 ` Martin Blumenstingl
2019-08-04 19:38 ` Aymeric [this message]
2019-08-05 20:57 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5ad180d-af13-cc37-87da-1aa72f10f518@aplu.fr \
--to=mulx@aplu.fr \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).