From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4891C4CEC4 for ; Thu, 19 Sep 2019 02:34:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A00F720578 for ; Thu, 19 Sep 2019 02:34:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MD+BW0bT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A00F720578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TcphCoc8e+C12BNplhobPgylWQQGnAs9FICpzDYMnYk=; b=MD+BW0bTmUniWm0TYwh6YfT6K w7UAr5fWRoxIG7nb7KnFXkSxGhbGDbPfMHMKPWfSBH0zbzeor6iyZLCv99YkLLE4F8OJThSBqz4aT uW4Vj935I7DpDgeteTzUahOJzqqrbmG2va+1bQJKMF/z6XC741Dn5E4Os/o+g5ww09a3vB0MVpTR0 1FeOVudYUxfR0ZSndDkjRDaZykJK8O3ZNycikjO5x2EMWAYCEmWZxCvpsZ3yBCqc/dZb9EMuZRDaQ sDv/JCZqsWTZ0YYO9x8+hNFOJgjKtAaSYMvgfBSvzaKmtaJYM8Snw+I36OTnzs5FC7+oHOij1Dgj4 WmuZZgY8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAmGt-0005dm-2Y; Thu, 19 Sep 2019 02:34:15 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAmGc-0005Ow-0e; Thu, 19 Sep 2019 02:33:59 +0000 Received: from [10.28.19.63] (10.28.19.63) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Thu, 19 Sep 2019 10:34:49 +0800 Subject: Re: [PATCH 2/3] dt-bindings: reset: add bindings for the Meson-A1 SoC Reset Controller To: Neil Armstrong , Philipp Zabel , Kevin Hilman References: <1568808746-1153-1-git-send-email-xingyu.chen@amlogic.com> <1568808746-1153-3-git-send-email-xingyu.chen@amlogic.com> From: Xingyu Chen Message-ID: Date: Thu, 19 Sep 2019 10:34:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [10.28.19.63] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190918_193358_058154_D5117B86 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Hanjie Lin , Jianxin Pan , linux-kernel@vger.kernel.org, Rob Herring , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, Neil Thanks for your review On 2019/9/18 20:39, Neil Armstrong wrote: > Hi, > > On 18/09/2019 14:12, Xingyu Chen wrote: >> Add DT bindings for the Meson-A1 SoC Reset Controller include file, >> and also slightly update documentation. >> >> Signed-off-by: Xingyu Chen >> Signed-off-by: Jianxin Pan >> --- >> .../bindings/reset/amlogic,meson-reset.txt | 4 +- > > The reset bindings has been moved to yaml, either rebase on linux-next or wait for v5.4-rc1 : > https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next/+/refs/tags/next-20190917/Documentation/devicetree/bindings/reset/amlogic%2Cmeson-reset.yaml > > NeilI will fix it in next version. > >> include/dt-bindings/reset/amlogic,meson-a1-reset.h | 59 ++++++++++++++++++++++ >> 2 files changed, 61 insertions(+), 2 deletions(-) >> create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-reset.h >> >> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt >> index 28ef6c2..011151a 100644 >> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt >> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.txt >> @@ -5,8 +5,8 @@ Please also refer to reset.txt in this directory for common reset >> controller binding usage. >> >> Required properties: >> -- compatible: Should be "amlogic,meson8b-reset", "amlogic,meson-gxbb-reset" or >> - "amlogic,meson-axg-reset". >> +- compatible: Should be "amlogic,meson8b-reset", "amlogic,meson-gxbb-reset", >> + "amlogic,meson-axg-reset" or "amlogic,meson-a1-reset". >> - reg: should contain the register address base >> - #reset-cells: 1, see below >> >> diff --git a/include/dt-bindings/reset/amlogic,meson-a1-reset.h b/include/dt-bindings/reset/amlogic,meson-a1-reset.h >> new file mode 100644 >> index 00000000..8d76a47 >> --- /dev/null >> +++ b/include/dt-bindings/reset/amlogic,meson-a1-reset.h >> @@ -0,0 +1,59 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + * >> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. >> + * Author: Xingyu Chen >> + * >> + */ >> + >> +#ifndef _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H >> +#define _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H >> + >> +/* RESET0 */ >> +#define RESET_AM2AXI_VAD 1 >> +#define RESET_PSRAM 4 >> +#define RESET_PAD_CTRL 5 >> +#define RESET_TEMP_SENSOR 7 >> +#define RESET_AM2AXI_DEV 8 >> +#define RESET_SPICC_A 10 >> +#define RESET_MSR_CLK 11 >> +#define RESET_AUDIO 12 >> +#define RESET_ANALOG_CTRL 13 >> +#define RESET_SAR_ADC 14 >> +#define RESET_AUDIO_VAD 15 >> +#define RESET_CEC 16 >> +#define RESET_PWM_EF 17 >> +#define RESET_PWM_CD 18 >> +#define RESET_PWM_AB 19 >> +#define RESET_IR_CTRL 21 >> +#define RESET_I2C_S_A 22 >> +#define RESET_I2C_M_D 24 >> +#define RESET_I2C_M_C 25 >> +#define RESET_I2C_M_B 26 >> +#define RESET_I2C_M_A 27 >> +#define RESET_I2C_PROD_AHB 28 >> +#define RESET_I2C_PROD 29 >> + >> +/* RESET1 */ >> +#define RESET_ACODEC 32 >> +#define RESET_DMA 33 >> +#define RESET_SD_EMMC_A 34 >> +#define RESET_USBCTRL 36 >> +#define RESET_USBPHY 38 >> +#define RESET_RSA 42 >> +#define RESET_DMC 43 >> +#define RESET_IRQ_CTRL 45 >> +#define RESET_NIC_VAD 47 >> +#define RESET_NIC_AXI 48 >> +#define RESET_RAMA 49 >> +#define RESET_RAMB 50 >> +#define RESET_ROM 53 >> +#define RESET_SPIFC 54 >> +#define RESET_GIC 55 >> +#define RESET_UART_C 56 >> +#define RESET_UART_B 57 >> +#define RESET_UART_A 58 >> +#define RESET_OSC_RING 59 >> + >> +/* RESET2 Reserved */ >> + >> +#endif >> > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic