From: Neil Armstrong <narmstrong@baylibre.com>
To: Maxime Jourdan <mjourdan@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: media: amlogic,vdec: add default compatible
Date: Mon, 29 Jul 2019 15:06:02 +0200 [thread overview]
Message-ID: <b82bd2b5-9192-5ce8-eb97-8bde44c2d363@baylibre.com> (raw)
In-Reply-To: <20190726124639.7713-2-mjourdan@baylibre.com>
On 26/07/2019 14:46, Maxime Jourdan wrote:
> The first version of the bindings is missing a generic compatible that
> is used by the base node (GX), and then extended by the SoC device trees
> (GXBB, GXL, GXM)
>
> Also change the example to use "video-codec" instead of "video-decoder",
> as the former is the one used in almost all cases when it comes to video
> decode/encode accelerators.
>
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> ---
> Documentation/devicetree/bindings/media/amlogic,vdec.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/amlogic,vdec.txt b/Documentation/devicetree/bindings/media/amlogic,vdec.txt
> index aabdd01bcf32..9b6aace86ca7 100644
> --- a/Documentation/devicetree/bindings/media/amlogic,vdec.txt
> +++ b/Documentation/devicetree/bindings/media/amlogic,vdec.txt
> @@ -26,6 +26,7 @@ Required properties:
> - GXBB (S905) : "amlogic,gxbb-vdec"
> - GXL (S905X, S905D) : "amlogic,gxl-vdec"
> - GXM (S912) : "amlogic,gxm-vdec"
> + followed by the common "amlogic,gx-vdec"
> - reg: base address and size of he following memory-mapped regions :
> - dos
> - esparser
> @@ -47,8 +48,8 @@ Required properties:
>
> Example:
>
> -vdec: video-decoder@c8820000 {
> - compatible = "amlogic,gxbb-vdec";
> +vdec: video-codec@c8820000 {
> + compatible = "amlogic,gxbb-vdec", "amlogic,gx-vdec";
> reg = <0x0 0xc8820000 0x0 0x10000>,
> <0x0 0xc110a580 0x0 0xe4>;
> reg-names = "dos", "esparser";
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-07-29 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 12:46 [PATCH 0/3] arm64: dts: meson: add the video decoder nodes Maxime Jourdan
2019-07-26 12:46 ` [PATCH 1/3] dt-bindings: media: amlogic,vdec: add default compatible Maxime Jourdan
2019-07-29 13:06 ` Neil Armstrong [this message]
2019-07-26 12:46 ` [PATCH 2/3] arm64: dts: meson-gx: add video decoder entry Maxime Jourdan
2019-07-29 13:05 ` Neil Armstrong
2019-07-26 12:46 ` [PATCH 3/3] arm64: dts: meson: add video decoder entries Maxime Jourdan
2019-07-29 13:05 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b82bd2b5-9192-5ce8-eb97-8bde44c2d363@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjourdan@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).