From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, khilman@baylibre.com
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: dts: meson8b: odroidc1: add the GPIO line names
Date: Tue, 21 May 2019 10:38:51 +0200 [thread overview]
Message-ID: <b9e45b82-5ba9-ad0a-35ba-6bccdd0bc8ce@baylibre.com> (raw)
In-Reply-To: <20190328204721.25970-2-martin.blumenstingl@googlemail.com>
On 28/03/2019 21:47, Martin Blumenstingl wrote:
> This adds the GPIO line names from the schematics to get them displayed
> in the debugfs output of each GPIO controller.
>
> The schematics from Odroid-C1+ PCB revision 0.4 20150615 are used as
> referenced.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/meson8b-odroidc1.dts | 52 ++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index 3b0e0f8fbc23..0157646e3a89 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -234,7 +234,59 @@
> };
> };
>
> +&gpio {
> + gpio-line-names = /* Bank GPIOX */
> + "J2 Header Pin 35", "J2 Header Pin 36",
> + "J2 Header Pin 32", "J2 Header Pin 31",
> + "J2 Header Pin 29", "J2 Header Pin 18",
> + "J2 Header Pin 22", "J2 Header Pin 16",
> + "J2 Header Pin 23", "J2 Header Pin 21",
> + "J2 Header Pin 19", "J2 Header Pin 33",
> + "J2 Header Pin 8", "J2 Header Pin 10",
> + "J2 Header Pin 15", "J2 Header Pin 13",
> + "J2 Header Pin 24", "J2 Header Pin 26",
> + /* Bank GPIOY */
> + "Revision (upper)", "Revision (lower)",
> + "J2 Header Pin 7", "", "J2 Header Pin 12",
> + "J2 Header Pin 11", "", "", "",
> + "TFLASH_VDD_EN", "", "",
> + /* Bank GPIODV */
> + "VCCK_PWM (PWM_C)", "I2CA_SDA", "I2CA_SCL",
> + "I2CB_SDA", "I2CB_SCL", "VDDEE_PWM (PWM_D)",
> + "",
> + /* Bank GPIOH */
> + "HDMI_HPD", "HDMI_I2C_SDA", "HDMI_I2C_SCL",
> + "ETH_PHY_INTR", "ETH_PHY_NRST", "ETH_TXD1",
> + "ETH_TXD0", "ETH_TXD3", "ETH_TXD2",
> + "ETH_RGMII_TX_CLK",
> + /* Bank CARD */
> + "SD_DATA1 (SDB_D1)", "SD_DATA0 (SDB_D0)",
> + "SD_CLK", "SD_CMD", "SD_DATA3 (SDB_D3)",
> + "SD_DATA2 (SDB_D2)", "SD_CDN (SD_DET_N)",
> + /* Bank BOOT */
> + "SDC_D0 (EMMC)", "SDC_D1 (EMMC)",
> + "SDC_D2 (EMMC)", "SDC_D3 (EMMC)",
> + "SDC_D4 (EMMC)", "SDC_D5 (EMMC)",
> + "SDC_D6 (EMMC)", "SDC_D7 (EMMC)",
> + "SDC_CLK (EMMC)", "SDC_RSTn (EMMC)",
> + "SDC_CMD (EMMC)", "BOOT_SEL", "", "", "",
> + "", "", "", "",
> + /* Bank DIF */
> + "ETH_RXD1", "ETH_RXD0", "ETH_RX_DV",
> + "RGMII_RX_CLK", "ETH_RXD3", "ETH_RXD2",
> + "ETH_TXEN", "ETH_PHY_REF_CLK_25MOUT",
> + "ETH_MDC", "ETH_MDIO";
> +};
> +
> &gpio_ao {
> + gpio-line-names = "UART TX", "UART RX", "",
> + "TF_3V3N_1V8_EN", "USB_HUB_RST_N",
> + "USB_OTG_PWREN", "J7 Header Pin 2",
> + "IR_IN", "J7 Header Pin 4",
> + "J7 Header Pin 6", "J7 Header Pin 5",
> + "J7 Header Pin 7", "HDMI_CEC",
> + "SYS_LED", "", "";
> +
> /*
> * WARNING: The USB Hub on the Odroid-C1/C1+ needs a reset signal
> * to be turned high in order to be detected by the USB Controller.
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-05-21 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 20:47 [PATCH 0/1] gpio-line-names for Odroid-C1 Martin Blumenstingl
2019-03-28 20:47 ` [PATCH 1/1] ARM: dts: meson8b: odroidc1: add the GPIO line names Martin Blumenstingl
2019-05-21 8:38 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e45b82-5ba9-ad0a-35ba-6bccdd0bc8ce@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).