From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
thierry.reding@gmail.com, linux-pwm@vger.kernel.org,
linux-amlogic@lists.infradead.org
Cc: bichao.zheng@amlogic.com, u.kleine-koenig@pengutronix.de,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH 1/2] pwm: meson: consider 128 a valid pre-divider
Date: Wed, 3 Apr 2019 13:19:41 +0200 [thread overview]
Message-ID: <c8b6856c-3d2c-c59a-b3e6-5cfacc44d0e9@baylibre.com> (raw)
In-Reply-To: <20190401181817.11999-2-martin.blumenstingl@googlemail.com>
On 01/04/2019 20:18, Martin Blumenstingl wrote:
> The pre-divider allows configuring longer PWM periods compared to using
> the input clock directly. The pre-divider is 7 bit wide, meaning it's
> maximum value is 128 (the register value is off-by-one: 0x7f or 127).
>
> Change the loop to also allow for the maximum possible value to be
> considered valid.
>
> Fixes: 211ed630753d2f ("pwm: Add support for Meson PWM Controller")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pwm/pwm-meson.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index f6e738ad7bd9..4b708c1fcb1d 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -188,7 +188,7 @@ static int meson_pwm_calc(struct meson_pwm *meson,
> do_div(fin_ps, fin_freq);
>
> /* Calc pre_div with the period */
> - for (pre_div = 0; pre_div < MISC_CLK_DIV_MASK; pre_div++) {
> + for (pre_div = 0; pre_div <= MISC_CLK_DIV_MASK; pre_div++) {
> cnt = DIV_ROUND_CLOSEST_ULL((u64)period * 1000,
> fin_ps * (pre_div + 1));
> dev_dbg(meson->chip.dev, "fin_ps=%llu pre_div=%u cnt=%u\n",
> @@ -197,7 +197,7 @@ static int meson_pwm_calc(struct meson_pwm *meson,
> break;
> }
>
> - if (pre_div == MISC_CLK_DIV_MASK) {
> + if (pre_div > MISC_CLK_DIV_MASK) {
> dev_err(meson->chip.dev, "unable to get period pre_div\n");
> return -EINVAL;
> }
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-03 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 18:18 [PATCH 0/2] pwm: meson: two small bug-fixes Martin Blumenstingl
2019-04-01 18:18 ` [PATCH 1/2] pwm: meson: consider 128 a valid pre-divider Martin Blumenstingl
2019-04-01 18:38 ` Uwe Kleine-König
2019-04-02 19:22 ` Martin Blumenstingl
2019-04-02 19:55 ` Uwe Kleine-König
2019-04-03 11:19 ` Neil Armstrong [this message]
2019-04-01 18:18 ` [PATCH 2/2] pwm: meson: don't disable pwm when setting duty repeatedly Martin Blumenstingl
2019-04-03 11:19 ` Neil Armstrong
2019-05-09 14:52 ` [PATCH 0/2] pwm: meson: two small bug-fixes Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b6856c-3d2c-c59a-b3e6-5cfacc44d0e9@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=bichao.zheng@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).