From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F31C282C2 for ; Wed, 6 Feb 2019 19:41:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1D642080D for ; Wed, 6 Feb 2019 19:41:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oAyWTDfn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="hXdIP7ze" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1D642080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tP0pXFX/FEJeqI1RSQLSf3J1G6oYBOKDPiE4ZDLR+gE=; b=oAyWTDfns7icO8 D7WPMChaz6TeZGoxXnEswQsDNh4Zg8mgyMlSN9TMTW2VXy3k0eUEebMmuKE//2qFEiaIBhBnF73MB aS/6f6ZPbQ7rkPOxaEuBr66lfwt9LpN2zTrYiMUeTg88o90LgajO2aerOhq17QZTsW6Bp92bu/VEn kbQlCFI2mUosCCJrH+R8mMLgWmJNgSCKJ77qE6enDZYavnvKjqHKLNmk8b0c3U3nixHqrRGDTpuut no5hguqcKzdrP2fkfw8D0XTCIiSxmJzhCH9Bbp/bnWMotoqYoEgetTNj/AKekFUgcdvWvBBtFrvMq xJhFqXnYfj1uJIiXK7bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grT4e-0003Fs-5B; Wed, 06 Feb 2019 19:41:32 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1grT4O-00033y-Lk for linux-amlogic@lists.infradead.org; Wed, 06 Feb 2019 19:41:18 +0000 Received: by mail-wm1-x344.google.com with SMTP id m1so3746982wml.2 for ; Wed, 06 Feb 2019 11:41:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=g0SOurmC/1hWbZf3RZ1yC2YreX5i3l8fOWg+TNn51ec=; b=hXdIP7zevKZeWBzz3ovYsZWIBdRegy4rL2qvQiPcHj2V8xMubq0cJS6EPD8mF6KEHo JSKZeaTf9+1eopGEjEKN6xfhAZHErNQftS3CYOgYWkKr07Sy/B+Lv2e7tt8fuLWC+bd9 iQtEwkM50gjKcMhkqAAMvpsbt0jiIsvkXR7mYew+IgR4xK3R+3a4jM3Nmp0dNNh5ALV5 ZO8JUePCLLutzpAZC9jBnYUz7BwsGBB5Hv9CPNo+rU3YJM4YJZH9VRlybkFz5g3ko2rl GpQZwaDh6gTpqOZPDcf3vIOEoK6LHUghFNaOtSTt+wQJhZEZ7M60ua+9rmV6FsSuApow pmHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=g0SOurmC/1hWbZf3RZ1yC2YreX5i3l8fOWg+TNn51ec=; b=KvlvCl1r+secOEJVUd2IAS/liAdTur5Jh4AIYSpQOESpdXr8ONKpoKNbZJ9kiUOcy9 XTQpZY4zmagef005zTi14s4KU2HkOsP1b91yREQ9+oEyzN7dnO3/xay13N5ILcS4laIC Z691Wq1k3glMzsYZqGO7T5T69P94prH4X62Ty84Z219X4rmkxMQSSu03qXUgTZeAwD+b gWIKa3Q9Cim7ZlnGkg+jg+EyTPCzbUrCvrTe9Iy4nT7MgrCipTTtvc7c5wM88qrt1Nlm ZSLfmFQoAd+umTIgybiiJKbf/j4ccLQ2L847bJJQpOLCwuOK+n3O0oMLezAT1IAvYSca DIvA== X-Gm-Message-State: AHQUAuahU5HSiBiLzXQsI1bYXxvxzLPdZG78ZHZRP9esamP9IbRu0cIc uNno1O22r8cVcYInFbW1ooiOMo2clanDSQ== X-Google-Smtp-Source: AHgI3IbjhHgL+IcQBXfpM0N+GBFZjy0aFHdVdvdM1NoE5c+Qs73KhTZXrl8Fc2MVpp5ufVYIzrOV9Q== X-Received: by 2002:a1c:a00f:: with SMTP id j15mr1104229wme.84.1549482074771; Wed, 06 Feb 2019 11:41:14 -0800 (PST) Received: from [192.168.1.62] (176-150-251-154.abo.bbox.fr. [176.150.251.154]) by smtp.gmail.com with ESMTPSA id a12sm29037322wrm.45.2019.02.06.11.41.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 11:41:14 -0800 (PST) Subject: Re: [PATCH 2/2] clk: meson: Add G12A AO Clock + Reset Controller To: Stephen Boyd , jbrunet@baylibre.com References: <20190204091331.9298-1-narmstrong@baylibre.com> <20190204091331.9298-3-narmstrong@baylibre.com> <154940510132.169292.12584338453129084603@swboyd.mtv.corp.google.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: Date: Wed, 6 Feb 2019 20:41:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <154940510132.169292.12584338453129084603@swboyd.mtv.corp.google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190206_114116_757261_9A576A79 X-CRM114-Status: GOOD ( 11.09 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, On 05/02/2019 23:18, Stephen Boyd wrote: > Quoting Neil Armstrong (2019-02-04 01:13:30) >> + * Register offsets from the data sheet must be multiplied by 4. >> + */ >> +#define AO_RTI_STATUS_REG3 0x0C >> +#define AO_RTI_PWR_CNTL_REG0 0x10 >> +#define AO_RTI_GEN_CNTL_REG0 0x40 >> +#define AO_CLK_GATE0 0x4c >> +#define AO_CLK_GATE0_SP 0x50 >> +#define AO_OSCIN_CNTL 0x58 >> +#define AO_CEC_CLK_CNTL_REG0 0x74 >> +#define AO_CEC_CLK_CNTL_REG1 0x78 >> +#define AO_SAR_CLK 0x90 >> +#define AO_RTC_ALT_CLK_CNTL0 0x94 >> +#define AO_RTC_ALT_CLK_CNTL1 0x98 >> + >> +#define AXG_AO_GATE(_name, _reg, _bit) \ >> +static struct clk_regmap g12a_aoclk_##_name = { \ >> + .data = &(struct clk_regmap_gate_data) { \ >> + .offset = (_reg), \ >> + .bit_idx = (_bit), \ >> + }, \ >> + .hw.init = &(struct clk_init_data) { \ >> + .name = "g12a_ao_" #_name, \ >> + .ops = &clk_regmap_gate_ops, \ >> + .parent_names = (const char *[]){ IN_PREFIX "mpeg-clk" }, \ >> + .num_parents = 1, \ >> + .flags = CLK_IGNORE_UNUSED, \ > > Can you please add a comment explaining why CLK_IGNORE_UNUSED is here? > It will help future readers know what's going on with this special flag. > Sure, I'll add it. Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic