From: Neil Armstrong <narmstrong@baylibre.com>
To: zhengbin <zhengbin13@huawei.com>,
airlied@linux.ie, daniel@ffwll.ch, khilman@baylibre.com,
linux-amlogic@lists.infradead.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: meson: Remove unneeded semicolon
Date: Mon, 6 Jan 2020 15:56:30 +0100 [thread overview]
Message-ID: <cbc6f0b7-7245-1010-f9d5-5e539c4c0b99@baylibre.com> (raw)
In-Reply-To: <1576468701-69717-1-git-send-email-zhengbin13@huawei.com>
On 16/12/2019 04:58, zhengbin wrote:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/meson/meson_crtc.c:360:3-4: Unneeded semicolon
> drivers/gpu/drm/meson/meson_plane.c:181:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/gpu/drm/meson/meson_crtc.c | 2 +-
> drivers/gpu/drm/meson/meson_plane.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_crtc.c b/drivers/gpu/drm/meson/meson_crtc.c
> index 57ae1c1..eefefc4 100644
> --- a/drivers/gpu/drm/meson/meson_crtc.c
> +++ b/drivers/gpu/drm/meson/meson_crtc.c
> @@ -357,7 +357,7 @@ void meson_crtc_irq(struct meson_drm *priv)
> MESON_CANVAS_WRAP_NONE,
> MESON_CANVAS_BLKMODE_LINEAR,
> MESON_CANVAS_ENDIAN_SWAP64);
> - };
> + }
>
> writel_relaxed(priv->viu.vd1_if0_gen_reg,
> priv->io_base + meson_crtc->viu_offset +
> diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c
> index ed54322..b96fa43 100644
> --- a/drivers/gpu/drm/meson/meson_plane.c
> +++ b/drivers/gpu/drm/meson/meson_plane.c
> @@ -178,7 +178,7 @@ static void meson_plane_atomic_update(struct drm_plane *plane,
> priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 |
> OSD_COLOR_MATRIX_16_RGB565;
> break;
> - };
> + }
>
> /* Default scaler parameters */
> vsc_bot_rcv_num = 0;
> --
> 2.7.4
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
and applied to drm-misc-next
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-01-06 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 3:58 [PATCH] drm: meson: Remove unneeded semicolon zhengbin
2020-01-06 14:56 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc6f0b7-7245-1010-f9d5-5e539c4c0b99@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).