From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BBAFC0650F for ; Mon, 5 Aug 2019 09:41:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DEB42182B for ; Mon, 5 Aug 2019 09:41:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YgY1kZ4N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="uemqmpa5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DEB42182B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hZd7R1HtP++GOe34rgxuGgaK5htIguiBIX+pTYyFtdc=; b=YgY1kZ4NRyziyT EyqhwEiuhjvaLE+jQfb2sJ0vo6AJqV+WhMCYc/aqvqq2oksfGG1B0v3V6arhq6lVUR0C6MMd00i2y tnau8u2Xmytq4ZzHb7BYchtzO6SJ0pOL4LJsn6QwwCxhk+ISnzUgh/ZgClCZbT1TgmABFCn/RqjEO ++d9Rkw4sNP1bGmqo/0Gizc2CR8GZym2o7+hAsh3MFr3jgKl7uRammTUswmRP1DlkAXLRdhI+/hRt UvOSV0n3s38gYnb1IllF2vyawmE0GxAeg4n4tLD8BuciqQweER1GmeJXeVwpxcQYHb8zR47l6VBru Sq2SXQ2bO24oBPHmaOrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huZUx-0004jO-Dl; Mon, 05 Aug 2019 09:41:47 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huZUu-0004iI-4L for linux-amlogic@lists.infradead.org; Mon, 05 Aug 2019 09:41:45 +0000 Received: by mail-wm1-x341.google.com with SMTP id u25so61966606wmc.4 for ; Mon, 05 Aug 2019 02:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zwVFHt+48HDHPxY5b54ZFa7xoeFEjvHa3khRmzD7FKU=; b=uemqmpa5kVFXiavwLe6yqYrDmEZZV7Fcfsv21+JFTYqvKAtB5dvFEWIr4grJOpmSRp denJH6xQUZDRMwrqyhoKWcKx0lvzboWIwlSDmy82BgpPOXrpCKAxdpqxVSKSRipCOh7s pqGeT1q/7andPM62LzouFLClYDxeAW+3CDCE5wWZakpPw1H0n1TCp398yGA/dFMJ2T0S I3uOcmxbIsoZudjPF9sJzz8l55xuAM7Wb6TgrxVG7WuwkXdtusMHMerDRBUXnVZpPVOA RCE8ecEsdXVrfBZech4vOgi8/sgNY60ua7JQ/cuqCB0kbeyI2qT2Z5HQrvdQndmit9Mq 2diA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zwVFHt+48HDHPxY5b54ZFa7xoeFEjvHa3khRmzD7FKU=; b=evWK4DDmSEljDsllLSw6XGz6cz6iK9TIaAz8SiyNcbeTNyU2D+FvQlM68DlwzvrZag T99l4hbqB0+Ge7KoYXQSwsyDYhL3U3elfmI8mWPSqULUAT274qpFd/nEHS8qNcgRzdPr MND2lVb3B/VNot2DT3GnGnY505L415JHKzLRFjqKBSbr5XdcwaYahkK3Es/sQyv2Ej34 v3Iju2OtrLdp6sIJLunCK0C+bduPZ1oaQNMYEJ5iOjs3XqFmxfgG7a++OtZdOBS/vhi3 Xr1eez+AzpHM9InFf+xUFGSBTuS1wvPEZsaineL4uVLlu3XJtzXBvkv/0hRceyE9+qTn XNtQ== X-Gm-Message-State: APjAAAVoSq+gc8A8evqfwwk3F4VzDQDKKU0NVqs4QBlUL/x8crf4uHZ+ Q3fsRtzX4xX9FHv8n31rEdEjSQ== X-Google-Smtp-Source: APXvYqxUqLSyKoX3kBT5LqfmayHxL8IsZIurFOcWjSA/ZAELqlanwnjiTdxfqjeBVGrR1f0Qv4G6Aw== X-Received: by 2002:a1c:1a87:: with SMTP id a129mr17580112wma.21.1564998101244; Mon, 05 Aug 2019 02:41:41 -0700 (PDT) Received: from [10.1.4.98] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id a81sm90371174wmh.3.2019.08.05.02.41.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Aug 2019 02:41:40 -0700 (PDT) Subject: Re: [PATCH v2 3/6] arm64: dts: amlogic: g12: add temperature sensor To: Martin Blumenstingl References: <20190731153529.30159-1-glaroque@baylibre.com> <20190731153529.30159-4-glaroque@baylibre.com> From: guillaume La Roque Message-ID: Date: Mon, 5 Aug 2019 11:41:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_024144_275773_F26E02AC X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, khilman@baylibre.com, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org hi Martin, thanks for comments i will fix in v3. guillaume On 8/3/19 7:52 PM, Martin Blumenstingl wrote: > Hi Guillaume, > > On Wed, Jul 31, 2019 at 5:36 PM Guillaume La Roque > wrote: >> Add cpu and ddr temperature sensors for G12 Socs >> >> Signed-off-by: Guillaume La Roque > with the nit-pick below addressed: > Reviewed-by: Martin Blumenstingl > >> --- >> .../boot/dts/amlogic/meson-g12-common.dtsi | 22 +++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> index 06e186ca41e3..7f862a3490fb 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> @@ -1353,6 +1353,28 @@ >> }; >> }; >> >> + cpu_temp: temperature-sensor@34800 { >> + compatible = "amlogic,g12-cpu-thermal", >> + "amlogic,g12-thermal"; >> + reg = <0x0 0x34800 0x0 0x50>; >> + interrupts = ; >> + clocks = <&clkc CLKID_TS>; >> + status = "okay"; > I believe nodes are enabled automatically if they don't have a status property > >> + #thermal-sensor-cells = <0>; >> + amlogic,ao-secure = <&sec_AO>; >> + }; >> + >> + ddr_temp: temperature-sensor@34c00 { >> + compatible = "amlogic,g12-ddr-thermal", >> + "amlogic,g12-thermal"; >> + reg = <0x0 0x34c00 0x0 0x50>; >> + interrupts = ; >> + clocks = <&clkc CLKID_TS>; >> + status = "okay"; > same here > > > Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic