From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5893C433DF for ; Fri, 15 May 2020 08:05:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73CF8206F4 for ; Fri, 15 May 2020 08:05:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="abiicabN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="E+cClAx4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73CF8206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TfejJDVk5LRB1+70Q75rIUtvnmUX/1JNlvyh030EFBk=; b=abiicabNErrg9i MT0lcBOoFvGPEik7ijT+JEA0xSBzi5gPC2zPF4K4RWT8T7xxp/oroVn/Xv9KHOPgdgs9uQBqara8a pRbMghRo7MWB2gd1iT4atPp2de5YdfrYfWtLQZo1YFtGdZjIqlj0r4MyyIEPtP9mKYJGNWewX0iJZ bDr4ejMuB+p+EZrMPR2adpUy4W003GC5G0+Ny4/eMcpzkDo1UTdOT5iKbRJFoXGOi2vabGQIarQay 1R2u9GvGrZJxtiumEqiYMRlELX0+esHeu8f4yhPju1f9aDnUoPE0UoaTu6GFJTHl8LY4LThbv8vZn +7mbZTeoz9sz2lrngVeg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZVLM-0006Wz-Om; Fri, 15 May 2020 08:05:20 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZVLC-0005aW-3F for linux-amlogic@lists.infradead.org; Fri, 15 May 2020 08:05:12 +0000 Received: by mail-wr1-x442.google.com with SMTP id e1so2409524wrt.5 for ; Fri, 15 May 2020 01:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ka+cKcLR8lJuV8gjRpPRMdYz++ooxArfAv0RBTCP7c8=; b=E+cClAx4sR8jeE9o7QyTEEyqr/+l3AJPGM97foILCtra6xaHJjbxjJ/Fl2Or4K5P7e MV68NNcg4v4C2hV5PPJJlL0f65nB8+7EJZIc1R+5dpoolc7oqKB28Rt0SdaZc6ZK48r1 op3yiUq4uM5ePUBocuL7nmHPaVdkO/JDYb4mb37pY5nHQE6a1WjLtbNte7BVy4YLFoJR 75UctLb6YmivwKHPQ5JiJhJrsvmnQiBhkMJhfMCjbgRhTgAETrqAUFSa9h9u8Qz4yawD BHWIHd1LLxLZFR2vbf2ZGsZHoFMCwBYEHaSLqq3wVpTlOOVGp3Md5JFKXeBCDfAOih8O 7/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ka+cKcLR8lJuV8gjRpPRMdYz++ooxArfAv0RBTCP7c8=; b=cdt4NjW7Dn+1Th0eQCORP8+Eju5zYlSIAiRFUCepEgvryAOYu421SyKPAOr5Qks5OT IpmCbfik9DpJOXXCvjpR+8MuBf1ze3brFQew7+8PPCZIih9OnybD8G0vXRXytgquVLy8 k9iDhl5rfkO6t4UoqHnzAnJ41ps5cvpfb2VfgDYbC2uDLxmfxxMf4VbHoqsrd8bYZToB ED2+B2brlwbZINaSLXCJiUNucNPxQzvx2V2m96QaUa4MrjPiB6Mte1qCJYrHRkVThUgn X++WIfjNYGtoUuBzlAHg0sO0MY5yaTaSeunpMbHlfROkGm0NuBk5Zb0UXB2QBnVhXhvP jBUg== X-Gm-Message-State: AOAM5328FE2WfkTGUpbfdzQpKMyiB2d+Qrr3tnA7gbnjaUy9y2m0ELJp +5VUxDmVTHpAkprT9gBfWHds1A== X-Google-Smtp-Source: ABdhPJwf0AkQnlDmnyxvqVQc2yzAgAQDxwbcUdvMzQqCQmiukwzD12WG7bLyOIJ58+AHo9yGLJlJXA== X-Received: by 2002:a5d:4006:: with SMTP id n6mr2890572wrp.27.1589529907976; Fri, 15 May 2020 01:05:07 -0700 (PDT) Received: from ?IPv6:2a01:e35:2ec0:82b0:4460:3fd3:382:4a71? ([2a01:e35:2ec0:82b0:4460:3fd3:382:4a71]) by smtp.gmail.com with ESMTPSA id c80sm2513852wme.15.2020.05.15.01.05.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2020 01:05:07 -0700 (PDT) Subject: Re: [PATCH v2 3/6] thermal: add support for the MCU controlled FAN on Khadas boards To: Amit Kucheria References: <20200512132613.31507-1-narmstrong@baylibre.com> <20200512132613.31507-4-narmstrong@baylibre.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwU0EVid/pAEQAND7AFhr 5faf/EhDP9FSgYd/zgmb7JOpFPje3uw7jz9wFb28Cf0Y3CcncdElYoBNbRlesKvjQRL8mozV 9RN+IUMHdUx1akR/A4BPXNdL7StfzKWOCxZHVS+rIQ/fE3Qz/jRmT6t2ZkpplLxVBpdu95qJ YwSZjuwFXdC+A7MHtQXYi3UfCgKiflj4+/ITcKC6EF32KrmIRqamQwiRsDcUUKlAUjkCLcHL CQvNsDdm2cxdHxC32AVm3Je8VCsH7/qEPMQ+cEZk47HOR3+Ihfn1LEG5LfwsyWE8/JxsU2a1 q44LQM2lcK/0AKAL20XDd7ERH/FCBKkNVzi+svYJpyvCZCnWT0TRb72mT+XxLWNwfHTeGALE +1As4jIS72IglvbtONxc2OIid3tR5rX3k2V0iud0P7Hnz/JTdfvSpVj55ZurOl2XAXUpGbq5 XRk5CESFuLQV8oqCxgWAEgFyEapI4GwJsvfl/2Er8kLoucYO1Id4mz6N33+omPhaoXfHyLSy dxD+CzNJqN2GdavGtobdvv/2V0wukqj86iKF8toLG2/Fia3DxMaGUxqI7GMOuiGZjXPt/et/ qeOySghdQ7Sdpu6fWc8CJXV2mOV6DrSzc6ZVB4SmvdoruBHWWOR6YnMz01ShFE49pPucyU1h Av4jC62El3pdCrDOnWNFMYbbon3vABEBAAHCwn4EGAECAAkFAlYnf6QCGwICKQkQFpq3saTP +K7BXSAEGQECAAYFAlYnf6QACgkQd9zb2sjISdGToxAAkOjSfGxp0ulgHboUAtmxaU3viucV e2Hl1BVDtKSKmbIVZmEUvx9D06IijFaEzqtKD34LXD6fjl4HIyDZvwfeaZCbJbO10j3k7FJE QrBtpdVqkJxme/nYlGOVzcOiKIepNkwvnHVnuVDVPcXyj2wqtsU7VZDDX41z3X4xTQwY3SO1 9nRO+f+i4RmtJcITgregMa2PcB0LvrjJlWroI+KAKCzoTHzSTpCXMJ1U/dEqyc87bFBdc+DI k8mWkPxsccdbs4t+hH0NoE3Kal9xtAl56RCtO/KgBLAQ5M8oToJVatxAjO1SnRYVN1EaAwrR xkHdd97qw6nbg9BMcAoa2NMc0/9MeiaQfbgW6b0reIz/haHhXZ6oYSCl15Knkr4t1o3I2Bqr Mw623gdiTzotgtId8VfLB2Vsatj35OqIn5lVbi2ua6I0gkI6S7xJhqeyrfhDNgzTHdQVHB9/ 7jnM0ERXNy1Ket6aDWZWCvM59dTyu37g3VvYzGis8XzrX1oLBU/tTXqo1IFqqIAmvh7lI0Se gCrXz7UanxCwUbQBFjzGn6pooEHJYRLuVGLdBuoApl/I4dLqCZij2AGa4CFzrn9W0cwm3HCO lR43gFyz0dSkMwNUd195FrvfAz7Bjmmi19DnORKnQmlvGe/9xEEfr5zjey1N9+mt3//geDP6 clwKBkq0JggA+RTEAELzkgPYKJ3NutoStUAKZGiLOFMpHY6KpItbbHjF2ZKIU1whaRYkHpB2 uLQXOzZ0d7x60PUdhqG3VmFnzXSztA4vsnDKk7x2xw0pMSTKhMafpxaPQJf494/jGnwBHyi3 h3QGG1RjfhQ/OMTX/HKtAUB2ct3Q8/jBfF0hS5GzT6dYtj0Ci7+8LUsB2VoayhNXMnaBfh+Q pAhaFfRZWTjUFIV4MpDdFDame7PB50s73gF/pfQbjw5Wxtes/0FnqydfId95s+eej+17ldGp lMv1ok7K0H/WJSdr7UwDAHEYU++p4RRTJP6DHWXcByVlpNQ4SSAiivmWiwOt490+Ac7ATQRN WQbPAQgAvIoM384ZRFocFXPCOBir5m2J+96R2tI2XxMgMfyDXGJwFilBNs+fpttJlt2995A8 0JwPj8SFdm6FBcxygmxBBCc7i/BVQuY8aC0Z/w9Vzt3Eo561r6pSHr5JGHe8hwBQUcNPd/9l 2ynP57YTSE9XaGJK8gIuTXWo7pzIkTXfN40Wh5jeCCspj4jNsWiYhljjIbrEj300g8RUT2U0 FcEoiV7AjJWWQ5pi8lZJX6nmB0lc69Jw03V6mblgeZ/1oTZmOepkagwy2zLDXxihf0GowUif GphBDeP8elWBNK+ajl5rmpAMNRoKxpN/xR4NzBg62AjyIvigdywa1RehSTfccQARAQABwsBf BBgBAgAJBQJNWQbPAhsMAAoJEBaat7Gkz/iuteIH+wZuRDqK0ysAh+czshtG6JJlLW6eXJJR Vi7dIPpgFic2LcbkSlvB8E25Pcfz/+tW+04Urg4PxxFiTFdFCZO+prfd4Mge7/OvUcwoSub7 ZIPo8726ZF5/xXzajahoIu9/hZ4iywWPAHRvprXaim5E/vKjcTeBMJIqZtS4u/UK3EpAX59R XVxVpM8zJPbk535ELUr6I5HQXnihQm8l6rt9TNuf8p2WEDxc8bPAZHLjNyw9a/CdeB97m2Tr zR8QplXA5kogS4kLe/7/JmlDMO8Zgm9vKLHSUeesLOrjdZ59EcjldNNBszRZQgEhwaarfz46 BSwxi7g3Mu7u5kUByanqHyA= Organization: Baylibre Message-ID: Date: Fri, 15 May 2020 10:05:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_010510_182051_11024FFC X-CRM114-Status: GOOD ( 20.13 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux PM list , Daniel Lezcano , LKML , Srini Kandagatla , linux-amlogic@lists.infradead.org, Zhang Rui , lakml Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 15/05/2020 08:41, Amit Kucheria wrote: > On Tue, May 12, 2020 at 6:56 PM Neil Armstrong wrote: >> >> The new Khadas VIM2 and VIM3 boards controls the cooling fan via the >> on-board microcontroller. >> >> This implements the FAN control as thermal devices and as cell of the Khadas >> MCU MFD driver. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/thermal/Kconfig | 10 ++ >> drivers/thermal/Makefile | 1 + >> drivers/thermal/khadas_mcu_fan.c | 174 +++++++++++++++++++++++++++++++ >> 3 files changed, 185 insertions(+) >> create mode 100644 drivers/thermal/khadas_mcu_fan.c >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index 91af271e9bb0..72b3960cc5ac 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -490,4 +490,14 @@ config SPRD_THERMAL >> help >> Support for the Spreadtrum thermal sensor driver in the Linux thermal >> framework. >> + >> +config KHADAS_MCU_FAN_THERMAL >> + tristate "Khadas MCU controller FAN cooling support" >> + depends on OF || COMPILE_TEST > > Could you add a depends on the some board/SoC Kconfig option here so > this doesn't show up for non-Amlogic/non-Khadas boards? Sure, Thanks. Neil > > Looks OK otherwise. > >> + select MFD_CORE >> + select REGMAP >> + help >> + If you say yes here you get support for the FAN controlled >> + by the Microcontroller found on the Khadas VIM boards. >> + >> endif >> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile >> index 8c8ed7b79915..460428c2122c 100644 >> --- a/drivers/thermal/Makefile >> +++ b/drivers/thermal/Makefile >> @@ -60,3 +60,4 @@ obj-$(CONFIG_ZX2967_THERMAL) += zx2967_thermal.o >> obj-$(CONFIG_UNIPHIER_THERMAL) += uniphier_thermal.o >> obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o >> obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o >> +obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o >> diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c >> new file mode 100644 >> index 000000000000..044d4aba8be2 >> --- /dev/null >> +++ b/drivers/thermal/khadas_mcu_fan.c >> @@ -0,0 +1,174 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later >> +/* >> + * Khadas MCU Controlled FAN driver >> + * >> + * Copyright (C) 2020 BayLibre SAS >> + * Author(s): Neil Armstrong >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#define MAX_LEVEL 3 >> + >> +struct khadas_mcu_fan_ctx { >> + struct khadas_mcu *mcu; >> + unsigned int level; >> + struct thermal_cooling_device *cdev; >> +}; >> + >> +static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, >> + unsigned int level) >> +{ >> + int ret; >> + >> + ret = regmap_write(ctx->mcu->map, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG, >> + level); >> + if (ret) >> + return ret; >> + >> + ctx->level = level; >> + >> + return 0; >> +} >> + >> +static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev, >> + unsigned long *state) >> +{ >> + struct khadas_mcu_fan_ctx *ctx = cdev->devdata; >> + >> + if (!ctx) >> + return -EINVAL; >> + >> + *state = MAX_LEVEL; >> + >> + return 0; >> +} >> + >> +static int khadas_mcu_fan_get_cur_state(struct thermal_cooling_device *cdev, >> + unsigned long *state) >> +{ >> + struct khadas_mcu_fan_ctx *ctx = cdev->devdata; >> + >> + if (!ctx) >> + return -EINVAL; >> + >> + *state = ctx->level; >> + >> + return 0; >> +} >> + >> +static int >> +khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev, >> + unsigned long state) >> +{ >> + struct khadas_mcu_fan_ctx *ctx = cdev->devdata; >> + >> + if (!ctx || (state > MAX_LEVEL)) >> + return -EINVAL; >> + >> + if (state == ctx->level) >> + return 0; >> + >> + return khadas_mcu_fan_set_level(ctx, state); >> +} >> + >> +static const struct thermal_cooling_device_ops khadas_mcu_fan_cooling_ops = { >> + .get_max_state = khadas_mcu_fan_get_max_state, >> + .get_cur_state = khadas_mcu_fan_get_cur_state, >> + .set_cur_state = khadas_mcu_fan_set_cur_state, >> +}; >> + >> +static int khadas_mcu_fan_probe(struct platform_device *pdev) >> +{ >> + struct khadas_mcu *mcu = dev_get_drvdata(pdev->dev.parent); >> + struct thermal_cooling_device *cdev; >> + struct device *dev = &pdev->dev; >> + struct khadas_mcu_fan_ctx *ctx; >> + int ret; >> + >> + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); >> + if (!ctx) >> + return -ENOMEM; >> + ctx->mcu = mcu; >> + platform_set_drvdata(pdev, ctx); >> + >> + cdev = devm_thermal_of_cooling_device_register(dev->parent, >> + dev->parent->of_node, "khadas-mcu-fan", ctx, >> + &khadas_mcu_fan_cooling_ops); >> + if (IS_ERR(cdev)) { >> + ret = PTR_ERR(cdev); >> + dev_err(dev, >> + "Failed to register khadas-mcu-fan as cooling device: %d\n", >> + ret); >> + return ret; >> + } >> + ctx->cdev = cdev; >> + thermal_cdev_update(cdev); >> + >> + return 0; >> +} >> + >> +static int khadas_mcu_fan_disable(struct device *dev) >> +{ >> + struct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev); >> + unsigned int level_save = ctx->level; >> + int ret; >> + >> + ret = khadas_mcu_fan_set_level(ctx, 0); >> + if (ret) >> + return ret; >> + >> + ctx->level = level_save; >> + >> + return 0; >> +} >> + >> +static void khadas_mcu_fan_shutdown(struct platform_device *pdev) >> +{ >> + khadas_mcu_fan_disable(&pdev->dev); >> +} >> + >> +#ifdef CONFIG_PM_SLEEP >> +static int khadas_mcu_fan_suspend(struct device *dev) >> +{ >> + return khadas_mcu_fan_disable(dev); >> +} >> + >> +static int khadas_mcu_fan_resume(struct device *dev) >> +{ >> + struct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev); >> + >> + return khadas_mcu_fan_set_level(ctx, ctx->level); >> +} >> +#endif >> + >> +static SIMPLE_DEV_PM_OPS(khadas_mcu_fan_pm, khadas_mcu_fan_suspend, >> + khadas_mcu_fan_resume); >> + >> +static const struct platform_device_id khadas_mcu_fan_id_table[] = { >> + { .name = "khadas-mcu-fan-ctrl", }, >> + {}, >> +}; >> +MODULE_DEVICE_TABLE(platform, khadas_mcu_fan_id_table); >> + >> +static struct platform_driver khadas_mcu_fan_driver = { >> + .probe = khadas_mcu_fan_probe, >> + .shutdown = khadas_mcu_fan_shutdown, >> + .driver = { >> + .name = "khadas-mcu-fan-ctrl", >> + .pm = &khadas_mcu_fan_pm, >> + }, >> + .id_table = khadas_mcu_fan_id_table, >> +}; >> + >> +module_platform_driver(khadas_mcu_fan_driver); >> + >> +MODULE_AUTHOR("Neil Armstrong "); >> +MODULE_DESCRIPTION("Khadas MCU FAN driver"); >> +MODULE_LICENSE("GPL"); >> -- >> 2.22.0 >> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic