From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C650C33CA9 for ; Mon, 13 Jan 2020 01:13:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0160521744 for ; Mon, 13 Jan 2020 01:13:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IhDCgRAW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0160521744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aBt5yDZC0HUupw65OdPplrUvE8ivrEqLxGv2jMZHLQY=; b=IhDCgRAWMqeG3f FWFLw0ZCJ7aZwmxE8J9upq54lIvvARgHBr9GAP8SaNVxVrzz7n2gZmZYTx/Tzd09YOOULgDfmSGSE QLDB5JJXmyYMJD3kG6LIYwRoSabzzxB7OZ8KwpVswAkFP1PHkckjM1W8LMHJ0wR5uzKUDjQOgjZMY hs1Xz/l5mZuGWaejeKm+xornGEsFk8yOex5zdc8PNXuKo+wTFThVIEFwj677NvZETVQS/qbM/IQog RQHBPTLRVZqXF1TLp22zm1kf2R/WTB/v5Ew72auHlQxtZy0R3I7T1q66QTnTT5i5HHNY6F3i4Elb1 8vyTX3Y1lL3SIvLUueKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqoIV-0004oE-CV; Mon, 13 Jan 2020 01:13:39 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqoIR-0004nT-Q1; Mon, 13 Jan 2020 01:13:37 +0000 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Mon, 13 Jan 2020 09:13:52 +0800 Subject: Re: [PATCH v5 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Martin Blumenstingl References: <1578634957-54826-1-git-send-email-hanjie.lin@amlogic.com> <1578634957-54826-2-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: Date: Mon, 13 Jan 2020 09:13:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200112_171335_848112_BB152AD3 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2020/1/12 4:54, Martin Blumenstingl wrote: > Hi Hanjie, > > On Fri, Jan 10, 2020 at 6:43 AM Hanjie Lin wrote: >> >> Add the Amlogic A1 Family USB2 PHY Bindings >> >> It supports Host mode only. >> >> Signed-off-by: Hanjie Lin >> Signed-off-by: Yue Wang >> --- >> .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 62 ++++++++++++++++++++++ >> 1 file changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > there are only two differences to the existing > amlogic,meson-g12a-usb2-phy.yaml binding: > - different compatible string (the existing binding already has an > enum, so that would be easy to extend) > - new, mandatory power-domains property > (Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml > has examples how to make properties mandatory based on the compatible > string) > > have you considered merging this with the existing > amlogic,meson-g12a-usb2-phy.yaml binding? > this is not a "must have" in my opinion, I still want to hear your > opinion on this topic! > > > Martin > > . > Hi Martin, Thanks for your advice. Of course, it should looks much better to have merging this into the existing amlogic,meson-g12a-usb2-phy.yaml. I will try to do it by following the examples. thanks, Hanjie _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic