From: Neil Armstrong <narmstrong@baylibre.com>
To: Anand Moon <linux.amoon@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCHv1 1/3] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node
Date: Thu, 16 Jul 2020 09:08:12 +0200 [thread overview]
Message-ID: <de587578-9da5-cd1d-826a-ab83b7c3dcc1@baylibre.com> (raw)
In-Reply-To: <20200715160209.652-2-linux.amoon@gmail.com>
Hi,
On 15/07/2020 18:02, Anand Moon wrote:
> Enable RTC PCF8563 node on Odroid-N2 SBC, In order
> to support the RTC wakealarm feature for suspend and resume.
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> $ sudo hwclock -r && date
> 2020-07-15 13:11:53.862508+00:00
> Wed Jul 15 13:11:54 UTC 2020
>
> $ hwclock --show
> 2020-07-15 13:17:30.903300+00:00
>
> But RTC wake up is not working at my end.
> Any inputs are welcome.
>
> $ time rtcwake -s 30 -m mem
> rtcwake: /dev/rtc0 not enabled for wakeup events
>
> real 0m0.002s
> user 0m0.002s
> sys 0m0.000s
> ---
> .../boot/dts/amlogic/meson-g12b-odroid-n2.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 169ea283d4ee..a447cba4dd53 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint {
> };
> };
>
> +&i2c3 {
> + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + rtc: rtc@51 {
> + reg = <0x51>;
> + compatible = "nxp,pcf8563";
> + #clock-cells = <0>;
> + clock-frequency = <32768>;
> + clock-output-names = "rtc_clkout";
The clkout output is not used, so I don't think these 3 lines are needed.
> + };
> +};
> +
> &ir {
> status = "okay";
> pinctrl-0 = <&remote_input_ao_pins>;
>
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-07-16 7:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 16:02 [PATCHv1 0/3] Enable RTC on Odroid N2 Anand Moon
2020-07-15 16:02 ` [PATCHv1 1/3] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node Anand Moon
2020-07-16 7:08 ` Neil Armstrong [this message]
2020-07-16 8:02 ` Anand Moon
2020-07-16 8:08 ` Jerome Brunet
2020-07-16 9:12 ` Anand Moon
2020-07-15 16:02 ` [PATCHv1 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual wake RTC Anand Moon
2020-07-16 7:05 ` Neil Armstrong
2020-07-16 7:19 ` Anand Moon
2020-07-15 16:02 ` [PATCHv1 3/3] arm64: defconfig: Enable RTC devices for Amlogic boards Anand Moon
2020-07-16 7:08 ` Neil Armstrong
2020-07-16 7:05 ` [PATCHv1 0/3] Enable RTC on Odroid N2 Neil Armstrong
2020-07-16 8:14 ` Anand Moon
2020-07-16 8:20 ` Neil Armstrong
2020-07-16 8:35 ` Neil Armstrong
2020-07-16 15:42 ` Anand Moon
2020-07-16 21:28 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de587578-9da5-cd1d-826a-ab83b7c3dcc1@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).