From: Jerome Brunet <jbrunet@baylibre.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: David Brown <david.brown@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Motoya Tanigawa <tanigawa.motoya@socionext.com>,
linux-kernel@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v2 PATCH 4/4] phy: phy-meson-gxl-usb2: get optional clock by devm_clk_get_optional()
Date: Wed, 10 Apr 2019 10:18:47 +0200 [thread overview]
Message-ID: <ece510f7d393e4b04c920e88968e9bb41cde6b14.camel@baylibre.com> (raw)
In-Reply-To: <9f04a619e8a2cc44f5b1fe299a08f237f069d56d.1554874961.git.chunfeng.yun@mediatek.com>
On Wed, 2019-04-10 at 14:13 +0800, Chunfeng Yun wrote:
> Use devm_clk_get_optional() to get optional clock
>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> v2: add Acked-by Martin Blumenstingl
> ---
> drivers/phy/amlogic/phy-meson-gxl-usb2.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> index 148ef0bdb9c1..4cbee412f2b0 100644
> --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> @@ -261,14 +261,9 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
> if (IS_ERR(priv->regmap))
> return PTR_ERR(priv->regmap);
>
> - priv->clk = devm_clk_get(dev, "phy");
> - if (IS_ERR(priv->clk)) {
> - ret = PTR_ERR(priv->clk);
> - if (ret == -ENOENT)
> - priv->clk = NULL;
> - else
> - return ret;
> - }
> + priv->clk = devm_clk_get_optional(dev, "phy");
> + if (IS_ERR(priv->clk))
> + return PTR_ERR(priv->clk);
>
> priv->reset = devm_reset_control_get_optional_shared(dev, "phy");
> if (IS_ERR(priv->reset))
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-10 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 6:13 [v2 PATCH 1/4] phy: phy-mtk-tphy: get optional clock by devm_clk_get_optional() Chunfeng Yun
2019-04-10 6:13 ` [v2 PATCH 2/4] phy: qcom-qusb2: " Chunfeng Yun
2019-04-10 6:13 ` [v2 PATCH 3/4] phy: socionext: " Chunfeng Yun
2019-04-10 6:13 ` [v2 PATCH 4/4] phy: phy-meson-gxl-usb2: " Chunfeng Yun
2019-04-10 8:18 ` Jerome Brunet [this message]
2019-04-10 17:59 ` Martin Blumenstingl
2019-04-11 1:04 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ece510f7d393e4b04c920e88968e9bb41cde6b14.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=andy.gross@linaro.org \
--cc=chunfeng.yun@mediatek.com \
--cc=david.brown@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=masami.hiramatsu@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=tanigawa.motoya@socionext.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).