* [PATCH] staging: meson: add space to fix check warning
@ 2019-10-15 22:34 Jules Irenge
2019-10-16 12:21 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2019-10-15 22:34 UTC (permalink / raw)
To: outreachy-kernel
Cc: mjourdan, devel, Jules Irenge, gregkh, khilman, linux-amlogic,
mchehab, linux-media
Fix "alignment should mactch open parenthesis" check.
Issue detected by checkpatch tool
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/meson/vdec/codec_mpeg12.c b/drivers/staging/media/meson/vdec/codec_mpeg12.c
index 48869cc3d973..21e93a13356c 100644
--- a/drivers/staging/media/meson/vdec/codec_mpeg12.c
+++ b/drivers/staging/media/meson/vdec/codec_mpeg12.c
@@ -81,7 +81,7 @@ static int codec_mpeg12_start(struct amvdec_session *sess)
}
ret = amvdec_set_canvases(sess, (u32[]){ AV_SCRATCH_0, 0 },
- (u32[]){ 8, 0 });
+ (u32[]){ 8, 0 });
if (ret)
goto free_workspace;
--
2.21.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: meson: add space to fix check warning
2019-10-15 22:34 [PATCH] staging: meson: add space to fix check warning Jules Irenge
@ 2019-10-16 12:21 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2019-10-16 12:21 UTC (permalink / raw)
To: Jules Irenge, outreachy-kernel
Cc: mjourdan, devel, gregkh, khilman, linux-amlogic, mchehab, linux-media
On 10/16/19 12:34 AM, Jules Irenge wrote:
> Fix "alignment should mactch open parenthesis" check.
> Issue detected by checkpatch tool
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/media/meson/vdec/codec_mpeg12.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/meson/vdec/codec_mpeg12.c b/drivers/staging/media/meson/vdec/codec_mpeg12.c
> index 48869cc3d973..21e93a13356c 100644
> --- a/drivers/staging/media/meson/vdec/codec_mpeg12.c
> +++ b/drivers/staging/media/meson/vdec/codec_mpeg12.c
> @@ -81,7 +81,7 @@ static int codec_mpeg12_start(struct amvdec_session *sess)
> }
>
> ret = amvdec_set_canvases(sess, (u32[]){ AV_SCRATCH_0, 0 },
> - (u32[]){ 8, 0 });
This is clearly intended to be aligned with the (u32[]) prefix for readability.
So this is one checkpatch issue where I prefer to keep the original.
Regards,
Hans
> + (u32[]){ 8, 0 });
> if (ret)
> goto free_workspace;
>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-16 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 22:34 [PATCH] staging: meson: add space to fix check warning Jules Irenge
2019-10-16 12:21 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).