From: David Howells <dhowells@redhat.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
mtk.manpages@gmail.com
Subject: Re: [PATCH] uapi: remove false assertion that statx_timestamp.tv_nsec can be negative
Date: Wed, 26 Apr 2017 11:55:25 +0100 [thread overview]
Message-ID: <13744.1493204125@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170422192743.GA17005@altlinux.org>
Dmitry V. Levin <ldv@altlinux.org> wrote:
> remove false assertion
It's not a false assertion. I defined the statx interface that way.
> The best fix for this source of confusion is to change the type
> of struct statx_timestamp.tv_nsec from __s32 to __u32 .
Okay, if we're going to do the comment change, we should effect the type
change also. Do you want to update your patch?
David
next prev parent reply other threads:[~2017-04-26 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 19:27 [PATCH] uapi: remove false assertion that statx_timestamp.tv_nsec can be negative Dmitry V. Levin
2017-04-26 10:55 ` David Howells [this message]
[not found] ` <13744.1493204125-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-26 11:19 ` [PATCH v2] uapi: change the type of struct statx_timestamp.tv_nsec to unsigned Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13744.1493204125@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ldv@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).