From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alexander Duyck
<alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sridhar.samudrala-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [net-next PATCH v2 2/8] tcp: Record Rx hash and NAPI ID in tcp_child_process
Date: Thu, 23 Mar 2017 18:00:50 -0700 [thread overview]
Message-ID: <1490317250.9687.10.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20170323213644.12615.27158.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Thu, 2017-03-23 at 14:36 -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> While working on some recent busy poll changes we found that child sockets
> were being instantiated without NAPI ID being set. In our first attempt to
> fix it, it was suggested that we should just pull programming the NAPI ID
> into the function itself since all callers will need to have it set.
>
> In addition to the NAPI ID change I have dropped the code that was
> populating the Rx hash since it was actually being populated in
> tcp_get_cookie_sock.
>
> Reported-by: Sridhar Samudrala <sridhar.samudrala-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Suggested-by: Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Alexander Duyck <alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
Acked-by: Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2017-03-24 1:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 21:36 [net-next PATCH v2 0/8] Add busy poll support for epoll Alexander Duyck
[not found] ` <20170323211820.12615.88907.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-03-23 21:36 ` [net-next PATCH v2 1/8] net: Busy polling should ignore sender CPUs Alexander Duyck
2017-03-23 22:05 ` Eric Dumazet
2017-03-23 21:36 ` [net-next PATCH v2 2/8] tcp: Record Rx hash and NAPI ID in tcp_child_process Alexander Duyck
[not found] ` <20170323213644.12615.27158.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-03-24 1:00 ` Eric Dumazet [this message]
2017-03-23 21:36 ` [net-next PATCH v2 3/8] net: Only define skb_mark_napi_id in one spot instead of two Alexander Duyck
[not found] ` <20170323213651.12615.62895.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-03-24 1:02 ` Eric Dumazet
2017-03-23 21:37 ` [net-next PATCH v2 4/8] net: Change return type of sk_busy_loop from bool to void Alexander Duyck
[not found] ` <20170323213715.12615.49246.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-03-24 1:02 ` Eric Dumazet
2017-03-23 21:37 ` [net-next PATCH v2 5/8] net: Track start of busy loop instead of when it should end Alexander Duyck
2017-03-24 1:24 ` Eric Dumazet
2017-03-24 3:42 ` Alexander Duyck
[not found] ` <CAKgT0Ue+UFOAhwxN-EOjWYZa9YZc2QaT5gvoLap70COs0rF7NA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24 4:27 ` Eric Dumazet
2017-03-24 4:38 ` Eric Dumazet
2017-03-24 5:55 ` Alexander Duyck
[not found] ` <CAKgT0UfQPLqHtZ_SjanbLoG6t5f36C4nsORuw6yjLT0xZrEoEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24 11:16 ` Eric Dumazet
[not found] ` <1490354210.9687.44.camel-XN9IlZ5yJG9HTL0Zs8A6p+yfmBU6pStAUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2017-03-24 15:48 ` Alexander Duyck
2017-03-23 21:37 ` [net-next PATCH v2 6/8] net: Commonize busy polling code to focus on napi_id instead of socket Alexander Duyck
[not found] ` <20170323213749.12615.38165.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-03-23 22:25 ` Eric Dumazet
2017-03-23 21:37 ` [net-next PATCH v2 7/8] epoll: Add busy poll support to epoll with socket fds Alexander Duyck
2017-03-23 21:38 ` [net-next PATCH v2 8/8] net: Introduce SO_INCOMING_NAPI_ID Alexander Duyck
[not found] ` <20170323213802.12615.58216.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-03-23 22:22 ` Eric Dumazet
2017-03-23 22:43 ` Andy Lutomirski
2017-03-24 0:58 ` Alexander Duyck
[not found] ` <CAKgT0UcHJVycQ3+h09L2Ph=TVncqHPJ6dZpicUgBo7TaFTN7yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-24 4:47 ` Andy Lutomirski
2017-03-24 5:07 ` Eric Dumazet
2017-03-23 22:07 ` [net-next PATCH v2 0/8] Add busy poll support for epoll Alexei Starovoitov
[not found] ` <20170323220721.GA62356-+o4/htvd0TDFYCXBM6kdu7fOX0fSgVTm@public.gmane.org>
2017-03-23 22:38 ` Alexander Duyck
[not found] ` <CAKgT0Uctdf4N-w72EY8T5Zfw=QCSCgAesXdgOh-HUYdD=Aq9AA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-23 22:49 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490317250.9687.10.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sridhar.samudrala-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).