* Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
[not found] ` <20210901160244.GA5957@asgard.redhat.com>
@ 2021-09-01 16:52 ` Eugene Syromiatnikov
2021-09-01 17:36 ` Steve Grubb
0 siblings, 1 reply; 6+ messages in thread
From: Eugene Syromiatnikov @ 2021-09-01 16:52 UTC (permalink / raw)
To: Cai Huoqing
Cc: linux-audit, strace development discussions, linux-api, davem,
yoshfuji, dsahern, kuba, netdev, linux-kernel, ldv
Adding linux-audit, strace-devel, and linux-api to CC:.
On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
> On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
> > commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
> > indicated the ipx network layer as obsolete in Jan 2018,
> > updated in the MAINTAINERS file
> >
> > now, after being exposed for 3 years to refactoring, so to
> > delete uapi/linux/ipx.h and net/ipx.h header files for good.
> > additionally, there is no module that depends on ipx.h except
> > a broken staging driver(r8188eu)
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>
> This removal breaks audit[1] and potentially breaks strace[2][3], at least.
>
> [1] https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e140c23f68e0c94d95ab6e/auparse/interpret.c#L48
> [2] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/net.c#L34
> [3] https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07ed7106d6b/src/sockaddr.c#L30
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
2021-09-01 16:52 ` [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Eugene Syromiatnikov
@ 2021-09-01 17:36 ` Steve Grubb
2021-09-02 13:35 ` Cai Huoqing
0 siblings, 1 reply; 6+ messages in thread
From: Steve Grubb @ 2021-09-01 17:36 UTC (permalink / raw)
To: Cai Huoqing, Eugene Syromiatnikov
Cc: linux-audit, strace development discussions, linux-api, davem,
yoshfuji, dsahern, kuba, netdev, linux-kernel, ldv
Hello,
Thanks for the heads up.
On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote:
> Adding linux-audit, strace-devel, and linux-api to CC:.
>
> On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
> > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
> > > commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
> > > indicated the ipx network layer as obsolete in Jan 2018,
> > > updated in the MAINTAINERS file
> > >
> > > now, after being exposed for 3 years to refactoring, so to
> > > delete uapi/linux/ipx.h and net/ipx.h header files for good.
> > > additionally, there is no module that depends on ipx.h except
> > > a broken staging driver(r8188eu)
> > >
> > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> >
> > This removal breaks audit[1] and potentially breaks strace[2][3], at
> > least.
I wouldn't say breaks so much as needs coordination with. :-) If ipx is
being dropped in its entirety, I can just make that part of the code
conditional to the header existing.
-Steve
> > [1]
> > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1
> > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2]
> > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > d7106d6b/src/net.c#L34 [3]
> > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > d7106d6b/src/sockaddr.c#L30
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
2021-09-01 17:36 ` Steve Grubb
@ 2021-09-02 13:35 ` Cai Huoqing
2021-09-02 16:08 ` Eugene Syromiatnikov
0 siblings, 1 reply; 6+ messages in thread
From: Cai Huoqing @ 2021-09-02 13:35 UTC (permalink / raw)
To: Steve Grubb
Cc: linux-audit, strace development discussions, linux-api, davem,
yoshfuji, dsahern, kuba, netdev, linux-kernel, ldv
On 01 Sep 21 13:36:54, Steve Grubb wrote:
> Hello,
>
> Thanks for the heads up.
>
> On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote:
> > Adding linux-audit, strace-devel, and linux-api to CC:.
> >
> > On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
> > > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
> > > > commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
> > > > indicated the ipx network layer as obsolete in Jan 2018,
> > > > updated in the MAINTAINERS file
> > > >
> > > > now, after being exposed for 3 years to refactoring, so to
> > > > delete uapi/linux/ipx.h and net/ipx.h header files for good.
> > > > additionally, there is no module that depends on ipx.h except
> > > > a broken staging driver(r8188eu)
> > > >
> > > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > >
> > > This removal breaks audit[1] and potentially breaks strace[2][3], at
> > > least.
>
> I wouldn't say breaks so much as needs coordination with. :-) If ipx is
> being dropped in its entirety, I can just make that part of the code
> conditional to the header existing.
>
> -Steve
IPX is marked obsolete for serveral years. so remove it and the
dependency in linux tree.
I'm sorry to not thinking about linux-audit and strace.
Might you remove the dependency or make the part of the code.
Many thanks.
-Cai
>
> > > [1]
> > > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1
> > > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2]
> > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > > d7106d6b/src/net.c#L34 [3]
> > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > > d7106d6b/src/sockaddr.c#L30
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
2021-09-02 13:35 ` Cai Huoqing
@ 2021-09-02 16:08 ` Eugene Syromiatnikov
2021-09-22 17:01 ` Paul Cercueil
0 siblings, 1 reply; 6+ messages in thread
From: Eugene Syromiatnikov @ 2021-09-02 16:08 UTC (permalink / raw)
To: Cai Huoqing
Cc: Steve Grubb, linux-audit, strace development discussions,
linux-api, davem, yoshfuji, dsahern, kuba, netdev, linux-kernel,
ldv
On Thu, Sep 02, 2021 at 09:35:29PM +0800, Cai Huoqing wrote:
> On 01 Sep 21 13:36:54, Steve Grubb wrote:
> > Hello,
> >
> > Thanks for the heads up.
> >
> > On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote:
> > > Adding linux-audit, strace-devel, and linux-api to CC:.
> > >
> > > On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote:
> > > > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote:
> > > > > commit <47595e32869f> ("<MAINTAINERS: Mark some staging directories>")
> > > > > indicated the ipx network layer as obsolete in Jan 2018,
> > > > > updated in the MAINTAINERS file
> > > > >
> > > > > now, after being exposed for 3 years to refactoring, so to
> > > > > delete uapi/linux/ipx.h and net/ipx.h header files for good.
> > > > > additionally, there is no module that depends on ipx.h except
> > > > > a broken staging driver(r8188eu)
> > > > >
> > > > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > > >
> > > > This removal breaks audit[1] and potentially breaks strace[2][3], at
> > > > least.
> >
> > I wouldn't say breaks so much as needs coordination with. :-) If ipx is
> > being dropped in its entirety, I can just make that part of the code
> > conditional to the header existing.
> >
> > -Steve
> IPX is marked obsolete for serveral years. so remove it and the
> dependency in linux tree.
> I'm sorry to not thinking about linux-audit and strace.
> Might you remove the dependency or make the part of the code.
> Many thanks.
Unfortunately, that is not how UAPI works. That change breaks building
of the existing code; one cannot change already released versions
of either audit, strace, or any other userspace program that happens
to unconditionally include <linux/ipx.h> without any fallback (like
<netipx/ipx.h> provided by glibc).
>
> -Cai
> >
> > > > [1]
> > > > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1
> > > > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2]
> > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > > > d7106d6b/src/net.c#L34 [3]
> > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e
> > > > d7106d6b/src/sockaddr.c#L30
> >
> >
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
2021-09-02 16:08 ` Eugene Syromiatnikov
@ 2021-09-22 17:01 ` Paul Cercueil
2021-09-22 17:25 ` Steve Grubb
0 siblings, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2021-09-22 17:01 UTC (permalink / raw)
To: Eugene Syromiatnikov
Cc: Cai Huoqing, Steve Grubb, linux-audit,
strace development discussions, linux-api, davem, yoshfuji,
dsahern, kuba, netdev, linux-kernel, ldv
Hi,
>> IPX is marked obsolete for serveral years. so remove it and the
>> dependency in linux tree.
>> I'm sorry to not thinking about linux-audit and strace.
>> Might you remove the dependency or make the part of the code.
>> Many thanks.
>
> Unfortunately, that is not how UAPI works. That change breaks
> building
> of the existing code; one cannot change already released versions
> of either audit, strace, or any other userspace program that happens
> to unconditionally include <linux/ipx.h> without any fallback (like
> <netipx/ipx.h> provided by glibc).
Also, the <netipx/ipx.h> fallback is only provided by glibc (and maybe
uclibc?). With this patch, it is now impossible to compile even the
very latest version of "strace" with a musl toolchain.
Cheers,
-Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files
2021-09-22 17:01 ` Paul Cercueil
@ 2021-09-22 17:25 ` Steve Grubb
0 siblings, 0 replies; 6+ messages in thread
From: Steve Grubb @ 2021-09-22 17:25 UTC (permalink / raw)
To: Eugene Syromiatnikov, Paul Cercueil
Cc: Cai Huoqing, linux-audit, strace development discussions,
linux-api, davem, yoshfuji, dsahern, kuba, netdev, linux-kernel,
ldv
On Wednesday, September 22, 2021 1:01:58 PM EDT Paul Cercueil wrote:
> >> IPX is marked obsolete for serveral years. so remove it and the
> >> dependency in linux tree.
> >> I'm sorry to not thinking about linux-audit and strace.
> >> Might you remove the dependency or make the part of the code.
> >> Many thanks.
> >
> > Unfortunately, that is not how UAPI works. That change breaks
> > building
> > of the existing code; one cannot change already released versions
> > of either audit, strace, or any other userspace program that happens
> > to unconditionally include <linux/ipx.h> without any fallback (like
> > <netipx/ipx.h> provided by glibc).
>
> Also, the <netipx/ipx.h> fallback is only provided by glibc (and maybe
> uclibc?). With this patch, it is now impossible to compile even the
> very latest version of "strace" with a musl toolchain.
I've made support for ipx optional in audit user space a couple weeks back.
It's no longer a problem for us.
-Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-22 17:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210813120803.101-1-caihuoqing@baidu.com>
[not found] ` <20210813120803.101-2-caihuoqing@baidu.com>
[not found] ` <20210901160244.GA5957@asgard.redhat.com>
2021-09-01 16:52 ` [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Eugene Syromiatnikov
2021-09-01 17:36 ` Steve Grubb
2021-09-02 13:35 ` Cai Huoqing
2021-09-02 16:08 ` Eugene Syromiatnikov
2021-09-22 17:01 ` Paul Cercueil
2021-09-22 17:25 ` Steve Grubb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).