* [PATCH v2] fscrypt: Remove __packed from fscrypt_policy
@ 2017-04-06 23:14 Joe Richey
[not found] ` <20170406231428.154187-1-joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Joe Richey @ 2017-04-06 23:14 UTC (permalink / raw)
To: linux-fsdevel
Cc: linux-fscrypt, linux-api, Richard Weinberger, Jaegeuk Kim,
Theodore Ts'o, Michael Halcrow, Joe Richey
From: Joe Richey <joerichey@google.com>
This commit removes __packed from fscrypt_policy as it does not contain
any implicit padding and does not refer to an on-disk structure. Even
though this is a change to a UAPI file, no users will be broken as the
structure doesn't change.
Signed-off-by: Joe Richey <joerichey@google.com>
---
include/uapi/linux/fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index 048a85e9f017..f6e1c54ac5e2 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -279,7 +279,7 @@ struct fscrypt_policy {
__u8 filenames_encryption_mode;
__u8 flags;
__u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE];
-} __packed;
+};
#define FS_IOC_SET_ENCRYPTION_POLICY _IOR('f', 19, struct fscrypt_policy)
#define FS_IOC_GET_ENCRYPTION_PWSALT _IOW('f', 20, __u8[16])
--
2.12.2.715.g7642488e1d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] fscrypt: Remove __packed from fscrypt_policy
[not found] ` <20170406231428.154187-1-joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-04-07 9:22 ` Richard Weinberger
2017-04-30 6:16 ` [v2] " Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2017-04-07 9:22 UTC (permalink / raw)
To: Joe Richey, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA
Cc: linux-fscrypt-u79uwXL29TY76Z2rM5mHXA,
linux-api-u79uwXL29TY76Z2rM5mHXA, Richard Weinberger,
Jaegeuk Kim, Theodore Ts'o, Michael Halcrow, Joe Richey
Am 07.04.2017 um 01:14 schrieb Joe Richey:
> From: Joe Richey <joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
> This commit removes __packed from fscrypt_policy as it does not contain
> any implicit padding and does not refer to an on-disk structure. Even
> though this is a change to a UAPI file, no users will be broken as the
> structure doesn't change.
>
> Signed-off-by: Joe Richey <joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> ---
> include/uapi/linux/fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index 048a85e9f017..f6e1c54ac5e2 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -279,7 +279,7 @@ struct fscrypt_policy {
> __u8 filenames_encryption_mode;
> __u8 flags;
> __u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE];
> -} __packed;
> +};
Both patches are fine, just keep my Reviewed-by. :)
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] fscrypt: Remove __packed from fscrypt_policy
[not found] ` <20170406231428.154187-1-joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-07 9:22 ` Richard Weinberger
@ 2017-04-30 6:16 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2017-04-30 6:16 UTC (permalink / raw)
To: Joe Richey
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA,
linux-fscrypt-u79uwXL29TY76Z2rM5mHXA,
linux-api-u79uwXL29TY76Z2rM5mHXA, Richard Weinberger,
Jaegeuk Kim, Michael Halcrow, Joe Richey
On Thu, Apr 06, 2017 at 04:14:28PM -0700, Joe Richey wrote:
> From: Joe Richey <joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
> This commit removes __packed from fscrypt_policy as it does not contain
> any implicit padding and does not refer to an on-disk structure. Even
> though this is a change to a UAPI file, no users will be broken as the
> structure doesn't change.
>
> Signed-off-by: Joe Richey <joerichey-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-30 6:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 23:14 [PATCH v2] fscrypt: Remove __packed from fscrypt_policy Joe Richey
[not found] ` <20170406231428.154187-1-joerichey94-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-07 9:22 ` Richard Weinberger
2017-04-30 6:16 ` [v2] " Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).