archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <>
To: Joe Richey <>
	Richard Weinberger
	Jaegeuk Kim <>,
	Michael Halcrow
	Joe Richey <>
Subject: Re: [v2] fscrypt: Move key structure and constants to uapi
Date: Sun, 30 Apr 2017 02:16:33 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Apr 06, 2017 at 04:14:05PM -0700, Joe Richey wrote:
> From: Joe Richey <>
> This commit exposes the necessary constants and structures for a
> userspace program to pass filesystem encryption keys into the keyring.
> The fscrypt_key structure was already part of the kernel ABI, this
> change just makes it so programs no longer have to redeclare these
> structures (like e4crypt in e2fsprogs currently does).
> Note that we do not expose the other FS_*_KEY_SIZE constants as they are
> not necessary. Only XTS is supported for contents_encryption_mode, so
> currently FS_MAX_KEY_SIZE bytes of key material must always be passed to
> the kernel.
> This commit also removes __packed from fscrypt_key as it does not
> contain any implicit padding and does not refer to an on-disk structure.
> Signed-off-by: Joe Richey <>

Thanks, applied.

					- Ted

      parent reply	other threads:[~2017-04-30  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 23:14 [PATCH v2] fscrypt: Move key structure and constants to uapi Joe Richey
     [not found] ` <>
2017-04-30  6:16   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).